aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* kube play: sd-notify integrationValentin Rothberg2022-08-10
| | | | | | | | | | | | | | | | | Integrate sd-notify policies into `kube play`. The policies can be configured for all contianers via the `io.containers.sdnotify` annotation or for indidivual containers via the `io.containers.sdnotify/$name` annotation. The `kube play` process will wait for all containers to be ready by waiting for the individual `READY=1` messages which are received via the `pkg/systemd/notifyproxy` proxy mechanism. Also update the simple "container" sd-notify test as it did not fully test the expected behavior which became obvious when adding the new tests. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* libpod: allow the notify socket to be passed programaticallyValentin Rothberg2022-08-10
| | | | | | | | | The notify socket can now either be specified via an environment variable or programatically (where the env is ignored). The notify mode and the socket are now also displayed in `container inspect` which comes in handy for debugging and allows for propper testing. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* add `pkg/systemd/notifyproxy`Valentin Rothberg2022-08-10
| | | | | | | | | | Add a new package for proxying notify sockets and waiting for the READY=1 message to appear. May subject to further changes in future commits. Tests make sure that it behaves properly. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* Merge pull request #15172 from graywolf-at-work/document-timestampOpenShift Merge Robot2022-08-10
|\ | | | | [CI:DOCS] Document behavior of --timestamp when only FROM is used
| * Document behavior of --timestamp when only FROM is usedTomas Volf2022-08-10
| | | | | | | | | | | | Fixes: #15171 Signed-off-by: Tomas Volf <tomas.volf@showmax.com>
* | Merge pull request #15267 from ↵OpenShift Merge Robot2022-08-10
|\ \ | |/ |/| | | | | containers/dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.0 build(deps): bump github.com/container-orchestrated-devices/container-device-interface from 0.4.0 to 0.5.0
| * build(deps): bump ↵dependabot[bot]2022-08-10
|/ | | | | | | | | | | | | | | | github.com/container-orchestrated-devices/container-device-interface Bumps [github.com/container-orchestrated-devices/container-device-interface](https://github.com/container-orchestrated-devices/container-device-interface) from 0.4.0 to 0.5.0. - [Release notes](https://github.com/container-orchestrated-devices/container-device-interface/releases) - [Commits](https://github.com/container-orchestrated-devices/container-device-interface/compare/v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: github.com/container-orchestrated-devices/container-device-interface dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* Merge pull request #12865 from rhatdan/crunOpenShift Merge Robot2022-08-10
|\ | | | | I believe that these tests will now run with crun.
| * I believe that these tests will now run with crun.Daniel J Walsh2022-08-09
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #14926 from cdoern/generateSpecOpenShift Merge Robot2022-08-10
|\ \ | | | | | | podman generate spec
| * | podman generate specCharlie Doern2022-08-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | implement a new command `podman generate spec` which can formulate a json specgen to be consumed by both the pod and container creation API. supported flags are --verbose (default true) print output to the terminal --compact print the json output in a single line format to be piped to the API --filename put the output in a file --clone rename the pod/ctr in the spec so it won't conflict w/ an existing entity Signed-off-by: Charlie Doern <cdoern@redhat.com>
* | | Merge pull request #15260 from edsantiago/docs_dedup_continuedOpenShift Merge Robot2022-08-10
|\ \ \ | | | | | | | | Man pages: refactor common options
| * | | Man pages: refactor common optionsEd Santiago2022-08-09
| | |/ | |/| | | | | | | | | | | | | Continued. Harder-to-review ones this time. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #15094 from cdoern/sshOpenShift Merge Robot2022-08-10
|\ \ \ | | | | | | | | podman ssh work, using new c/common interface
| * | | podman ssh work, using new c/common interfaceCharlie Doern2022-08-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | implement new ssh interface into podman this completely redesigns the entire functionality of podman image scp, podman system connection add, and podman --remote. All references to golang.org/x/crypto/ssh have been moved to common as have native ssh/scp execs and the new usage of the sftp package. this PR adds a global flag, --ssh to podman which has two valid inputs `golang` and `native` where golang is the default. Users should not notice any difference in their everyday workflows if they continue using the golang option. UNLESS they have been using an improperly verified ssh key, this will now fail. This is because podman was incorrectly using the ssh callback method to IGNORE the ssh known hosts file which is very insecure and golang tells you not yo use this in production. The native paths allows for immense flexibility, with a new containers.conf field `SSH_CONFIG` that specifies a specific ssh config file to be used in all operations. Else the users ~/.ssh/config file will be used. podman --remote currently only uses the golang path, given its deep interconnection with dialing multiple clients and urls. My goal after this PR is to go back and abstract the idea of podman --remote from golang's dialed clients, as it should not be so intrinsically connected. Overall, this is a v1 of a long process of offering native ssh, and one that covers some good ground with podman system connection add and podman image scp. Signed-off-by: Charlie Doern <cdoern@redhat.com>
* | | | Merge pull request #15244 from baude/machinememorytestsOpenShift Merge Robot2022-08-10
|\ \ \ \ | |_|/ / |/| | | check memory test based on range
| * | | check memory test based on rangeBrent Baude2022-08-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when verifying that the memory was set correctly for a podman machine instance, we check if the number is between a range because based on architecture, operating system, and memory itself this number can differ significantly. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #15199 from baude/addapplehvOpenShift Merge Robot2022-08-09
|\ \ \ \ | | | | | | | | | | Add interface for apple hypervisor
| * | | | Add interface for apple hypervisorBrent Baude2022-08-08
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new apple silicon processesors (m1/m2) are capable of using a performent apple hypervisor (included in macos). Our "virtual providers" for podman machine are part of an interface design. This PR provides an implementation of the interface to begin the work for supporting the apple hypervisor. It is basically only a skeletal PR. The actual code for using the hypervisor and launching a machine will come as several new PRs following the inclusion of this one. There will likely be code reuse between the applehv and qemu code; but none of that code is being moved at this time. It will be moved "on demand" during development. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #15250 from edsantiago/docs_dedup_phase2OpenShift Merge Robot2022-08-09
|\ \ \ \ | | | | | | | | | | Refactor common man page options, phase 2
| * | | | Refactor common man page options, phase 2Ed Santiago2022-08-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Followup to #15174. These are the options that are easy(ish) to review: those that have only drifted slightly, and need only minor tweaks to bring back to sanity. For the most part, I went with the text in podman-run because that was cleaned up in #5192 way back in 2020. These diffs primarily consist of using '**' (star star) instead of backticks, plus other formatting and punctuation changes. This PR also adds a README in the options dir, and a new convention: <<container text...|pod text...>> which tries to do the right thing based on whether the man page name includes "-pod-" or not. Since that's kind of hairy code, I've also added a test suite for it. Finally, since this is impossible to review by normal means, I'm temporarily committing hack/markdown-preprocess-review, a script that will diff option-by-option. I will remove it once we finish this cleanup, but be advised that there are still 130+ options left to examine, and some of those are going to be really hard to reunite. Review script usage: simply run it (you need to have 'diffuse' installed). It isn't exactly obvious, but it shouldn't take more than a minute to figure out. The rightmost column (zzz-chosen.md) is the "winner", the actual content that will be used henceforth. You really want an ultrawide screen here. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #15230 from YoitoFes/Issue-15211OpenShift Merge Robot2022-08-09
|\ \ \ \ \ | |_|_|/ / |/| | | | pkg/bindings: Support writing image push progress to specified io.Writer
| * | | | pkg/bindings: Support writing image push progress to specified io.WriterNaoto Kobayashi2022-08-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently bindings writes image push progress to os.Stderr. Since os.Stderr is inconvenience for bindings caller to process the progress messages, Added this support. Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
* | | | | Merge pull request #15215 from cevich/use_image_searchOpenShift Merge Robot2022-08-09
|\ \ \ \ \ | | | | | | | | | | | | Cirrus: Improve CI VM image updates for EC2
| * | | | | Cirrus: Improve CI VM image updates for EC2Chris Evich2022-08-09
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AWS EC2 keys VM images by an utterly unreadable, horrible to use, generated "AMI ID" value. This is very error prone for humans in practice, since it's impossible to tell one image from the next by eye. Worse, EC2 permits duplicate name-tag values, complicating image specification further. However fortunately, Cirrus-CI recently implemented a feature by which AMI's may be referenced by a name-tag search - choosing the most recent AMI found. Since the `containers/automation_images` build workflow always assigns a unique name + `$IMAGE_SUFFIX` value, we can simply re-use it for both AWS and GCP image specification. In other words as of this commit, specifying new CI VM images can be done by simply updating the `$IMAGE_SUFFIX` value as we've always done. No need to call out a specific AMI ID just for EC2 tasks. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #15225 from unknowndevQwQ/update_logoOpenShift Merge Robot2022-08-09
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS]: update the podman logo
| * | | | | docs: update the podman logounknowndevQwQ2022-08-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for podman/#15222 Signed-off-by: unknowndevQwQ <unknowndevQwQ@pm.me>
* | | | | | Merge pull request #15246 from TomSweeneyRedHat/dev/tsweeney/buildah1.27.0OpenShift Merge Robot2022-08-09
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Bump to Buildah v1.27.0
| * | | | | test: update apply-podman-deltas for new testsAditya R2022-08-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Skip some newly added test for remote and modify error output of a test case which is reporter early in case of podman. [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
| * | | | | build: implement --cache-to,--cache-from and --cache-ttlAditya R2022-08-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
| * | | | | Bump to Buildah v1.27.0tomsweeneyredhat2022-08-08
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As the title says. Vendor Buildah v1.27.0 into Podman in preparation for Buildah v4.2 [No New Tests Needed] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
* | | | | Merge pull request #15134 from sstosh/improve-outputOpenShift Merge Robot2022-08-09
|\ \ \ \ \ | |/ / / / |/| | | | Output messages display rawInput
| * | | | Output messages display rawInputToshiki Sonoda2022-08-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `init`, `checkpint/restore` and `cleanup` command now display output messages which is rawInput instead of a container ID. Example: ``` $ podman init <container name> <container name> $ podman init <short container ID> <short container ID> ``` Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | | | Merge pull request #15239 from giuseppe/use-sandbox-id-gvisorOpenShift Merge Robot2022-08-08
|\ \ \ \ \ | | | | | | | | | | | | specgen: use sandbox id instead of name for annotation
| * | | | | specgen: use sandbox id instead of name for annotationGiuseppe Scrivano2022-08-08
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use the sandbox id instead of the name for the io.kubernetes.cri-o.SandboxID annotation used by gVisor. Closes: https://github.com/containers/podman/issues/15223 [NO NEW TESTS NEEDED] it is specific to gVisor Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #15236 from giuseppe/refuse-userns-with-uidmapOpenShift Merge Robot2022-08-08
|\ \ \ \ \ | | | | | | | | | | | | cmd: refuse --userns if a mapping is specified
| * | | | | cmd: refuse --userns if a mapping is specifiedGiuseppe Scrivano2022-08-08
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if an explicit mapping is specified, do not accept `--userns` since it overriden to "private". Closes: https://github.com/containers/podman/issues/15233 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #15235 from anjannath/pkg-goarchOpenShift Merge Robot2022-08-08
|\ \ \ \ \ | |/ / / / |/| | | | pkginstaller: use correct GOARCH value in case of arm build
| * | | | pkginstaller: use correct GOARCH value in case of arm buildAnjan Nath2022-08-08
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to compile arm bits the GOARCH should be set to amd64 script was wrongly using aarch64 instead [NO NEW TESTS NEEDED] Signed-off-by: Anjan Nath <kaludios@gmail.com>
* | | | Merge pull request #15182 from cevich/remove_disused_envaropenshift-ci[bot]2022-08-07
|\ \ \ \ | |_|/ / |/| | | Cirrus: Remove disused env. var.
| * | | Cirrus: Remove disused env. var.Chris Evich2022-08-03
| | | | | | | | | | | | | | | | | | | | | | | | Hasn't been used for quite a while. Remove it and associated comments. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #15205 from sstosh/ci-run-cleanup-rootlessopenshift-ci[bot]2022-08-06
|\ \ \ \ | | | | | | | | | | e2e: Add rootless mount cleanup test
| * | | | e2e: Add rootless mount cleanup testToshiki Sonoda2022-08-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `podman run -d mount cleanup test` adapt to rootless environment. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | | | Merge pull request #15220 from lsm5/fix-copr-el8-depsopenshift-ci[bot]2022-08-06
|\ \ \ \ \ | | | | | | | | | | | | [CI:COPR] podman.spec.rpkg: add python3 dependency for el8
| * | | | | [CI:COPR] podman.spec.rpkg: add python3 dependency for el8Lokesh Mandvekar2022-08-05
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EL8 builds are failing because hack/markdown-preprocess needs python3 which AFAICT isn't included by default in EL8 build environments. This commit also includes an additional `[CI:COPR]` mode which is currently runs the same tests as `[CI:DOCS]` but could differ in future. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | | | Merge pull request #15093 from karthikelango137/rmiNoPrune1openshift-ci[bot]2022-08-05
|\ \ \ \ \ | | | | | | | | | | | | remove image podman no prune
| * | | | | remove image podman no pruneKarthik Elango2022-08-04
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: Karthik Elango <kelango@redhat.com>
* | | | | Merge pull request #15184 from gbraad/change-config-orderopenshift-ci[bot]2022-08-05
|\ \ \ \ \ | | | | | | | | | | | | Fixes #15154 Change order when config and connections are written
| * | | | | Fixes #15154 Change order when config and connections are writtenGerard Braad2022-08-05
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the break out or the WSL environment fails to start, the config and connections should not be written. Placing them at the end of the provisioning step will mitigate the issue. [NO NEW TESTS NEEDED] Signed-off-by: Gerard Braad <me@gbraad.nl>
* | | | | Merge pull request #15196 from edsantiago/sphinx_commentsopenshift-ci[bot]2022-08-05
|\ \ \ \ \ | | | | | | | | | | | | markdown-preprocess: force extra newline on comments
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-28 14:32:13 +0000