aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Do not set host IP on ports when 0.0.0.0 requestedMatthew Heon2020-08-03
| | | | | | | | | | | | | | | | Docker and CNI have very different ideas of what 0.0.0.0 means. Docker takes it to be 0.0.0.0/0 - that is, bind to every IPv4 address on the host. CNI (and, thus, root Podman) take it to mean the literal IP 0.0.0.0. Instead, CNI interprets the empty string ("") as "bind to all IPs". We could ask CNI to change, but given this is established behavior, that's unlikely. Instead, let's just catch 0.0.0.0 and turn it into "" when we parse ports. Fixes #7014 Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #7182 from zhangguanzhang/fix-exitCode-for-startOpenShift Merge Robot2020-08-03
|\ | | | | implement the exitcode when start a container with attach
| * implement the exitcode when start a container with attachzhangguanzhang2020-08-03
| | | | | | | | Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
* | Merge pull request #7193 from vrothberg/fix-7190OpenShift Merge Robot2020-08-03
|\ \ | | | | | | podman.service: drop install section
| * | podman.service: drop install sectionValentin Rothberg2020-08-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman.service is socket activated through podman.socket. It should not have its own [Install] section, it does not make sense to systemctl enable podman.service. This leads to podman.service always running on a Debian system, as Debian's policy is to enable/start running services by default. We don't want a daemon :^) Fixes: #7190 Reported-by: @martinpitt Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #7097 from QiWang19/usagedateOpenShift Merge Robot2020-08-03
|\ \ \ | | | | | | | | [CI:DOCS] apiv2 fix volumes not included field
| * | | [CI:DOCS] apiv2 fix volumes not inculded fieldQi Wang2020-07-29
| | | | | | | | | | | | | | | | | | | | | | | | Do not use volume from docker since UsageData field is not need. It's nullable in docker API and expensive to add. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #7194 from vrothberg/systetemd-auto-updateOpenShift Merge Robot2020-08-03
|\ \ \ \ | | | | | | | | | | Systemd: install auto-update service and timer
| * | | | Install auto-update services for usersValentin Rothberg2020-08-03
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | | Fix test failure regarding unpackaged files.Peter Oliver2020-08-03
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Peter Oliver <git@mavit.org.uk>
| * | | | Install auto-update systemd service and timer.Peter Oliver2020-08-03
| | |/ / | |/| | | | | | | | | | Signed-off-by: Peter Oliver <git@mavit.org.uk>
* | | | Merge pull request #7076 from alvistack/master-linux-amd64OpenShift Merge Robot2020-08-03
|\ \ \ \ | | | | | | | | | | Speedup static build by utilizing CI cache on `/nix` folder
| * | | | Speedup static build by utilizing CI cache on `/nix` folderWong Hoi Sing Edison2020-08-03
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Wong Hoi Sing Edison <hswong3i@gmail.com>
* | | | | Merge pull request #7188 from zhangguanzhang/network-404OpenShift Merge Robot2020-08-03
|\ \ \ \ \ | | | | | | | | | | | | API returns 500 in case network is not found instead of 404
| * | | | | API returns 500 in case network is not found instead of 404zhangguanzhang2020-08-02
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
* | | | | Merge pull request #7191 from openSUSE/printfOpenShift Merge Robot2020-08-03
|\ \ \ \ \ | | | | | | | | | | | | Remove some unnecessary []byte to string conversions
| * | | | | Remove some unnecessary []byte to string conversionsSascha Grunert2020-08-03
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Some calls to `Sprintf("%s")` can be avoided by using direct string type assertions. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | | | Merge pull request #7158 from rhatdan/commitOpenShift Merge Robot2020-08-03
|\ \ \ \ \ | |/ / / / |/| | | | Handle single character images
| * | | | Handle single character imagesDaniel J Walsh2020-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently you can only specify multiple character for image names when executing podman-remote commit podman-remote commit a b Will complete, but will save the image without a name. podman-remote commit a bb Works. This PR fixes and now returns an error if the user doees not specify an image name to commit to. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #7141 from rhafer/image_descr_testOpenShift Merge Robot2020-08-03
|\ \ \ \ \ | |_|/ / / |/| | | | Add test case for description being present in search result
| * | | | Make `search --no-trunc` work for podman remoteRalf Haferkamp2020-07-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The HTTP API for image search was still lacking support of the NoTrunc parameter. Signed-off-by: Ralf Haferkamp <rhafer@suse.com>
| * | | | API: Fix 'podman image search` missing descriptionRalf Haferkamp2020-07-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `podman image search` returned wrong results for the image "Description" as it was mapped to the wrong field ("ID") in the search results. Basically cherry-picked into the api from commit cf5c63b5c492e41d72b6e3b6d75b5f39b0a957fd. Signed-off-by: Ralf Haferkamp <rhafer@suse.com>
| * | | | Add test case for description being present in search resultRalf Haferkamp2020-07-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test for a specific static image and match the description to avoid regression like https://github.com/containers/podman/pull/7131 Signed-off-by: Ralf Haferkamp <rhafer@suse.com>
* | | | | Merge pull request #7181 from Luap99/systemd-unit-pathOpenShift Merge Robot2020-08-02
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] Change recommended systemd unit path for root.
| * | | | | Change recommended systemd unit path for root.Paul Holzinger2020-08-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `/usr/lib/systemd/system` should only be used by the package manager administrators should use: `/etc/systemd/system` or `/usr/local/lib/systemd/system` see: man systemd.unit Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | | | Merge pull request #7171 from jwhonce/wip/varlink_timeoutOpenShift Merge Robot2020-08-01
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix podman service --valink timeout
| * | | | | | Fix podman service --valink timeoutJhon Honce2020-07-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Documentation and unit files call for a millisecond timeout while the code was using a second resolution. Code change is smaller given varlink has been deprecated. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | | Merge pull request #7177 from mheon/there_can_be_only_oneOpenShift Merge Robot2020-08-01
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Ensure libpod/define does not include libpod/image
| * | | | | | | Ensure libpod/define does not include libpod/imageMatthew Heon2020-07-31
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The define package under Libpod is intended to be an extremely minimal package, including constants and very little else. However, as a result of some legacy code, it was dragging in all of libpod/image (and, less significantly, the util package). Fortunately, this was just to ensure that error constants were not duplicating, and there's nothing preventing us from importing in the other direction and keeping libpod/define free of dependencies. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | | Merge pull request #7165 from jwhonce/issues/7008OpenShift Merge Robot2020-08-01
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add versioned _ping endpoint
| * | | | | | | Add versioned _ping endpointJhon Honce2020-07-31
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7008 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | | Merge pull request #7178 from mheon/update_master_204OpenShift Merge Robot2020-08-01
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | [CI:DOCS] Update master README and release notes for v2.0.4
| * | | | | | Update master README and release notes for v2.0.4Matthew Heon2020-07-31
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #7152 from Luap99/fix#7087OpenShift Merge Robot2020-07-31
|\ \ \ \ \ \ | |/ / / / / |/| | | | | fix pod creation with "new:" syntax
| * | | | | fix pod creation with "new:" syntaxPaul Holzinger2020-07-31
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you execute podman create/run with the --pod new:<name> syntax the pod was created but the namespaces where not shared and therefore containers could not communicate over localhost. Add the default namespaces and pass the network options to the pod create options. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | | Merge pull request #7168 from QiWang19/exec-fdsOpenShift Merge Robot2020-07-31
|\ \ \ \ \ | |/ / / / |/| | | | Fix close fds of exec --preserve-fds
| * | | | Fix close fds of exec --preserve-fdsQi Wang2020-07-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the closing of fds from --preserve-fds to avoid the operation on unrelated fds. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | Merge pull request #7120 from QiWang19/preserve-fdOpenShift Merge Robot2020-07-31
|\ \ \ \ \ | |/ / / / |/| | | | Fix close fds of run --preserve-fds
| * | | | fix close fds of run --preserve-fdsQi Wang2020-07-30
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | Test flakes mentioned in #6987 might be caused by uncorrect closing of file descriptor. Fix the code to close file descriptors for podman run since it may close those used by other processes. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #7164 from giuseppe/volumes-chown-no-recurseOpenShift Merge Robot2020-07-31
|\ \ \ \ | | | | | | | | | | volumes: do not recurse when chowning
| * | | | volumes: do not recurse when chowningGiuseppe Scrivano2020-07-31
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keep the file ownership when chowning and honor the user namespace mappings. Closes: https://github.com/containers/podman/issues/7130 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #7162 from giuseppe/add-rootless-checksOpenShift Merge Robot2020-07-31
|\ \ \ \ | | | | | | | | | | rootless: do not ignore errors if mappings are specified
| * | | | rootless: add a check for the host id included in the rangeGiuseppe Scrivano2020-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add a check to verify whether the additional IDs also contain the host ID. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | rootless: child exits immediately on userns errorsGiuseppe Scrivano2020-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if the parent process failed to create the user namespace, let the child exit immediately. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | rootless: do not ignore errors if mappings are specifiedGiuseppe Scrivano2020-07-30
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when setting up the user namespace do not ignore errors from newuidmap/newgidmap if there are mappings configured. The single user mapping is a fallback only when there are not mappings specified for the user. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #7159 from ashley-cui/runningforOpenShift Merge Robot2020-07-31
|\ \ \ \ | | | | | | | | | | add {{.RunningFor}} placeholder in ps --format
| * | | | add {{.RunningFor}} placeholder in ps --formatAshley Cui2020-07-30
| |/ / / | | | | | | | | | | | | | | | | | | | | For docker compatibility Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Merge pull request #7161 from Luap99/fix#7160OpenShift Merge Robot2020-07-30
|\ \ \ \ | |/ / / |/| | | fix swapped mem_usage/percent fields
| * | | fix swapped mem_usage/percent fieldsPaul Holzinger2020-07-30
|/ / / | | | | | | | | | | | | | | | Correct the wrong field assignment in `podman stats --format=json`. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #7156 from zhangguanzhang/masterOpenShift Merge Robot2020-07-30
|\ \ \ | | |/ | |/| fix podman system df format error