aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* podman pod create --uts supportcdoern2022-07-05
| | | | | | | | | | | | add support for the --uts flag in pod create, allowing users to avoid issues with default values in containers.conf. uts follows the same format as other namespace flags: --uts=private (default), --uts=host, --uts=ns:PATH resolves #13714 Signed-off-by: Charlie Doern <cdoern@redhat.com>
* Merge pull request #14823 from Luap99/debian-unit-testsopenshift-ci[bot]2022-07-05
|\ | | | | envVarValueResourceFieldRef: use int64 for value
| * pkg/machine: add missing build tags to testsPaul Holzinger2022-07-04
| | | | | | | | | | | | | | | | | | Machine can only run on amd64 and arm64 platforms so we need to make sure the test are only run on those platforms. We do not have CI checks for this but it fails in debian build infra since debian supports many other architectures as well. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * TestEnvVarValue: fix assertionPaul Holzinger2022-07-04
| | | | | | | | | | | | | | | | | | assert.Equal() already follows to pointer and compares by value so we can just directly pass the values. This will make errors much more obvious. Also remove the fmt.Println() since the error now contains the values. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * envVarValueResourceFieldRef: use int64 for valuePaul Holzinger2022-07-04
| | | | | | | | | | | | | | | | | | | | int can be 32 or 64 bit depending on the architecture. The total memory is int64 so we have to use int64 for the value as well otherwise we get an overflow on 32 bit systems. Fixes #14819 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #14829 from saschagrunert/errors-hack-test-utilsopenshift-ci[bot]2022-07-05
|\ \ | | | | | | hack/test/utils: switch to golang native error wrapping
| * | hack/test/utils: switch to golang native error wrappingSascha Grunert2022-07-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | We now use the golang error wrapping format specifier `%w` instead of the deprecated github.com/pkg/errors package. [NO NEW TESTS NEEDED] Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
* | | Merge pull request #14813 from ↵openshift-ci[bot]2022-07-05
|\ \ \ | | | | | | | | | | | | | | | | eriksjolund/add_troubleshooting_tip_about_carriage_return [CI:DOCS] troubleshooting: document --tty and CR
| * | | [CI:DOCS] troubleshooting: document --tty and CRErik Sjölund2022-07-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add troubleshooting tip "Unexpected carriage returns are outputted on the terminal" Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | Merge pull request #14827 from flouthoc/specgen-run-support-manifestopenshift-ci[bot]2022-07-05
|\ \ \ \ | |_|/ / |/| | | specgen,run: support running container from valid manifest list using `--platform`
| * | | specgen,run: support running container from valid manifest listAditya R2022-07-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Following PR adds support for running containers from a manifest list present on localstorage. Before this PR podman only supports running containers from valid images but not from manifest list. So `podman run -it --platform <some> <manifest-list> command` should become functional now and users should be able to resolve images on the bases of provided `--platform` string. Example ``` podman manifest create test podman build --platform linux/amd64,linux/arm64 --manifest test . podman run --rm --platform linux/arm64/v8 test uname -a ``` Closes: https://github.com/containers/podman/issues/14773 Signed-off-by: Aditya R <arajan@redhat.com>
* | | | Merge pull request #14789 from saschagrunert/libpod-errorsopenshift-ci[bot]2022-07-05
|\ \ \ \ | |/ / / |/| | | libpod/runtime: switch to golang native error wrapping
| * | | libpod/runtime: switch to golang native error wrappingSascha Grunert2022-07-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We now use the golang error wrapping format specifier `%w` instead of the deprecated github.com/pkg/errors package. [NO NEW TESTS NEEDED] Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
* | | | Merge pull request #14822 from Luap99/dns-testopenshift-ci[bot]2022-07-04
|\ \ \ \ | |_|_|/ |/| | | fix flake in aardvark tests
| * | | fix flake in aardvark testsPaul Holzinger2022-07-04
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The retry logic in digshort() did not work because dig always exits with 0 even when the domain name is not found. To make it work we have to check the standard output. We work on fixing the underlying issue in aardvark/netavark but this will take more time. Fixes #14173 Fixes #14171 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #14807 from eriksjolund/fix_read_only_spellingopenshift-ci[bot]2022-07-04
|\ \ \ | | | | | | | | [CI:DOCS] Fix spelling "read only" -> "read-only"
| * | | Fix spelling "read only" -> "read-only"Erik Sjölund2022-07-02
| | | | | | | | | | | | | | | | Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | Merge pull request #14816 from giuseppe/drop-pod-create--device-read-bps-testopenshift-ci[bot]2022-07-04
|\ \ \ \ | | | | | | | | | | test: drop pod-create --device-read-bps test
| * | | | test: drop pod-create --device-read-bps testGiuseppe Scrivano2022-07-03
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the test is not doing what it believes to do. The containers are not supposed to be joining the infra container cgroup. In addition, the result is validated only on cgroup v1 systems (that are not used in the CI). We may want to add it back, or a variant of it, once the --device-read-bps option applies to the pod parent cgroup. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #14802 from cdoern/podMemoryopenshift-ci[bot]2022-07-03
|\ \ \ \ | |_|_|/ |/| | | podman pod create --memory
| * | | podman pod create --memoryCharlie Doern2022-07-01
| |/ / | | | | | | | | | | | | | | | | | | | | | using the new resource backend, implement podman pod create --memory which enables users to modify memory.max inside of the parent cgroup (the pod), implicitly impacting all children unless overriden Signed-off-by: Charlie Doern <cdoern@redhat.com>
* | | Merge pull request #14808 from vorburger/patch-2openshift-ci[bot]2022-07-02
|\ \ \ | |/ / |/| | [CI:DOCS] Remove -s from systemctl enable --now sshd
| * | docs: Remove -s from systemctl enable --now sshdMichael Vorburger ⛑️2022-07-02
|/ / | | | | | | | | This flag does not work (e.g. on Fedora 36) and not appear to be required (anymore?). Signed-off-by: Michael Vorburger ⛑️ <mike@vorburger.ch>
* | Merge pull request #14799 from vrothberg/fix-buildopenshift-ci[bot]2022-07-01
|\ \ | | | | | | fix build
| * | fix buildValentin Rothberg2022-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | PR containers/podman/pull/14449 had an outdated base. Merging it broke builds. [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | Merge pull request #14798 from flouthoc/overlay-mount-path-absopenshift-ci[bot]2022-07-01
|\ \ \ | |/ / |/| | overlay,mount: convert source to absolute path for `overlay` mounts of paths
| * | overlay,mount: convert lowerdir to absolute path for overlay mounts of pathAditya R2022-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When mounting paths as overlay mounts we end up passing source as is to lowerdir options, resolve all relative paths in such cases for overlay mounts. Closes: https://github.com/containers/podman/issues/14797 Signed-off-by: Aditya R <arajan@redhat.com>
* | | Merge pull request #14794 from n1hility/fix-winopenshift-ci[bot]2022-07-01
|\ \ \ | | | | | | | | Fix podman machine on Windows
| * | | Fix podman machine on WindowsJason T. Greene2022-06-30
| |/ / | | | | | | | | | Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
* | | Merge pull request #14795 from giuseppe/fix-wildcard-major-device-cgroupopenshift-ci[bot]2022-07-01
|\ \ \ | | | | | | | | specgen: fix parsing of cgroup devices rule
| * | | specgen: fix parsing of cgroup devices ruleGiuseppe Scrivano2022-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the parse for the cgroup devices rule to correctly handle the wildcard syntax for the device major. Also make sure the device major and minor are not negative numbers. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #14788 from vrothberg/rename-templateopenshift-ci[bot]2022-07-01
|\ \ \ \ | | | | | | | | | | podman-play-kube template: rename to podman-kube
| * | | | docs: mention the podman-kube templateValentin Rothberg2022-06-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mention the template in the docs for play-kube and generate-systemd. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | podman-play-kube template: rename to podman-kubeValentin Rothberg2022-06-30
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the upcoming plans of introducing a podman-kube command with various subcommands, rename the podman-play-kube systemd template to podman-kube before releasing it. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | Merge pull request #14449 from cdoern/podVolumesopenshift-ci[bot]2022-07-01
|\ \ \ \ | |_|/ / |/| | | podman volume create --opt=o=timeout...
| * | | podman volume create --opt=o=timeout...cdoern2022-06-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | add an option to configure the driver timeout when creating a volume. The default is 5 seconds but this value is too small for some custom drivers. Signed-off-by: cdoern <cdoern@redhat.com>
* | | | Merge pull request #14704 from baude/machinestoppedopenshift-ci[bot]2022-06-30
|\ \ \ \ | | | | | | | | | | reveal machine error, ignore false state
| * | | | reveal machine error, ignore false stateBrent Baude2022-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR covers two edge cases discovered by fiddling with machine manually. It is possible (like after a manual cleanup of a machine) that a leftover qemu socket file can indicate the prescense of a machine running. Also, reveal the error of a Exec.Command by wrapping the generic error around what was in stderr. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #14787 from giuseppe/move-systemd-service-to-subcgroupopenshift-ci[bot]2022-06-30
|\ \ \ \ \ | |_|_|_|/ |/| | | | service: do not run under the root cgroup
| * | | | service: do not run under the root cgroupGiuseppe Scrivano2022-06-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | at startup, when running on a cgroup v2 system, check if the current process is running in the root cgroup and move it to a sub-cgroup, otherwise Podman is not able to create cgroups and move processes there. Closes: https://github.com/containers/podman/issues/14573 [NO NEW TESTS NEEDED] it needs nested podman Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | utils: move the cgroup if root on cgroupv2Giuseppe Scrivano2022-06-30
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | if we are running on cgroupv2, force the creation of a sub-cgroup even when we are at the root for the cgroup v2 unified mount. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #14785 from saschagrunert/cmd-podman-errorsDaniel J Walsh2022-06-30
|\ \ \ \ | | | | | | | | | | cmd/podman: switch to golang native error wrapping
| * | | | cmd/podman: switch to golang native error wrappingSascha Grunert2022-06-30
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | We now use the golang error wrapping format specifier `%w` instead of the deprecated github.com/pkg/errors package. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
* | | | Merge pull request #14783 from flouthoc/api-image-lookup-manifestopenshift-ci[bot]2022-06-30
|\ \ \ \ | |/ / / |/| | | api,images: add support for `LookupManifest` to `Image removal` REST API
| * | | api,images: add support for LookupManifest to Image remove APIAditya R2022-06-30
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ImagesBatchRemoval and ImageRemoval now honors and accepts `LookupManifest` parameter which further tells libimage to resolve to manifest list if it exists instead of actual image. Following PR also makes `podman-remote manifest rm` functional which was broken till now. Closes: https://github.com/containers/podman/issues/14763 Signed-off-by: Aditya R <arajan@redhat.com>
* | | Merge pull request #14770 from ↵openshift-ci[bot]2022-06-29
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/stretchr/testify-1.8.0 build(deps): bump github.com/stretchr/testify from 1.7.5 to 1.8.0
| * | | build(deps): bump github.com/stretchr/testify from 1.7.5 to 1.8.0dependabot[bot]2022-06-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.5 to 1.8.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.7.5...v1.8.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #14720 from sstosh/rm-optionopenshift-ci[bot]2022-06-29
|\ \ \ \ | | | | | | | | | | Fix: Prevent OCI runtime directory remain
| * | | | Fix: Prevent OCI runtime directory remainToshiki Sonoda2022-06-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This bug was introduced in https://github.com/containers/podman/pull/8906. When we use 'podman rm/restart/stop/kill etc...' command to the container running with --rm, the OCI runtime directory remains at /run/<runtime name> (root user) or /run/user/<user id>/<runtime name> (rootless user). This bug could cause other bugs. For example, when we checkpoint the container running with --rm (podman checkpoint --export) and restore it (podman restore --import) with crun, error message "Error: OCI runtime error: crun: container `<container id>` already exists" is outputted. This error is caused by an attempt to restore the container with the same container ID as the remaining OCI runtime's container ID. Therefore, I fix that the cleanupRuntime() function runs to remove the OCI runtime directory, even if the container has already been removed by --rm option. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | | | Merge pull request #14706 from ashley-cui/rootmachopenshift-ci[bot]2022-06-29
|\ \ \ \ \ | | | | | | | | | | | | Only allow Rootless runs of Podman Machine
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-09-24 22:25:32 +0000