aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #15937 from rhatdan/manOpenShift Merge Robot2022-09-27
|\ | | | | [CI:DOCS] Add SELinux information about boolean for using random devices
| * Add SELinux information about boolean for using random devicesDaniel J Walsh2022-09-26
| | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/15930 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #15908 from edsantiago/systemd_tty_testOpenShift Merge Robot2022-09-27
|\ \ | | | | | | System tests: light cleanup
| * | System tests: light cleanupEd Santiago2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Followup to #15895: - add a normal-case test, to ensure that --privileged without systemd continues to pass through /dev/ttyN devices - explain why we die() if host has no ttyN devices - I find grep -vx slightly easier to read than sed backslash-slash - run cleanup with '-t 0', to shave ten seconds from CI run Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #15958 from piotr-sk/fix/kube_play_liveness_probeOpenShift Merge Robot2022-09-27
|\ \ \ | | | | | | | | fix: liveness check with http probe
| * | | fix: liveness check with http probePiotr2022-09-27
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Ensure kubernetes default parameters are respected. Additional curl parameter enforces returning error for HTTP error codes. Use build-in HealthCheckOnFailureAction instead of killing the container while executing the probe. Signed-off-by: Piotr <piotr.skoczylas@gmail.com>
* | | Merge pull request #15896 from edsantiago/dont_install_toolsChris Evich2022-09-27
|\ \ \ | | | | | | | | CI: only make install.tools when needed
| * | | CI: only make install.tools when neededEd Santiago2022-09-27
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reintroduce .install.foo targets into Makefile, and invoke only the bare-minimum ones needed for each individual CI step in setup_environment.sh. Also add a retry to the golangci-lint curl, in hopes of dealing with network flakes. And remove the -f (fail) because it produces unhelpful logs. Reason: saw about 25% CI flakes yesterday due to the golangci-lint fetch, something about a timeout, and this was especially frustrating because none of the steps actually needed lint. Quick reminder: avoid network fetches unless absolutely necessary. Fixes: #15892 Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #15948 from ashley-cui/osxcrossOpenShift Merge Robot2022-09-27
|\ \ \ | |/ / |/| | Cirrus: Build pkginstaller in CI
| * | Cirrus: Build pkginstaller in CIAshley Cui2022-09-26
| | | | | | | | | | | | | | | | | | Build unsigned pkginstaller in OSX Cross CI task & upload as an artifact. Signed-off-by: Ashley Cui <acui@redhat.com>
* | | Merge pull request #15916 from ashley-cui/machstartingOpenShift Merge Robot2022-09-27
|\ \ \ | | | | | | | | Fix machine starting state
| * | | Fix machine starting stateAshley Cui2022-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Machine starting now is correctly displayed on podman machine list --format json [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Merge pull request #15471 from cdoern/sshOpenShift Merge Robot2022-09-27
|\ \ \ \ | | | | | | | | | | podman machine ssh handling
| * | | | podman machine ssh handlingCharlie Doern2022-09-26
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add the key used in newly initialized machines to the user's known_hosts file. This ensures that golang will be able to ssh into the machine using podman-remote. Also, remove the /dev/null redirection for podman machine ssh's known_hosts file. resolves #15347 Signed-off-by: Charlie Doern <cdoern@redhat.com> Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | | Merge pull request #15941 from mheon/bump_430_rc1OpenShift Merge Robot2022-09-26
|\ \ \ \ | |_|_|/ |/| | | Bump to v4.3.0-RC1
| * | | Bump to v4.3.0-devMatthew Heon2022-09-26
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | Bump to v4.3.0-RC1v4.3.0-rc1Matthew Heon2022-09-26
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #15933 from vrothberg/fix-15879OpenShift Merge Robot2022-09-26
|\ \ \ \ | | | | | | | | | | auto-update: validate container image
| * | | | auto-update: validate container imageValentin Rothberg2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Auto updates using the "registry" policy require container to be created with a fully-qualified image reference. Short names are not supported due the ambiguity of their source registry. Initially, container creation errored out for non FQN images but it seems that Podman has regressed. Fixes: #15879 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | | Merge pull request #15940 from edsantiago/docs_dedup_env_fileOpenShift Merge Robot2022-09-26
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] Man pages: refactor common options: --env-file
| * | | | | Man pages: refactor common options: --env-fileEd Santiago2022-09-26
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Another easy one. Option is only present in these three man pages. I took the liberty of changing the "See note" text, making it the same as --env. I also took the liberty of hyphenating "line-delimited" because that's the correct thing to do. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #15907 from Luap99/compat-net-optsOpenShift Merge Robot2022-09-26
|\ \ \ \ \ | |/ / / / |/| | | | compat API: network inspect do not show isolate option
| * | | | compat API: network inspect do not show isolate optionPaul Holzinger2022-09-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We force the isolate option on new newtworks because that is the docker behavior. However when we inspect them they should not be displayed to the caller since they have no idea about it and docker-compose throws an error because of that. Fixes #15580 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #15938 from edsantiago/docs_dedup_envOpenShift Merge Robot2022-09-26
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] Man pages: refactor common options: --env
| * | | | | Man pages: refactor common options: --envEd Santiago2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only among podman create, exec, run. The same option in podman build, generate-systemd, and secret-create is too different. Should be a trivial one to review, the only difference is a period at the end of one sentence. And, of course, the "See Environment note" applies only to podman-create and run, not exec, so it can't be deduplicated. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #15813 from praveenkumar/podman-remote-container-fileOpenShift Merge Robot2022-09-26
|\ \ \ \ \ \ | |/ / / / / |/| | | | | [CI:BUILD] Contrib: Add containerfile to create podman-remote binary image
| * | | | | Contrib: Add containerfile to create podman-remote binary imagePraveen Kumar2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Try to partial address #14664 Signed-off-by: Praveen Kumar <kumarpraveen.nitdgp@gmail.com>
* | | | | | Merge pull request #15936 from edsantiago/docs_dedup_sigproxyOpenShift Merge Robot2022-09-26
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | [CI:DOCS] Man pages: Refactor common options: --sig-proxy
| * | | | | Man pages: Refactor common options: --sig-proxyEd Santiago2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unusually, I discarded the podman-run version and went with the one common to attach and start. (The defaults are left out of the common file, because 'start' is different by necessity). Please review extra-carefully to make sure the new wording applies to podman-run, in particular the "non-TTY mode" words. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #15935 from edsantiago/xref_manpage_titleOpenShift Merge Robot2022-09-26
|\ \ \ \ \ \ | |/ / / / / |/| | | | | [CI:DOCS] man page xref: verify page title
| * | | | | man page xref: verify page titleEd Santiago2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Issue #15923 should have never happened: the problem should've been autodetected. Make it so henceforth (and fix another existing discrepancy) Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #15926 from eriksjolund/remove_redundant_log_outputOpenShift Merge Robot2022-09-26
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove redundant log message
| * | | | | | Remove redundant log messageErik Sjölund2022-09-26
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Fixes: https://github.com/containers/podman/issues/15925 Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | | | Merge pull request #15893 from cevich/ioutil_whineOpenShift Merge Robot2022-09-26
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | [CI:BUILD] Cirrus: Catch use of deprecated ioutils package
| * | | | | Cirrus: Catch use of deprecated io/ioutil packageChris Evich2022-09-23
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the time of this commit, there's no easier way to detect this using `golangci-lint` or the go tool (that I could find). A future update to the `go list` command may support detection, for now use a CI script. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #15924 from eriksjolund/fix_podman_system_service_man_pageOpenShift Merge Robot2022-09-26
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] man pages: fix incorrect title
| * | | | | [CI:DOCS] man pages: fix incorrect titleErik Sjölund2022-09-24
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/15923 Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | | Merge pull request #15820 from vrothberg/fix-15800OpenShift Merge Robot2022-09-26
|\ \ \ \ \ | |_|_|_|/ |/| | | | kube: notifyproxy: fix lost READY message
| * | | | notifyproxy: don't set a read deadlineValentin Rothberg2022-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The read deadline may yield the READY message to be lost in space. Instead, use a more Go-idiomatic alternative by using two goroutines; one reading from the connection, the other watching the container. [NO NEW TESTS NEEDED] since existing tests are exercising this functionality already. Fixes: #15800 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | kube play: sdnotify proxy: use a wait groupValentin Rothberg2022-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use a wait group to a) wait for all proxies in parallel b) avoid the potential for ABBA deadlocks [NO NEW TESTS NEEDED] as it is not changing functionality Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | | Merge pull request #15911 from yrro/fix-libsubid-detectionOpenShift Merge Robot2022-09-26
|\ \ \ \ \ | |_|/ / / |/| | | | Fix libsubid detection
| * | | | Fix libsubid detectionSam Morris2022-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Library arguments must be positioned after sources when invoking GCC. Signed-off-by: Sam Morris <sam@robots.org.uk>
* | | | | Merge pull request #15900 from rhatdan/VENDOROpenShift Merge Robot2022-09-23
|\ \ \ \ \ | | | | | | | | | | | | Update vendor of containers(image, common, buildah, storage)
| * | | | | Fixup Buildah mergeEd Santiago2022-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes since 2022-09-09: - man page: add --skip-unused-stages (buildah 4249) - man page: bring in new Note for --cache-ttl (4248) - system tests: de-stutter (4205) - (internal): in skip() applier: escape asterisk, otherwise the "bud with --dns* flags" sed expression never applies. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | | | Update vendor or containers/buildahDaniel J Walsh2022-09-23
| | |_|/ / | |/| | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #15873 from ashley-cui/prettysecretsOpenShift Merge Robot2022-09-23
|\ \ \ \ \ | | | | | | | | | | | | Add --pretty to podman secret inspect
| * | | | | Add --pretty to podman secret inspectAshley Cui2022-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pretty-print podman secret inspect output in a human-readable format Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | | | Merge pull request #15463 from mheon/fix_15408OpenShift Merge Robot2022-09-23
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Events for containers in pods now include the pod's ID
| * | | | | Events for containers in pods now include the pod's IDMatthew Heon2022-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows tools like Cockpit to know that the pod in question has also been updated, so they can refresh the list of containers in the pod. Fixes #15408 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #15905 from lsm5/fix-coprOpenShift Merge Robot2022-09-23
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:BUILD] Copr: also define _user_tmpfilesdir for f35