aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Examine all SkipIfRemote functionsDaniel J Walsh2020-09-25
| | | | | | | | Remove ones that are not needed. Document those that should be there. Document those that should be fixed. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Update release notes for v2.1.1Matthew Heon2020-09-25
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* HTTP Attach: Wait until both STDIN and STDOUT finishMatthew Heon2020-09-25
| | | | | | | | | | | | | | | In the old code, there was a chance that we could return when only one of STDIN or STDOUT had finished - this could lead to us dropping either input to the container, or output from it, in the case that one stream terminated early. To resolve this, use separate channels to return STDOUT and STDIN errors, and track which ones have returned cleanly to ensure that we need bith in order to return from the HTTP attach function and pass control back to the HTTP handler (which would assume we exited cleanly and close the client's attach connection). Signed-off-by: Matthew Heon <mheon@redhat.com>
* Evict containers before removing via V2 APIJhon Honce2020-09-25
| | | | | | Fixes #7535 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* remote load: check if input is directoryValentin Rothberg2020-09-25
| | | | | | | | The remote client does not support loading directories yet. To prevent confusing error messages and to make the behaviour more explicit, check if the input points to a directory and throw an error if needed. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* build: honor --runtime settingGiuseppe Scrivano2020-09-25
| | | | | | pass down to Buildah the --runtime setting. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* set interactive mode with compat create endpointbaude2020-09-25
| | | | | | when creating a container using the compat endpoint, the interactive bool was being hard set to false and ignoring the user's input. Signed-off-by: baude <bbaude@redhat.com>
* apiv2 container limit differ from docker-apizhangguanzhang2020-09-25
| | | | Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
* Allow filtering on pod label valuesJordan Christiansen2020-09-25
| | | | | | | | | | | | | | | Before this change, filters of the form `podman pod ps --filter label=app=myapp` were not working. The results would include all pods that contained the app label with any value. Looking at the code, this makes sense. It appears that the second = and everything after it were getting truncated. Even though there was already a passing test that tested `podman pod ps --filter label=io.podman.test.label=value1`, the test failed with the above example with a label `app=myapp`. The new code works in both cases. Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
* Remove final v2remotefail failuresDaniel J Walsh2020-09-25
| | | | | | | | | Most have been fixed, others I replaced with SkipIfRemote Fix ContainerStart on tunnel, it needs to wait for the exit status before returning. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Fix a bug where log-driver json-file was made no logsMatthew Heon2020-09-25
| | | | | | | | | When we added the None log driver, it was accidentally added in the middle of a set of Fallthrough stanzas which all should have led to k8s-file, so that JSON file logging accidentally caused no logging to be selected instead of k8s-file. Signed-off-by: Matthew Heon <mheon@redhat.com>
* add missing return for compat killbaude2020-09-25
| | | | | | on an error condition in kill for the compatibility layer, we were missing a return. Signed-off-by: baude <bbaude@redhat.com>
* Include cgroup manager in `podman info` outputMatthew Heon2020-09-25
| | | | | | | | This is very useful for debugging cgroups v2, especially on rootless - we need to ensure people are correctly using systemd cgroups in these cases. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Add Server header to API service responsesJhon Honce2020-09-25
| | | | | | Aids in reading logs of different services Signed-off-by: Jhon Honce <jhonce@redhat.com>
* podman save: fix redirect of multi-imagesValentin Rothberg2020-09-25
| | | | | | | | Fix a bug when saving multi-image archives where the progress bars from copying images was accidentally written to the archive and hence corrupted it. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #7732 from mheon/bump_211devOpenShift Merge Robot2020-09-24
|\ | | | | Bump to v2.1.1-dev
| * Bump to v2.1.1-devMatthew Heon2020-09-23
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #7737 from lsm5/v2.1OpenShift Merge Robot2020-09-23
|\| | | | | [v2.1] fix build with varlink
| * fix build with varlinkLokesh Mandvekar2020-09-22
|/ | | | | | | | | also add a cirrus task for building binaries with varlink. From: Chris Evich <cevich@redhat.com> Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> (cherry picked from commit 16763c3df0eaf3b6e5b7883c60b59f051f811cda) Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* Bump to v2.1.0v2.1.0Matthew Heon2020-09-22
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #7725 from mheon/release_notes_210_finalOpenShift Merge Robot2020-09-22
|\ | | | | [CI:DOCS] Update release notes for v2.1.0 Final Release
| * Update release notes for v2.1.0 Final ReleaseMatthew Heon2020-09-22
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #7720 from vrothberg/campfireOpenShift Merge Robot2020-09-22
|\ | | | | update stale bot
| * update stale botValentin Rothberg2020-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the GitHub action to mark issues and PRs as stale. There are a couple of useful features, most importantly, the bot will remove the stale label from issues as soon as there's either an activity or a comment. This reduces some manual overhead: the stale bot will only drop a comment on issues and PRs that are not marked as stale. Hence, as we appreciated the reminders, we had to manually remove the label which should now turn into campfire tales. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #7717 from rhatdan/attachOpenShift Merge Robot2020-09-22
|\ \ | | | | | | Fix up attach tests for podman remote
| * | Fix up attach tests for podman remoteDaniel J Walsh2020-09-22
| |/ | | | | | | | | | | | | | | | | | | | | When we execute podman-remote attach, we were not checking if the container was in the correct state, this is leading to timeouts and we had turned off remote testing. Also added an IfRemote() function so we can turn on more tests when using the "-l" flag for local, but use container name for remote. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #7691 from rhatdan/mountOpenShift Merge Robot2020-09-22
|\ \ | |/ |/| Fix podman image unmount to only report images unmounted
| * Fix podman image unmount to only report images unmountedDaniel J Walsh2020-09-21
| | | | | | | | | | | | | | Currently `podman image unmount` report every image that is mounted when it unmounts them. We should only report unmounted actually mounted images. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #7715 from TomSweeneyRedHat/dev/tsweeney/contribOpenShift Merge Robot2020-09-21
|\ \ | | | | | | [CI:DOCS] Add 'In Progress' note to CONTRIBUTING.md
| * | [CI:DOCS] Add 'In Progress' note to CONTRIBUTING.mdTomSweeneyRedHat2020-09-21
|/ / | | | | | | | | | | | | | | Update the CONTRIBUTING.md to explain the use of the new "In Progress" label in the Podman repository. This emulates the verbiage in Buildah. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #7695 from jwhonce/issues/7686OpenShift Merge Robot2020-09-21
|\ \ | | | | | | Restore 'id' stanza in pull results
| * | Restore 'id' stanza in pull resultsJhon Honce2020-09-21
| |/ | | | | | | | | | | | | | | | | | | | | | | | | id is the last image id from the set of id's returned via the images stanza. id may be deprecated in a future version of the API Created test_rest_v2_0_0.py to reflect the bump in the API Version. Fixes #7686 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #7698 from AkihiroSuda/rootless-cni-deflake-lo-upOpenShift Merge Robot2020-09-21
|\ \ | |/ |/| rootless-cni-infra: fix flakiness during bringing up lo interface
| * libpod: bumps up rootless-cni-infra to 2Akihiro Suda2020-09-21
| | | | | | | | Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
| * rootless-cni-infra: fix flakiness during bringing up lo interfaceAkihiro Suda2020-09-20
| | | | | | | | | | | | | | | | Fix #7618 This bumps up ROOTLESS_CNI_INFRA_VERSION to 2 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
* | Merge pull request #7688 from vrothberg/fix-7521OpenShift Merge Robot2020-09-21
|\ \ | | | | | | remote stats fixes
| * | stats: log errors instead of sending 500Valentin Rothberg2020-09-21
| | | | | | | | | | | | | | | | | | As 200 is already out the door, we cannot send 500s anymore. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | stats: detect closed client connectionValentin Rothberg2020-09-18
| | | | | | | | | | | | | | | | | | | | | Detect closed client connections and stop streaming. Fixes: #7521 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | stats endpoint: write OK header onceValentin Rothberg2020-09-18
| | | | | | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #7697 from rhatdan/ignoreOpenShift Merge Robot2020-09-21
|\ \ \ | | | | | | | | Fix handling of podman-remote stop --ignore
| * | | Fix handling of podman-remote stop --ignoreDaniel J Walsh2020-09-19
| | | | | | | | | | | | | | | | | | | | | | | | This patch simplifies the hanlding of rhe --ignore flag, for podman stop, rm Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #7696 from jwhonce/wip/versionOpenShift Merge Robot2020-09-21
|\ \ \ \ | | | | | | | | | | Refactor version handling in cmd tree
| * | | | Refactor version handling in cmd treeJhon Honce2020-09-18
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | * Move from simple string to semver objects * Change client API Version from '1' to 2.0.0 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #7665 from ↵OpenShift Merge Robot2020-09-21
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.10.1 Bump github.com/rootless-containers/rootlesskit from 0.10.0 to 0.10.1
| * | | | Bump github.com/rootless-containers/rootlesskit from 0.10.0 to 0.10.1Daniel J Walsh2020-09-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 0.10.0 to 0.10.1. - [Release notes](https://github.com/rootless-containers/rootlesskit/releases) - [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.10.0...v0.10.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #7702 from Luap99/fix#7701OpenShift Merge Robot2020-09-21
|\ \ \ \ \ | |_|_|_|/ |/| | | | Fix incorrect parsing of create/run --volumes-from
| * | | | Fix incorrect parsing of create/run --volumes-fromPaul Holzinger2020-09-20
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a bunch of tests to ensure that --volumes-from works as expected. Also align the podman create and run man page. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #7674 from xordspar0/bats-install-rootOpenShift Merge Robot2020-09-19
|\ \ \ \ | | | | | | | | | | Install bats as root
| * | | | Install bats as rootJordan Christiansen2020-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Installing bats to /usr/local requires root privileges. Without this, `make install.tools` fails. However, if I do `sudo make install.tools`, then all of the other dependencies and git clones in the current directory end up owned by root. This limits root privileges to the part that needs it. Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
* | | | | Merge pull request #7629 from cevich/fix_dbuildOpenShift Merge Robot2020-09-19
|\ \ \ \ \ | | | | | | | | | | | | Makefile: Remove broken targets
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2025-02-05 13:59:51 +0000