summaryrefslogtreecommitdiff
path: root/cmd/podman
Commit message (Collapse)AuthorAge
* Fix error code retrieval for podman start --attachMatthew Heon2019-02-14
| | | | | | | | | | | | When we start a container with 'podman run' and it exits and is removed before we get the code, we grab its exit code from the Conmon exit file. Podman start --attach wants to do the same, but was missing the logic. Fix that here. Also, remove some --rm handling leftover in start. Don't need it anymore, we have the cleanup process now. Signed-off-by: Matthew Heon <mheon@redhat.com>
* Enable --rm with --detachMatthew Heon2019-02-14
| | | | | | | We can now safely remove detached containers as --rm handling has moved into the cleanup process. Signed-off-by: Matthew Heon <mheon@redhat.com>
* Fix volume handling in podmanDaniel J Walsh2019-02-14
| | | | | | | | | | | | | | | | | | iFix builtin volumes to work with podman volume Currently builtin volumes are not recored in podman volumes when they are created automatically. This patch fixes this. Remove container volumes when requested Currently the --volume option on podman remove does nothing. This will implement the changes needed to remove the volumes if the user requests it. When removing a volume make sure that no container uses the volume. Signed-off-by: Daniel J Walsh dwalsh@redhat.com Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* add build to main and as subcommand to imagebaude2019-02-14
| | | | | | | | add build as a local and remote-client command in the main podman menu. also ensure it is added to the image subcommands as well. Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #2321 from baude/remotebuildOpenShift Merge Robot2019-02-14
|\ | | | | podman-remote build
| * podman-remote buildbaude2019-02-13
| | | | | | | | | | | | | | add the ability to build images using files local to the remote-client but over a varlink interface to a "remote" server. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2319 from mheon/unconditional_cleanupOpenShift Merge Robot2019-02-13
|\ \ | | | | | | Fix manual detach from containers to not wait for exit
| * | Address review comments on #2319Matthew Heon2019-02-12
| | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Retain a copy of container exit file on cleanupMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When cleaning up containers, we presently remove the exit file created by Conmon, to ensure that if we restart the container, we won't have conflicts when Conmon tries writing a new exit file. Unfortunately, we need to retain that exit file (at least until we get a workable events system), so we can read it in cases where the container has been removed before 'podman run' can read its exit code. So instead of removing it, rename it, so there's no conflict with Conmon, and we can still read it later. Fixes: #1640 Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Fix manual detach from containers to not wait for exitMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At present, when manually detaching from an attached container (using the detach hotkeys, default C-p C-q), Podman will still wait for the container to exit to obtain its exit code (so we can set Podman's exit code to match). This is correct in the case where attach finished because the container exited, but very wrong for the manual detach case. As a result of this, we can no longer guarantee that the cleanup and --rm functions will fire at the end of 'podman run' - we may be exiting before we get that far. Cleanup is easy enough - we swap to unconditionally using the cleanup processes we've used for detached and rootless containers all along. To duplicate --rm we need to also teach 'podman cleanup' to optionally remove containers instead of cleaning them up. (There is an argument for just using 'podman rm' instead of 'podman cleanup --rm', but cleanup does have different semantics given that we only ever expect it to run when the container has just exited. I think it might be useful to keep the two separate for things like 'podman events'...) Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #2331 from baude/issue846OpenShift Merge Robot2019-02-13
|\ \ \ | |_|/ |/| | show container ports of network namespace
| * | show container ports of network namespacebaude2019-02-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in cases where a container is part of a network namespace, we should show the network namespace's ports when dealing with ports. this impacts ps, kube, and port. fixes: #846 Signed-off-by: baude <bbaude@redhat.com>
* | | podman-remote volume inspect|lsbaude2019-02-13
|/ / | | | | | | | | | | | | add the ability to list and inspect volumes using the remote client and varlink Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2327 from baude/issue2175OpenShift Merge Robot2019-02-13
|\ \ | | | | | | Parse fq name correctly for images
| * | Parse fq name correctly for imagesbaude2019-02-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When parsing a string name for repo and tag (for images output), we should be using parsenormalizedname and reference.Canonical to get the proper output. Resolves: #2175 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2322 from baude/remotepushOpenShift Merge Robot2019-02-13
|\ \ \ | | | | | | | | podman-remote push
| * | | podman-remote pushbaude2019-02-13
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | enable podman-remote push so that users can push images from a remote client. change in push API to deal with the need to see output over the varlink connection. Signed-off-by: baude <bbaude@redhat.com>
* / / Only build varlink when buildtag is availablebaude2019-02-12
|/ / | | | | | | | | | | | | | | Correct mistake that broke things like dlv where we should only try to add the varlink command to podman when the 'varlink' build tag is present. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2264 from larskarlitski/varlink-apiOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| Make varlink API more idiomatic
| * varlink: Rename `SearchImage` to `SearchImages`Lars Karlitski2019-02-12
| | | | | | | | | | | | | | Also rename image result struct to `ImageSearchResult` and make `limit` parameter optional. Signed-off-by: Lars Karlitski <lars@karlitski.net>
| * varlink: Rename `ContainerInList` to `Container`Lars Karlitski2019-02-12
| | | | | | | | | | | | Container more clearly describes what the type represents. Signed-off-by: Lars Karlitski <lars@karlitski.net>
| * varlink: Rename `ImageInList` to `Image`Lars Karlitski2019-02-12
| | | | | | | | | | | | | | | | | | Image more clearly describes what the type represents. Also, only include the image name in the `ImageNotFound` error returned by `GetImage()`, not the full error message. Signed-off-by: Lars Karlitski <lars@karlitski.net>
| * varlink: Simplify GetVersion() callLars Karlitski2019-02-12
| | | | | | | | | | | | | | Not having the `Version` wrapper type makes it easier for clients to work with the returned data. Signed-off-by: Lars Karlitski <lars@karlitski.net>
| * varlink: Return all times in RFC 3339 formatLars Karlitski2019-02-12
| | | | | | | | | | | | | | | | | | This is more consistent and eaiser to parse than the format that golang's time.String() returns. Fixes #2260 Signed-off-by: Lars Karlitski <lars@karlitski.net>
| * varlink: Remove the Ping() methodLars Karlitski2019-02-12
| | | | | | | | | | | | | | | | There are other ways for developers to "ensure their varlink setup is working", for example by calling `GetVersion()` or any call on the org.varlink.service interface. Signed-off-by: Lars Karlitski <lars@karlitski.net>
| * podman: Show error when creating varlink listener failedLars Karlitski2019-02-12
| | | | | | | | Signed-off-by: Lars Karlitski <lars@karlitski.net>
| * varlink: Remove `NotImplemented` typeLars Karlitski2019-02-12
| | | | | | | | | | | | | | | | Remove the `NotImplemented` type and comment out the methods that use it. This way we can keep track of the methods that still need to be implemented without committing them to stable API. Signed-off-by: Lars Karlitski <lars@karlitski.net>
* | Merge pull request #2309 from rhatdan/helpOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| Don't show global flags except for podman command
| * Don't show global flags except for podman commandDaniel J Walsh2019-02-12
| | | | | | | | | | | | | | | | | | Subcommands should not be showing the global flags. This causes the important information to scroll off the screen. Also fixed a typo on runCommmand (Too many 'm's) Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2315 from baude/remotevolumermOpenShift Merge Robot2019-02-12
|\ \ | | | | | | podman-remote volume rm
| * | podman-remote volume rmbaude2019-02-11
| |/ | | | | | | | | | | | | add the ability to remove/delete volumes with the podman remote client. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2300 from baude/cleanupurfaveOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| Remove urfave/cli from libpod
| * Remove urfave/cli from libpodbaude2019-02-11
| | | | | | | | | | | | | | This is the final cleanup to remove urfave/sli from libpod. Removed old, disabled tests that have not been run in over a year. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2313 from baude/remotevolumecreateOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| podman-remote volume create
| * podman-remote volume createbaude2019-02-11
| | | | | | | | | | | | create a volume using the remote client over varlink Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2307 from baude/repruneremoteOpenShift Merge Robot2019-02-11
|\ \ | | | | | | Separate remote and local commands
| * | Separate remote and local commandsbaude2019-02-11
| | | | | | | | | | | | | | | | | | | | | | | | In the previous CLI, we had an accurate depiction of commands available for the remote client and those available for the local client. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2281 from rhatdan/deleteContainerOpenShift Merge Robot2019-02-11
|\ \ \ | | | | | | | | Remove container from storage on --force
| * | | Remove container from storage on --forceDaniel J Walsh2019-02-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we can get into a state where a container exists in storage but does not exist in libpod. If the user forces a removal of this container, then we should remove it from storage even if the container is owned by another tool. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #2306 from baude/podstatsgotemplateOpenShift Merge Robot2019-02-11
|\ \ \ \ | |_|_|/ |/| | | Podman pod stats -- fix GO template output
| * | | Podman pod stats -- fix GO template outputbaude2019-02-10
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Go templates were not being processed or printed correctly for podman pod stats. Added the ability to do templates as well as honor the table identifier. Fixes #2258 Signed-off-by: baude <bbaude@redhat.com>
* / | pod: drop not valid check for rootlessGiuseppe Scrivano2019-02-11
|/ / | | | | | | | | | | | | rootless networks support port binding if the underlying slirp4netns is new enough. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #2296 from baude/psShowMountOpenShift Merge Robot2019-02-09
|\ \ | |/ |/| Add volume mounts to PS output
| * Add volume mounts to PS outputbaude2019-02-08
| | | | | | | | | | | | | | | | | | When listing containers, you should be able to list the mounts with something like --format "table{{".Mounts}}". Resolves: #2238 Signed-off-by: baude <bbaude@redhat.com>
* | do not crash when displaying dangling imagesbaude2019-02-08
|/ | | | | | | | | | | the previous method required a populated image template to create the headers and always selected the first image in the slice. when dealing with dangling images, they are not populated and therefore would panic. Resolves: #2246 Signed-off-by: baude <bbaude@redhat.com>
* Migrate to cobra CLIbaude2019-02-08
| | | | | | | | We intend to migrate to the cobra cli from urfave/cli because the project is more well maintained. There are also some technical reasons as well which extend into our remote client work. Signed-off-by: baude <bbaude@redhat.com>
* Remove some dead type declarationsNalin Dahyabhai2019-02-07
| | | | Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* Merge pull request #2252 from rhatdan/systemOpenShift Merge Robot2019-02-06
|\ | | | | Add podman system prune and info commands
| * Capatilize all usage and descriptionsDaniel J Walsh2019-02-05
| | | | | | | | | | | | | | | | | | We have no consistancy in out option usages and descritions on whether or not the first letter should be capatalized. This patch forces them all to be capatilized. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Add podman system prune and info commandsDaniel J Walsh2019-02-05
| | | | | | | | | | | | | | | | | | We are missing the equivalence of the docker system commands This patch set adds `podman system prune` and `podman system info` Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-07 20:36:32 +0000