summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Migrate unit tests from cmd/podman into pkg/specMatthew Heon2019-05-01
| | | | | | | | | | Several changes made in the interface of pkg/spec make interacting with it without a runtime difficult to impossible, so move the existing limited testing from cmd/podman (which mostly tested pkg/spec) into pkg/spec itself where we can call individual functions that don't break things. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Migrate to unified volume handling codeMatthew Heon2019-05-01
| | | | | | | | | | | | | Unify handling for the --volume, --mount, --volumes-from, --tmpfs and --init flags into a single file and set of functions. This will greatly improve readability and maintainability. Further, properly handle superceding and conflicting mounts. Our current patchwork has serious issues when mounts conflict, or when a mount from --volumes-from or an image volume should be overwritten by a user volume or named volume. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Always pass pod into MakeContainerConfigMatthew Heon2019-05-01
| | | | | | | | Play kube was passing the pod, but CreateConfig was not. Unify it so they both do, so we can remove some unnecessary duplicate lookup code. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Remove non-config fields from CreateConfigMatthew Heon2019-05-01
| | | | | | | | | The goal here is to keep only the configuration directly used to build the container in CreateConfig, and scrub temporary state and helpers that we need to generate. We'll keep those internally in MakeContainerConfig. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Add a new function for converting a CreateConfigMatthew Heon2019-05-01
| | | | | | | | | | | Right now, there are two major API calls necessary to turn a filled-in CreateConfig into the options and OCI spec necessary to make a libpod Container. I'm intending on refactoring both of these extensively to unify a few things, so make a common frontend to both that will prevent API changes from leaking out of the package. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* auto pass http_proxy into containerJames Cassell2019-04-30
| | | | Signed-off-by: James Cassell <code@james.cassell.me>
* Refactor container cleanup to use latest functionsJhon Honce2019-04-30
| | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #2982 from baude/remotecontainerpruneOpenShift Merge Robot2019-04-30
|\ | | | | podman-remote prune containers
| * podman-remote prune containersbaude2019-04-26
| | | | | | | | | | | | | | enable the ability to prune containers from the remote-command. this also includes the system prune command. Signed-off-by: baude <bbaude@redhat.com>
* | podman-remote stopbaude2019-04-29
| | | | | | | | | | | | | | add stop to the container subcommands for the remote client. the stop function is already done. this is a graphical change only. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #3015 from QiWang19/credsHOpenShift Merge Robot2019-04-29
|\ \ | | | | | | fix login supports credHelpers config
| * | fix login supports credHelpers configQi Wang2019-04-25
| | | | | | | | | | | | | | | | | | Skip the error if login can't find credentials in credHelpers with credHelpers configed in auth.json and podman login will store the credentials in credHelpers later. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Merge pull request #3025 from rhatdan/read-onlyOpenShift Merge Robot2019-04-29
|\ \ \ | | | | | | | | Add --read-only-tmpfs options
| * | | Add --read-only-tmpfs optionsDaniel J Walsh2019-04-26
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | The --read-only-tmpfs option caused podman to mount tmpfs on /run, /tmp, /var/tmp if the container is running int read-only mode. The default is true, so you would need to execute a command like --read-only --read-only-tmpfs=false to turn off this behaviour. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | runtime: pass down the contextGiuseppe Scrivano2019-04-26
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | system: add new subcommand "migrate"Giuseppe Scrivano2019-04-26
|/ / | | | | | | | | | | | | | | | | | | | | it is useful to migrate existing containers to a new version of podman. Currently, it is needed to migrate rootless containers that were created with podman <= 1.2 to a newer version which requires all containers to be running in the same user namespace. Closes: https://github.com/containers/libpod/issues/2935 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | enable podman remote topbaude2019-04-25
| | | | | | | | | | | | | | add the ability for the remote client to display a container's running processes. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2850 from baude/eventsjournaldOpenShift Merge Robot2019-04-25
|\ \ | | | | | | journald event logging
| * | journald event loggingbaude2019-04-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | add the ability for podman to read and write events to journald instead of just a logfile. This can be controlled in libpod.conf with the `events_logger` attribute of `journald` or `file`. The default will be set to `journald`. Signed-off-by: baude <bbaude@redhat.com>
* | | images: add context to GetParent/IsParent/Remove/Prune...Nalin Dahyabhai2019-04-25
| |/ |/| | | | | | | | | | | Add a context.Context parameter to Image.GetParent(), Image.IsParent(), Image.GetChildren(), Image.Remove(), and Runtime.PruneImages(). Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | Merge pull request #2973 from baude/remoterestartOpenShift Merge Robot2019-04-24
|\ \ | |/ |/| podman remote-client restart containers
| * podman remote-client restart containersbaude2019-04-24
| | | | | | | | | | | | add the ability to restart containers with the remote-client Signed-off-by: baude <bbaude@redhat.com>
* | pull: special case all-tags semanticsValentin Rothberg2019-04-24
|/ | | | | | | | | | | | | | | | | | Supporting the all-tags semantics added some non-trivial code to the pull command which does not make use of `registries.conf` and introduced some regressions such as not adhering to the configured search registries. Speacial case the all-tags flags to let existing users of all-tags continue working while others can work again. This implies that the all-tags pull does not adhere to configured search registries while the default (non-all-tags) pull does. Note that this is a purely symptomaic fix. A final solution should include Buildah and the c/image library to avoid redundant and error-prone code across the projects. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1701922 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #2933 from haircommander/kube-cleanOpenShift Merge Robot2019-04-22
|\ | | | | Clean up after play kube failure
| * Add header to play kube outputPeter Hunt2019-04-18
| | | | | | | | Signed-off-by: Peter Hunt <pehunt@redhat.com>
| * Clean up after play kube failurePeter Hunt2019-04-18
| | | | | | | | | | | | | | Before, we would half create a pod in play kube and error out if we fail. Rather, let's clean up after our failure so the user doesn't have to delete the pod themselves. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | Refactor of 'podman prune' to better support remoteJhon Honce2019-04-18
| | | | | | | | | | | | | | | | * Push iterations into the service not the client * Add e2e tests * Refactor to use new frameworks Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #2948 from baude/remotepauseOpenShift Merge Robot2019-04-18
|\ \ | | | | | | podman-remote pause|unpause
| * | podman-remote pause|unpausebaude2019-04-18
| | | | | | | | | | | | | | | | | | | | | | | | Add the ability to pause and unpause containers with the remote client. Also turned on the pause tests! Signed-off-by: baude <bbaude@redhat.com>
* | | Fix podman command --change CMDDaniel J Walsh2019-04-17
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently in Docker if you commit with --change 'CMD a b c' The command that gets added is [/bin/sh -c "a b c"] If you commit --change 'CMD ["a","b","c"]' You get [a b c] This patch set makes podman match this behaviour. Similar change required for Entrypoint. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2917 from baude/remotestartOpenShift Merge Robot2019-04-17
|\ \ | | | | | | podman-remote start
| * | podman-remote startbaude2019-04-17
| |/ | | | | | | | | | | | | enable the ability to start containers from the remote-client. also, enable start integration tests for remote testing. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2936 from haircommander/pod-pruneOpenShift Merge Robot2019-04-17
|\ \ | |/ |/| Add podman pod prune
| * Added remote pod prunePeter Hunt2019-04-16
| | | | | | | | Signed-off-by: Peter Hunt <pehunt@redhat.com>
| * Add podman pod prunePeter Hunt2019-04-16
| | | | | | | | | | | | | | podman system prune would leave pods be, and not prune them if they were stopped. Fix this by adding a `podman pod prune` command that prunes stopped pods similarly to containers. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | Merge pull request #2949 from baude/remotecontainercommandsOpenShift Merge Robot2019-04-16
|\ \ | |/ |/| podman-remote container commands
| * podman-remote container commandsbaude2019-04-16
| | | | | | | | | | | | | | Several container commands were ported to the remote client but had not been updated on the container submenu yet. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2934 from haircommander/kube-fileOpenShift Merge Robot2019-04-16
|\ \ | |/ |/| Add File mounts to play kube
| * Add File mounts to play kubePeter Hunt2019-04-15
| | | | | | | | | | | | Both File and FileOrCreate options are supported. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | Merge pull request #2946 from baude/segsOpenShift Merge Robot2019-04-16
|\ \ | | | | | | Fix segfaults attribute to missing options
| * | Fix segfaults attribute to missing optionsbaude2019-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | In cases where the remote client culls options to a command, we need to be sure that the lookup for that flag does not result in a nil pointer. To do so, we add a Remote attribute to the podman struct and then cli helper funcs are now aware they are remote. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2944 from mheon/fix_renumberOpenShift Merge Robot2019-04-15
|\ \ \ | | | | | | | | Call the runtime with WithRenumber() when asked by 'system renumber' command
| * | | Call the runtime with WithRenumber() when askedMatthew Heon2019-04-15
| | |/ | |/| | | | | | | | | | | | | | | | We must have lost this at some point, rendering system renumber useless. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | cmd, pkg: drop commented codeGiuseppe Scrivano2019-04-15
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | pod: drop dead codeGiuseppe Scrivano2019-04-15
| | | | | | | | | | | | | | | | | | | | | we always create a user namespace now, so no need to check if we are running as non root. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | rootless, mount: not create namespaceGiuseppe Scrivano2019-04-15
| |/ |/| | | | | | | | | | | we need to check if we are able to mount the container as part of the mount command itself. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Incorporate image and default environment variables in play kubePeter Hunt2019-04-14
|/ | | | | | Also put Environment variable parsing from image data into a helper function Signed-off-by: Peter Hunt <pehunt@redhat.com>
* Merge pull request #2830 from baude/remotecheckpointOpenShift Merge Robot2019-04-13
|\ | | | | remote-client checkpoint/restore
| * remote-client checkpoint/restorebaude2019-04-11
| | | | | | | | | | | | | | add the ability for the remote client to be able to checkpoint and restore containers. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2911 from giuseppe/fix-pull-errorsOpenShift Merge Robot2019-04-12
|\ \ | | | | | | pull: fix a couple of issues