summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Combine GlobalFlags and EngineFlags into EngineOptionsJhon Honce2020-03-24
| | | | | | | * EngineOptions obtained in command via `opt, err := registry.Options(cmd)` Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #5596 from jwhonce/wip/historyOpenShift Merge Robot2020-03-24
|\ | | | | Complete podmanV2 history command
| * Complete podmanV2 history commandJhon Honce2020-03-24
| | | | | | | | | | | | * All format options now implemented Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | podmanv2 exit codeBrent Baude2020-03-24
|/ | | | | | add ability to set and get exit code. Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #5581 from baude/v2containersOpenShift Merge Robot2020-03-24
|\ | | | | podmanv2 add core container commands
| * podmanv2 add core container commandsBrent Baude2020-03-22
| | | | | | | | | | | | add core container commands for podmanv2: kill, pause, restart, rm, stop, unpause Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5560 from QiWang19/remote_cedsOpenShift Merge Robot2020-03-23
|\ \ | | | | | | Use creds form PullImage remote
| * | Use creds form PullImage remoteQi Wang2020-03-19
| | | | | | | | | | | | | | | | | | | | | fix #5511 Adds creds argument to PullImage API and Enables podman-remote to pull image with --creds Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Merge pull request #5582 from kunalkushwaha/bugfix-5001Daniel J Walsh2020-03-22
|\ \ \ | |_|/ |/| | Improved readability in image json output
| * | Improved readability in image json outputKunal Kushwaha2020-03-22
| | | | | | | | | | | | | | | | | | | | | Changes made in json output to improve readability of podman images output. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>
* | | Merge pull request #5579 from mtrmac/macOS-unit-testsOpenShift Merge Robot2020-03-21
|\ \ \ | | | | | | | | Make macOS unit tests runnable
| * | | Add stubs for cmd/podman in non-Linux local modeMiloslav Trmač2020-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is _only_ to be able able to run unit tests. I didn't even TRY running the result, I'm scared of what it would do. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | | Make cmd/podman/shared.GenerateCommand tests Linux-onlyMiloslav Trmač2020-03-21
| | | | | | | | | | | | | | | | | | | | | | | | They rely on existence of /proc/self/exe . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* | | | Merge pull request #5577 from baude/v2volumecreateOpenShift Merge Robot2020-03-21
|\ \ \ \ | | | | | | | | | | podmanv2 volume create
| * | | | podmanv2 volume createBrent Baude2020-03-20
| |/ / / | | | | | | | | | | | | | | | | | | | | add volume create Signed-off-by: Brent Baude <bbaude@redhat.com>
* / / / podmanv2 pod existsBrent Baude2020-03-20
|/ / / | | | | | | | | | | | | | | | add pod exists for podman v2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | podmanv2 enable remote waitBrent Baude2020-03-20
| | | | | | | | | | | | | | | | | | enable remote container wait with condition Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | use boolreport for containerexists responseBrent Baude2020-03-20
| | | | | | | | | | | | | | | | | | in the case of exists, use a boolreport structure so that responses can be consistent pointer and error Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | podmanv2 container exists|waitBrent Baude2020-03-20
| | | | | | | | | | | | | | | | | | enable container exists and wait for podmanv2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5539 from sujil02/issue-5461OpenShift Merge Robot2020-03-20
|\ \ \ | | | | | | | | Implemented --iidfile for podman commit
| * | | Implemented --iidfile for podman commitSujil022020-03-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Added flag to Write the image ID to the file with podman commit command. Fix to issue #5461 Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | Add guildline for writing podman V2 CLI commandsJhon Honce2020-03-19
| | | | | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | [CI:DOCS]remove podmanv2 binaryBrent Baude2020-03-19
| | | | | | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5546 from jwhonce/wip/entitiesOpenShift Merge Robot2020-03-19
|\ \ \ \ | | | | | | | | | | V2 podman command
| * | | | V2 podman commandJhon Honce2020-03-18
| |/ / / | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #5445 from sujil02/podFilter-newOpenShift Merge Robot2020-03-19
|\ \ \ \ | |/ / / |/| | | Filter pods through pod list api
| * | | Filter pods through pod list apiSujil022020-03-17
| |/ / | | | | | | | | | | | | | | | | | | Refactored current filter pods flow through the shared pod functions so filter pod functionalities can be shared between api and cmd. Signed-off-by: Sujil02 <sushah@redhat.com>
* / / auto updatesValentin Rothberg2020-03-17
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support to auto-update containers running in systemd units as generated with `podman generate systemd --new`. `podman auto-update` looks up containers with a specified "io.containers.autoupdate" label (i.e., the auto-update policy). If the label is present and set to "image", Podman reaches out to the corresponding registry to check if the image has been updated. We consider an image to be updated if the digest in the local storage is different than the one of the remote image. If an image must be updated, Podman pulls it down and restarts the container. Note that the restarting sequence relies on systemd. At container-creation time, Podman looks up the "PODMAN_SYSTEMD_UNIT" environment variables and stores it verbatim in the container's label. This variable is now set by all systemd units generated by `podman-generate-systemd` and is set to `%n` (i.e., the name of systemd unit starting the container). This data is then being used in the auto-update sequence to instruct systemd (via DBUS) to restart the unit and hence to restart the container. Note that this implementation of auto-updates relies on systemd and requires a fully-qualified image reference to be used to create the container. This enforcement is necessary to know which image to actually check and pull. If we used an image ID, we would not know which image to check/pull anymore. Fixes: #3575 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | add os|arch attributes when buildingBrent Baude2020-03-15
| | | | | | | | | | | | | | | | when building images, we can now add the os and arch of the image using overrides from the commandline. the commandline options set sane defaults so we use those as well. Fixes: #5503 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | remove imagefilter for varlink remote clientBrent Baude2020-03-12
| | | | | | | | | | | | the api for getting images changed to use filters but back level podman versions cannot handle it. so temporarily disabling the filtering for remote clients until the restful approach can be used. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5469 from giuseppe/no-size-create-containerOpenShift Merge Robot2020-03-12
|\ \ | | | | | | create: do not calculate image size
| * | create: do not calculate image sizeGiuseppe Scrivano2020-03-12
| | | | | | | | | | | | | | | | | | | | | calculating the image size can be an expensive operation. Avoid doing it when creating a new container since the size is not needed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | man page cross-reference fixes: part 2Ed Santiago2020-03-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The other direction: fix or clean up elements documented in man pages but which did/do not exist in actual podman: * runlabel: add missing "-n" alias for --name And, remove man page entries for nonexistent options: * podman commit: --iidfile * podman container runlabel: --rootfs, --storage * podman create: --cpu-count There are two problems I don't know how to deal with. Both are related to main_local.go:rootCmd.PersistentFlags() : 1) podman-build.1.md documents --cni-config-dir and --runtime options, but these are not actually options under podman build; they are global options. The documentation in this man page differs from that under podman-build. 2) podman ps implements a binary --namespace option, but this option does not (cannot?) appear in --help because there's a global --namespace string option and Cobra somehow gets confused about this. Do we really intend for global options to be parsed on the right-hand side of subcommands? This strikes me as unintuitive and potentially confusing, although the fact that it has taken me this long to discover it suggests that it's not _that_ confusing. Suggestions welcome. I can file issues for 1/2 above, or simply teach my script to special-case ignore them. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | man pages: fix inconsistenciesEd Santiago2020-03-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I wrote a script to cross-reference podman --help against man pages. It found a bunch of inconsistencies fix them: * options missing from man pages * options misspelled or misformatted in man pages (usually misplaced asterisks or missing dashes, but see --dns-opt) * one spurious comma in the actual source file --help This is a fix in which I iterate over 'podman CMD --help' and check for presence in man pages. The other way around (look for flags in man pages, check podman CMD --help) is probably impossible: there are too many special cases Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | hide --trace flagValentin Rothberg2020-03-10
| | | | | | | | | | | | | | | | | | The tracing flag is not really something users should worry about. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | podman --help: mention defaults of boolsValentin Rothberg2020-03-10
| |/ |/| | | | | | | | | | | | | | | While string variables are shown to expect a string argument, boolean variables are not. This easily tricks users into believing they are simple switches without arguments. Hence, explicitly mention the default to clarify it a bit more. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | use storage/pkg/homedirValentin Rothberg2020-03-09
| | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5412 from rhatdan/tmpdirOpenShift Merge Robot2020-03-08
|\ \ | | | | | | Allow users to set TMPDIR environment
| * | Allow users to set TMPDIR environmentDaniel J Walsh2020-03-06
| | | | | | | | | | | | | | | | | | | | | Some users have small /var/tmp directories and need to be able to specify a different location for temporary files, which includes more space. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Fix spelling mistakes in code found by codespellDaniel J Walsh2020-03-07
| | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | add default network for apiv2 createBrent Baude2020-03-06
|/ / | | | | | | | | | | | | | | | | | | | | | | | | during container creation, if no network is provided, we need to add a default value so the container can be later started. use apiv2 container creation for RunTopContainer instead of an exec to the system podman. RunTopContainer now also returns the container id and an error. added a libpod commit endpoint. also, changed the use of the connections and bindings slightly to make it more convenient to write tests. Fixes: 5366 Signed-off-by: Brent Baude <bbaude@redhat.com>
* / golangci: enable goimportsValentin Rothberg2020-03-05
|/ | | | | | Enable the goimports linter and fix reports. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #5389 from openSUSE/fix-image-sign-helpOpenShift Merge Robot2020-03-04
|\ | | | | Fix podman image sign help output
| * Fix podman image sign help outputSascha Grunert2020-03-04
| | | | | | | | | | | | | | Adjust the help output to mention `podman image sign` instead of just `podman sign`. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | Merge pull request #5381 from vrothberg/ENVFIXOpenShift Merge Robot2020-03-04
|\ \ | | | | | | env: set "container" to current binary
| * | env: don't set "container" envValentin Rothberg2020-03-04
| |/ | | | | | | | | | | | | | | Leave setting the "container" variable to consumers of pkg/env. Podman is now hard-setting it to "podman" while "libpod" will set it internally to "libpod" if it's unset. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #4772 from boaz0/closes_4628OpenShift Merge Robot2020-03-04
|\ \ | |/ |/| Add the rmi flag to podman-run to delete container image
| * Add the rmi flag to podman-run to delete container imageBoaz Shuster2020-03-03
| | | | | | | | | | | | | | | | | | | | The --rmi flag will delete the container image after its execution unless that image is already been used by another container(s). This is useful when one wants to execute a container once and remove any resources attached to it. Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
* | consolidate env handling into pkg/envValentin Rothberg2020-03-03
|/ | | | | | | | | Env-variable related code is scattered across several packages making it hard to maintain and extend. Consolidate the code into a new pkg/env package. Signed-off-by: Valentin Rothberg <rothberg@redhat.com> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #5244 from Akasurde/i4962OpenShift Merge Robot2020-02-28
|\ | | | | Add cmd flag to show container name in log
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-10-07 18:26:58 +0000