summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Merge pull request #6016 from giuseppe/fix-createOpenShift Merge Robot2020-05-01
|\ | | | | v2, podman: fix create and entrypoint tests
| * podman, start: propagate back the raw inputGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | this is necessary as we expect "podman start $ID_NAME" to print the same arguments the user passed in instead of the full ID. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * cmd, podman: do not override entrypoint if unsetGiuseppe Scrivano2020-04-30
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * cmd, podman: use String instead of variable+StringVarGiuseppe Scrivano2020-04-30
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * cmd, podman: handle --pod new:PODGiuseppe Scrivano2020-04-30
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * create: propagate override-arch and override-osGiuseppe Scrivano2020-04-30
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | fix commands without inputbaude2020-04-30
| | | | | | | | | | | | in cases where commands require input and we dont provide it, we often would segv. This can be attributed in many cases to the subcommand not picked up the cobra Args attribute or neither had them. Signed-off-by: baude <bbaude@redhat.com>
* | System tests: help messages: check required-argEd Santiago2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a usage message is of the form '... [flags] ARGNAME', where ARGNAME is all-caps and not in brackets, it must be a required argument. Try running podman subcommand without ARGNAME, and make sure that podman bails out with an informative message. (Since this message is freeform in each subcommand, not Cobra-generated, we have a lot of possible variations to check for). Fix podman login/logout Use messages to indicate that REGISTRY is now optional (as of #5233). This test has actually been in place for over a year but due to a typo on my part -- a missing space -- it was not being run. "For want of a space, much testing was lost". Signed-off-by: Ed Santiago <santiago@redhat.com>
* | V2 Commands that require ParentNS (rootful) are report errorJhon Honce2020-04-30
| | | | | | | | | | | | * Updated unmount to require ParentNS Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #6046 from jwhonce/jira/822OpenShift Merge Robot2020-04-30
|\ \ | | | | | | V2 enable ps tests
| * | V2 enable ps testsJhon Honce2020-04-29
| |/ | | | | | | | | | | | | | | * Combine cobra.Command helper functions into validate package from registry and common packages * Introduce ChoiceValue for flags Signed-off-by: Jhon Honce <jhonce@redhat.com>
* / testv2: enable attach testQi Wang2020-04-29
|/ | | | | | testv2: enable attach test Signed-off-by: Qi Wang <qiwan@redhat.com>
* Merge pull request #5956 from jwhonce/wip/versionOpenShift Merge Robot2020-04-29
|\ | | | | V2 restore podman -v command
| * V2 restore podman -v commandJhon Honce2020-04-29
| | | | | | | | | | | | | | * Removed extra spaces and improved error message * Updated tests to use gomega matchers Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | V2 Restore images list testsJhon Honce2020-04-29
|/ | | | | | | | * Fix history --quiet formatting * Fix image inspect --format=json * Fix image list --sort Signed-off-by: Jhon Honce <jhonce@redhat.com>
* enable search testsValentin Rothberg2020-04-29
| | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* pull/search options: tls verify -> skipValentin Rothberg2020-04-29
| | | | | | | | | Change the logic in the options from tls-verify to skipping verification. It require a constant brain yoga to translate from doing verification (CLI logic) to skipping it (c/image logic). As the code is using c/image, let's make it consistent. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* push: fix --tls-verifyValentin Rothberg2020-04-29
| | | | | | | | Fix --tls-verify parsing and make the associated options reflect the correct logic. Other commands are affected as well but will be fixed later. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* push: simplify cmdValentin Rothberg2020-04-29
| | | | | | The indirection via a 2nd variable isn't needed. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* push: fix push with one argumentValentin Rothberg2020-04-29
| | | | | | | When doing a `podman push $IMG`, $IMG acts as the source and the destination. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6022 from vrothberg/enable-inspect-testsOpenShift Merge Robot2020-04-29
|\ | | | | enable inspect tests
| * enable inspect testsValentin Rothberg2020-04-29
| | | | | | | | | | | | | | | | | | | | A surprisingly big change. A core problem was that `podman inspect` allows for passing containers AND images with the default `--type=all`. This only worked partially as the data was processed in isolation which caused various issues (e.g., two separate outputs instead of one) but it also caused issues regarding error handling. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | generate systemdValentin Rothberg2020-04-29
|/ | | | | | | Implement `podman generate systemd` for Podman v2 and enable associated tests. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6026 from baude/v2forcesystemtestsOpenShift Merge Robot2020-04-28
|\ | | | | system tests must pass
| * system tests must passBrent Baude2020-04-28
| | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5991 from sujil02/pod-rm-testOpenShift Merge Robot2020-04-28
|\ \ | |/ |/| Fix typos in messages pod rm
| * Fix typos in rm messagesSujil022020-04-28
| | | | | | | | | | | | Fix typos in pod rm messages Signed-off-by: Sujil02 <sushah@redhat.com>
* | Merge pull request #6020 from giuseppe/fix-execOpenShift Merge Robot2020-04-28
|\ \ | | | | | | v2, podman: fix create tests
| * | specgen: remove dead codeGiuseppe Scrivano2020-04-28
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | cmd: set correct parent for container execGiuseppe Scrivano2020-04-28
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | enable volume integration testsBrent Baude2020-04-27
|/ / | | | | | | | | | | | | | | enabled integration tests for volumes. there are two exceptions that still need work because of something not yet implemented. also, add code to deal with the fact that containers conf appears to set a local volume driver where it used to be simply blank. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #6000 from mheon/volume_backend_flagsOpenShift Merge Robot2020-04-27
|\ \ | | | | | | Add support for volumes-from, image volumes, init
| * | Add support for volumes-from, image volumes, initMatthew Heon2020-04-27
| |/ | | | | | | | | | | | | | | | | | | | | This should complete Podmanv2's support for volume-related flags. Most code was sourced from the old pkg/spec implementation with modifications to account for the split between frontend flags (volume, mount, tmpfs) and the backend flags implemented here. Also enables tests for podman run with volumes Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5978 from rhatdan/portsOpenShift Merge Robot2020-04-27
|\ \ | | | | | | Make podman container list == podman ps
| * | Make podman container list == podman psDaniel J Walsh2020-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make podman create -p PUBLISHPorts work. This PR fixes ps_test.go Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6001 from baude/v2intloadOpenShift Merge Robot2020-04-27
|\ \ \ | | | | | | | | enable load integration tests
| * | | enable load integration testsBrent Baude2020-04-27
| |/ / | | | | | | | | | | | | | | | fix bug where multiple images can be loaded and have to be able to handle the return of multiple names Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5975 from giuseppe/fix-pause-testsOpenShift Merge Robot2020-04-27
|\ \ \ | |_|/ |/| | [v2] tests: fix pause tests
| * | cmd, ps: add .Status as synonym for .StateGiuseppe Scrivano2020-04-27
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5966 from vrothberg/v2-pod-statsOpenShift Merge Robot2020-04-27
|\ \ \ | |_|/ |/| | implement pod stats
| * | implement pod statsValentin Rothberg2020-04-27
| | | | | | | | | | | | | | | | | | | | | Implement pod stats for the local and remote client. Both code paths end up in infra/abi to allow for code share. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5994 from giuseppe/fix-healthchecksOpenShift Merge Robot2020-04-27
|\ \ \ | | | | | | | | v2, podman: fix healthchecks
| * | | podman: handle --no-healthcheckGiuseppe Scrivano2020-04-27
| | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | podman: special case health-cmd noneGiuseppe Scrivano2020-04-27
| |/ / | | | | | | | | | | | | | | | now we have to pass down this information to libpod Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5997 from giuseppe/fix-pod-createOpenShift Merge Robot2020-04-27
|\ \ \ | | | | | | | | v2, podman: fix a bunch of "podman pod *" tests
| * | | spec: propagate --no-hosts to specgenGiuseppe Scrivano2020-04-27
| | |/ | |/| | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5976 from QiWang19/manifest-add-osOpenShift Merge Robot2020-04-27
|\ \ \ | |/ / |/| | Add --os to manifest add
| * | Add --os to manifest addQi Wang2020-04-24
| | | | | | | | | | | | | | | | | | Add --os to manifest add for overriding the os field. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | enable run_restart integration testsBrent Baude2020-04-26
| |/ |/| | | | | | | | | also, correct arg processing mistake in start Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Enable pod ps integration testsBrent Baude2020-04-25
| | | | | | | | | | | | | | | | Enable integration tests for pod ps. In addition, fixed bug where output was still using slice go template routines and would fail when no infra container was present. Added integration test to prevent future regressions. Signed-off-by: Brent Baude <bbaude@redhat.com>