summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Merge pull request #5875 from rhatdan/networkOpenShift Merge Robot2020-04-21
|\ | | | | Cleanup network option parsing
| * Cleanup network option parsingDaniel J Walsh2020-04-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were not handling the parsing of --ip. This pr adds validation checks and now will support the flag. Move validation to the actual parsing of the network flags. We should only parse the dns flags if the user changed them. We don't want to pass default options if set in containers.conf to the server. Potential for duplicating defaults. Add support for --dns-opt flag passing Begin handling of --network flag, although we don't have a way right now to translate a string into a specgen.Namespace. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | podman rmi: refactor logicValentin Rothberg2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While this commit was initially meant to fix #5847, it has turned into a bigger refactoring which I did not manage to break into smaller pieces: * Fix #5847 by refactoring the image-removal logic. * Make the api handler for image-removal use the ABI code. This way, both (i.e., ABI and Tunnel) end up using the same code. Achieving this code share required to move some code around to prevent circular dependencies. * Everything in pkg/api (excluding pkg/api/types) must now only be accessed from code using `ABISupport`. * Avoid imports from entities on handlers to prevent circular dependencies. * Move `podman system service` logic into `cmd` to prevent circular dependencies - it depends on pkg/api. * Also remove the build header from infra/abi files. It will otherwise confuse swagger and other tools; errors we cannot fix as go doesn't expose a build-tag env variable. Fixes: #5847 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5862 from rhatdan/v2OpenShift Merge Robot2020-04-20
|\ \ | | | | | | Fix up handling of image data as well as setting Linux Capabilties correctly
| * | Fix podman inspect to accept -l and -s fieldsDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Podman inspect has a breaking change in that it dropped --latest and --size options. This PR adds these back. Lots of tests rely on podman inspect -l. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | Handle Linux Capabilities correctlyDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | If user sets capabilities list we need handle minimal capabilities. Also handle seccomp-policy being passed in. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5899 from jwhonce/wip/treeOpenShift Merge Robot2020-04-20
|\ \ \ | | | | | | | | V2 podman image tree
| * | | V2 podman image treeJhon Honce2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Basic port of V1 podman image tree ID TODO: Refactor to return tree from service and format in presentation layer TODO: Support tunneling mode Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #5901 from jwhonce/wip/serviceOpenShift Merge Robot2020-04-20
|\ \ \ \ | |_|/ / |/| | | V2 Remove existing unix domain socket on startup
| * | | V2 Rmove existing unix domain socket on startupJhon Honce2020-04-20
| | | | | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #5896 from giuseppe/fix-cgroup-setOpenShift Merge Robot2020-04-20
|\ \ \ \ | | | | | | | | | | common: setting cgroup resources correctly
| * | | | common: setting cgroup resources correctlyGiuseppe Scrivano2020-04-20
| | |_|/ | |/| | | | | | | | | | | | | | | | | | fix some cgroups related integration tests. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #5897 from jwhonce/wip/diffOpenShift Merge Robot2020-04-20
|\ \ \ \ | |_|/ / |/| | | V2 Fix --latest for podman diff commands
| * | | V2 Fix --latest for podman diff commandsJhon Honce2020-04-20
| | |/ | |/| | | | | | | | | | | | | | | | | | | * --latest now forces container diff * diff options now passed into domain layer * updated help/usage messages Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #5879 from rhatdan/pullOpenShift Merge Robot2020-04-20
|\ \ \ | |/ / |/| | Pull images when doing podman create
| * | Pull images when doing podman createDaniel J Walsh2020-04-20
| |/ | | | | | | | | | | | | | | Currently podman create does not pull images if they don't exist. It should follow the pull policy specified by the user. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5872 from jwhonce/wip/optionsOpenShift Merge Robot2020-04-20
|\ \ | |/ |/| V2 Fix support for tcp://[::]<port> connections
| * V2 Fix support for tcp://[::]<port> connectionsJhon Honce2020-04-17
| | | | | | | | | | | | | | | | | | | | | | | | | | * Fix support for socket activation, on remote and service $ systemd-socket-activate -l 8083 --fdname=podman bin/podman system service --log-level=debug --time=30 $ bin/podman-remote --remote=tcp://[::]:8083 image ls Or, use the podman.{socket,service} unit files $ bin/podman-remote --remote=unix:///run/podman/podman.sock image ls Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5733 from sujil02/v2-pod-pruneOpenShift Merge Robot2020-04-18
|\ \ | | | | | | Add pod prune for api v2
| * | Add pod prune for api v2.Sujil022020-04-17
| |/ | | | | | | | | | | | | | | Add the ability to prune pods for api v2, Includes the addition of force flag, for client side prompt. Update test suite to support this use case. Signed-off-by: Sujil02 <sushah@redhat.com>
* | Merge pull request #5871 from baude/v2t3OpenShift Merge Robot2020-04-18
|\ \ | |/ |/| enable integration testing
| * enable integration testingBrent Baude2020-04-17
| | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | We were not handling the user option on createDaniel J Walsh2020-04-17
|/ | | | | | With this patch we can get run_passwd_test.go to pass Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #5868 from baude/v2t2OpenShift Merge Robot2020-04-17
|\ | | | | Fixes for system tests
| * Fixes for system testsBrent Baude2020-04-17
| | | | | | | | | | | | Various fixes to protect against regressions in system tests Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5819 from vrothberg/v2-buildOpenShift Merge Robot2020-04-17
|\ \ | |/ |/| podmanV2: implement build
| * podmanV2: implement buildValentin Rothberg2020-04-17
| | | | | | | | | | | | | | | | Implement `podman build` for the local client. The remote client will require some rather large work in the backend and a new build endpoint for the libpod rest API. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Enable some testingBrent Baude2020-04-17
| | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Fix bug where two configurations had been createdJhon Honce2020-04-16
|/ | | | | | * registry.PodmanConfig() new returns a pointer to the source of truth Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Podman V2 birthBrent Baude2020-04-16
| | | | | | remote podman v1 and replace with podman v2. Signed-off-by: Brent Baude <bbaude@redhat.com>
* V2 Enable rootlessJhon Honce2020-04-16
| | | | | | | | | | | | | * Enable running podman V2 rootless * Fixed cobra.PersistentPreRunE usage in all the commands * Leveraged cobra.PersistentPreRunE/cobra.PersistentPostRunE to manage: * rootless * trace (--trace) * profiling (--cpu-profile) * initializing the registry copies of Image/Container engines * Help and Usage templates autoset for all sub-commands Signed-off-by: Jhon Honce <jhonce@redhat.com>
* podman v2 remove bloat v2Brent Baude2020-04-16
| | | | | | rid ourseleves of libpod references in v2 client Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #5827 from baude/v2bloatOpenShift Merge Robot2020-04-15
|\ | | | | v2 bloat pruning phase 2
| * v2 bloat pruning phase 2Brent Baude2020-04-15
| | | | | | | | | | | | this is second phase of removing unneeded bloat in the remote client. this is important to be able to reduce the client size as well as possible native compilation for windows/mac. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5817 from rhatdan/selinux1OpenShift Merge Robot2020-04-15
|\ \ | |/ |/| Fix up SELinux labeling
| * Fix up SELinux labelingDaniel J Walsh2020-04-15
| | | | | | | | | | | | SELinux label options processing fixes, should allow system tests to pass. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5775 from sujil02/v2-container-pruneOpenShift Merge Robot2020-04-15
|\ \ | |/ |/| Ability to prune container in api V2
| * Ability to prune container in api V2Sujil022020-04-15
| | | | | | | | | | | | | | Adds ability to prune containers for v2. Adds client side prompt with force flag and filters options to prune. Signed-off-by: Sujil02 <sushah@redhat.com>
* | podmanv2 eventsBrent Baude2020-04-15
|/ | | | | | add the ability to monitor events Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #5813 from baude/v2edtests2OpenShift Merge Robot2020-04-15
|\ | | | | More system test fixes on regressions
| * More system test fixes on regressionsBrent Baude2020-04-14
| | | | | | | | | | | | Fix more regressions between v1 and v2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | podmanV2: fix nil derefValentin Rothberg2020-04-15
|/ | | | | | | Fix a typo when looking up a flag causing a nil deref and all commands to fail. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Add support for the global flags and config filesJhon Honce2020-04-14
| | | | | | | Note: This PR doesn't provide full rootless support that will be addressed in a future PR Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #5808 from baude/v2psformat2OpenShift Merge Robot2020-04-14
|\ | | | | v2podman ps revert structure changes
| * v2podman ps revert structure changesBrent Baude2020-04-14
| | | | | | | | | | | | reverting name changes to the listcontainer structure because it negatively impacted the direct consumption of the restful API. instead we now use a local structure in the CLI to modify the output as needed. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5801 from baude/v2mountOpenShift Merge Robot2020-04-14
|\ \ | | | | | | podmanv2 mount and umount
| * | podmanv2 mount and umountBrent Baude2020-04-14
| |/ | | | | | | | | | | add the ability to mount and unmount containers for the local client only Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5804 from rhatdan/seccompOpenShift Merge Robot2020-04-14
|\ \ | | | | | | Need to set security options even if user does not specify options
| * | Need to set security options even if user does not specify optionsDaniel J Walsh2020-04-13
| | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5709 from vrothberg/v2-searchOpenShift Merge Robot2020-04-14
|\ \ \ | |_|/ |/| | podmanV2: implement search