summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Address review comments on #2319Matthew Heon2019-02-12
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Retain a copy of container exit file on cleanupMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | When cleaning up containers, we presently remove the exit file created by Conmon, to ensure that if we restart the container, we won't have conflicts when Conmon tries writing a new exit file. Unfortunately, we need to retain that exit file (at least until we get a workable events system), so we can read it in cases where the container has been removed before 'podman run' can read its exit code. So instead of removing it, rename it, so there's no conflict with Conmon, and we can still read it later. Fixes: #1640 Signed-off-by: Matthew Heon <mheon@redhat.com>
* Fix manual detach from containers to not wait for exitMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | At present, when manually detaching from an attached container (using the detach hotkeys, default C-p C-q), Podman will still wait for the container to exit to obtain its exit code (so we can set Podman's exit code to match). This is correct in the case where attach finished because the container exited, but very wrong for the manual detach case. As a result of this, we can no longer guarantee that the cleanup and --rm functions will fire at the end of 'podman run' - we may be exiting before we get that far. Cleanup is easy enough - we swap to unconditionally using the cleanup processes we've used for detached and rootless containers all along. To duplicate --rm we need to also teach 'podman cleanup' to optionally remove containers instead of cleaning them up. (There is an argument for just using 'podman rm' instead of 'podman cleanup --rm', but cleanup does have different semantics given that we only ever expect it to run when the container has just exited. I think it might be useful to keep the two separate for things like 'podman events'...) Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #2309 from rhatdan/helpOpenShift Merge Robot2019-02-12
|\ | | | | Don't show global flags except for podman command
| * Don't show global flags except for podman commandDaniel J Walsh2019-02-12
| | | | | | | | | | | | | | | | | | Subcommands should not be showing the global flags. This causes the important information to scroll off the screen. Also fixed a typo on runCommmand (Too many 'm's) Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2315 from baude/remotevolumermOpenShift Merge Robot2019-02-12
|\ \ | | | | | | podman-remote volume rm
| * | podman-remote volume rmbaude2019-02-11
| |/ | | | | | | | | | | | | add the ability to remove/delete volumes with the podman remote client. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2300 from baude/cleanupurfaveOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| Remove urfave/cli from libpod
| * Remove urfave/cli from libpodbaude2019-02-11
| | | | | | | | | | | | | | This is the final cleanup to remove urfave/sli from libpod. Removed old, disabled tests that have not been run in over a year. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2313 from baude/remotevolumecreateOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| podman-remote volume create
| * podman-remote volume createbaude2019-02-11
| | | | | | | | | | | | create a volume using the remote client over varlink Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2307 from baude/repruneremoteOpenShift Merge Robot2019-02-11
|\ \ | | | | | | Separate remote and local commands
| * | Separate remote and local commandsbaude2019-02-11
| | | | | | | | | | | | | | | | | | | | | | | | In the previous CLI, we had an accurate depiction of commands available for the remote client and those available for the local client. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2281 from rhatdan/deleteContainerOpenShift Merge Robot2019-02-11
|\ \ \ | | | | | | | | Remove container from storage on --force
| * | | Remove container from storage on --forceDaniel J Walsh2019-02-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we can get into a state where a container exists in storage but does not exist in libpod. If the user forces a removal of this container, then we should remove it from storage even if the container is owned by another tool. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #2306 from baude/podstatsgotemplateOpenShift Merge Robot2019-02-11
|\ \ \ \ | |_|_|/ |/| | | Podman pod stats -- fix GO template output
| * | | Podman pod stats -- fix GO template outputbaude2019-02-10
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Go templates were not being processed or printed correctly for podman pod stats. Added the ability to do templates as well as honor the table identifier. Fixes #2258 Signed-off-by: baude <bbaude@redhat.com>
* / | pod: drop not valid check for rootlessGiuseppe Scrivano2019-02-11
|/ / | | | | | | | | | | | | rootless networks support port binding if the underlying slirp4netns is new enough. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #2296 from baude/psShowMountOpenShift Merge Robot2019-02-09
|\ \ | |/ |/| Add volume mounts to PS output
| * Add volume mounts to PS outputbaude2019-02-08
| | | | | | | | | | | | | | | | | | When listing containers, you should be able to list the mounts with something like --format "table{{".Mounts}}". Resolves: #2238 Signed-off-by: baude <bbaude@redhat.com>
* | do not crash when displaying dangling imagesbaude2019-02-08
|/ | | | | | | | | | | the previous method required a populated image template to create the headers and always selected the first image in the slice. when dealing with dangling images, they are not populated and therefore would panic. Resolves: #2246 Signed-off-by: baude <bbaude@redhat.com>
* Migrate to cobra CLIbaude2019-02-08
| | | | | | | | We intend to migrate to the cobra cli from urfave/cli because the project is more well maintained. There are also some technical reasons as well which extend into our remote client work. Signed-off-by: baude <bbaude@redhat.com>
* Remove some dead type declarationsNalin Dahyabhai2019-02-07
| | | | Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* Merge pull request #2252 from rhatdan/systemOpenShift Merge Robot2019-02-06
|\ | | | | Add podman system prune and info commands
| * Capatilize all usage and descriptionsDaniel J Walsh2019-02-05
| | | | | | | | | | | | | | | | | | We have no consistancy in out option usages and descritions on whether or not the first letter should be capatalized. This patch forces them all to be capatilized. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Add podman system prune and info commandsDaniel J Walsh2019-02-05
| | | | | | | | | | | | | | | | | | We are missing the equivalence of the docker system commands This patch set adds `podman system prune` and `podman system info` Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Add StartPeriod to cmd/podman/docker.HealthConfigNalin Dahyabhai2019-02-06
|/ | | | | | | Backport the addition of the StartPeriod field to our copy of the HealthConfig type, added in docker v17.05.0-ce. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* podman-remote import|exportbaude2019-02-05
| | | | | | | | addition of import and export for the podman-remote client. This includes the ability to send and receive files between the remote-client and the "podman" host using an upgraded varlink connection. Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #2196 from baude/toolboxDaniel J Walsh2019-02-05
|\ | | | | Changes to container runlabel for toolbox project
| * Changes to container runlabel for toolbox projectbaude2019-01-30
| | | | | | | | | | | | | | | | | | | | The toolbox project would benefit from a few changes to more closely resembe the original atomic cli project. Changes made are: * only pull image for container runlabel if the label exists in the image * if a container image does not have the desired label, exit with non-zero Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2143 from QiWang19/continue2108OpenShift Merge Robot2019-02-01
|\ \ | | | | | | Fix up `image sign` in PR 2108
| * | Fix up `image sign` in PR 2108Qi Wang2019-01-15
| | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Merge pull request #2239 from bodunov/masterOpenShift Merge Robot2019-02-01
|\ \ \ | | | | | | | | Consistency in verbs in podman help command
| * | | For consistency in usage output the verbs changed from 3rd person to 1st person.Ivan Bodunov2019-01-30
| | | | | | | | | | | | | | | | Signed-off-by: Ivan Bodunov <ivan.bodunov@gmail.com>
* | | | Merge pull request #2236 from baude/listcontainermountsmapOpenShift Merge Robot2019-02-01
|\ \ \ \ | | | | | | | | | | Alter varlink API for ListContainerMounts to return a map
| * | | | Alter varlink API for ListContainerMounts to return a mapbaude2019-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to return a map of containermounts where the key is container id and it points to the mountpath. Issue #2215 Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #2232 from baude/pstableOpenShift Merge Robot2019-02-01
|\ \ \ \ \ | | | | | | | | | | | | Fix regression in ps with custom format
| * | | | | Fix regression in ps with custom formatbaude2019-01-30
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the table keyword in go templating had regressed and was no longer working. Fixes: 2221 Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #2244 from rhatdan/versionOpenShift Merge Robot2019-01-30
|\ \ \ \ \ | | | | | | | | | | | | Add support for short option -f in podman version
| * | | | | Add support for short option -f in podman versionDaniel J Walsh2019-01-30
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | docker version supports a short options -f for --format Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #2243 from rhatdan/sizeOpenShift Merge Robot2019-01-30
|\ \ \ \ \ | | | | | | | | | | | | Add support for short option -s in podman inspect
| * | | | | Add support for short option -s in podman inspectDaniel J Walsh2019-01-30
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | docker inspect supports a short -s option for --size. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* / / / / Add support for short option -fDaniel J Walsh2019-01-30
|/ / / / | | | | | | | | | | | | | | | | | | | | docker info supports a short -f option for --format. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #2230 from rhatdan/quietOpenShift Merge Robot2019-01-30
|\ \ \ \ | |_|/ / |/| | | Make --quiet work in podman create/run
| * | | Make --quiet work in podman create/runDaniel J Walsh2019-01-29
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | The --queit option is supposed to suppress the pulling messages when a new image is being pulled down. This patch fixes this issue. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* / / podman image prune -- implement all flagbaude2019-01-29
|/ / | | | | | | | | | | | | | | | | | | | | we now, by default, only prune dangling images. if --all is passed, we prune dangling images AND images that do not have an associated containers. also went ahead and enabled the podman-remote image prune side of things. Fixes: #2192 Signed-off-by: baude <bbaude@redhat.com>
* | enable podman-remote versionbaude2019-01-21
| | | | | | | | | | | | | | | | | | | | initial enablement of podman-remote version. includes add a APIVersion const that will allow us to check compatibility between host/client when connections are made. also added client related information to podman info. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2187 from rhatdan/selinuxOpenShift Merge Robot2019-01-21
|\ \ | | | | | | Vendor in latest opencontainers/selinux
| * | Vendor in latest opencontainers/selinuxDaniel J Walsh2019-01-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will now verify labels passed in by the user. Will also prevent users from accidently relabeling their homedir. podman run -ti -v ~/home/user:Z fedora sh Is not a good idea. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2184 from baude/remotemaskcommandsOpenShift Merge Robot2019-01-20
|\ \ \ | | | | | | | | Mask unimplemeted commands for remote client
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-07 00:40:09 +0000