summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Merge pull request #2949 from baude/remotecontainercommandsOpenShift Merge Robot2019-04-16
|\ | | | | podman-remote container commands
| * podman-remote container commandsbaude2019-04-16
| | | | | | | | | | | | | | Several container commands were ported to the remote client but had not been updated on the container submenu yet. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2934 from haircommander/kube-fileOpenShift Merge Robot2019-04-16
|\ \ | |/ |/| Add File mounts to play kube
| * Add File mounts to play kubePeter Hunt2019-04-15
| | | | | | | | | | | | Both File and FileOrCreate options are supported. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | Merge pull request #2946 from baude/segsOpenShift Merge Robot2019-04-16
|\ \ | | | | | | Fix segfaults attribute to missing options
| * | Fix segfaults attribute to missing optionsbaude2019-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | In cases where the remote client culls options to a command, we need to be sure that the lookup for that flag does not result in a nil pointer. To do so, we add a Remote attribute to the podman struct and then cli helper funcs are now aware they are remote. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2944 from mheon/fix_renumberOpenShift Merge Robot2019-04-15
|\ \ \ | | | | | | | | Call the runtime with WithRenumber() when asked by 'system renumber' command
| * | | Call the runtime with WithRenumber() when askedMatthew Heon2019-04-15
| | |/ | |/| | | | | | | | | | | | | | | | We must have lost this at some point, rendering system renumber useless. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | cmd, pkg: drop commented codeGiuseppe Scrivano2019-04-15
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | pod: drop dead codeGiuseppe Scrivano2019-04-15
| | | | | | | | | | | | | | | | | | | | | we always create a user namespace now, so no need to check if we are running as non root. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | rootless, mount: not create namespaceGiuseppe Scrivano2019-04-15
| |/ |/| | | | | | | | | | | we need to check if we are able to mount the container as part of the mount command itself. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Incorporate image and default environment variables in play kubePeter Hunt2019-04-14
|/ | | | | | Also put Environment variable parsing from image data into a helper function Signed-off-by: Peter Hunt <pehunt@redhat.com>
* Merge pull request #2830 from baude/remotecheckpointOpenShift Merge Robot2019-04-13
|\ | | | | remote-client checkpoint/restore
| * remote-client checkpoint/restorebaude2019-04-11
| | | | | | | | | | | | | | add the ability for the remote client to be able to checkpoint and restore containers. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2911 from giuseppe/fix-pull-errorsOpenShift Merge Robot2019-04-12
|\ \ | | | | | | pull: fix a couple of issues
| * | pull: exit with error if the image is not foundGiuseppe Scrivano2019-04-12
| | | | | | | | | | | | | | | | | | Closes: https://github.com/containers/libpod/issues/2785 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | pull: remove cryptic error messageGiuseppe Scrivano2019-04-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we were printing something like: (0x1840f00,0xc00041bba0) Closes: https://github.com/containers/libpod/issues/2710 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2903 from baude/remotegenkubeOpenShift Merge Robot2019-04-12
|\ \ \ | |/ / |/| | podman-remote generate kube
| * | podman-remote generate kubebaude2019-04-12
| |/ | | | | | | | | | | Allow the ability to generate kube YAML from the podman remote-client. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2885 from kunalkushwaha/image-dangling-filter-fixOpenShift Merge Robot2019-04-11
|\ \ | | | | | | imagefilter dangling handling corrected
| * | imagefilter dangling handling correctedKunal Kushwaha2019-04-11
| | | | | | | | | | | | | | | | | | | | | imagefilter dangling=<value> shall not be ignored. this PR handles the value and returns images accordingly. Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
* | | Merge pull request #2902 from baude/remoteattachfixesOpenShift Merge Robot2019-04-11
|\ \ \ | | | | | | | | Fixes for podman-remote run and attach
| * | | Fixes for podman-remote run and attachbaude2019-04-11
| | |/ | |/| | | | | | | | | | | | | | | | | | | Fixes the ability to run (create,start) a container and attach to its console correctly. We can now also exit from the console without hanging the remote client. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2895 from mheon/commit_no_default_include_volumesOpenShift Merge Robot2019-04-11
|\ \ \ | | | | | | | | Add --include-volumes flag to 'podman commit'
| * | | Add --include-volumes flag to 'podman commit'Matthew Heon2019-04-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'docker commit' will never include a container's volumes when committing, without an explicit request through '--change'. Podman, however, defaulted to including user volumes as image volumes. Make this behavior depend on a new flag, '--include-volumes', and make the default behavior match Docker. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #2879 from mheon/header_on_no_imagesOpenShift Merge Robot2019-04-11
|\ \ \ \ | |_|/ / |/| | | Print header for 'podman images' even with no images present
| * | | Print header for 'podman images' even with no imagesMatthew Heon2019-04-10
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #2877 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #2883 from baude/remoteclifixesOpenShift Merge Robot2019-04-11
|\ \ \ \ | |_|/ / |/| | | Initial remote flag clean up
| * | | Initial remote flag clean upbaude2019-04-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The remote client should not honor most of the local podman "global" options. Many of them are only applicable to where the podman backend is actually running. Also, removing some options for push and pull that also are not applicable to the remote client environment. Additionally, take some of the code from main and pop it into functions that can be called whether local or not. This helps the remote client and darwin builds. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #2892 from edsantiago/healthcheck_typo_fixOpenShift Merge Robot2019-04-10
|\ \ \ \ | |/ / / |/| | | (minor): fix misspelled 'Healthcheck'
| * | | (minor): fix misspelled 'Healthcheck'Ed Santiago2019-04-10
| | | | | | | | | | | | | | | | Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Add the ability to attach remotely to a containerbaude2019-04-10
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, you can now podman-remote run -it. There are some bugs that need to be ironed out but I would prefer to merge this so we can make both progress on start and exec as well as the bugs. * when doing podman-remote run -it foo /bin/bash, you have to press enter to get the prompt to display. with the localized podman, we had to teach it connect to the console first and then start the container so we did not miss anything. * when executing "exit" in the console, we get a hard lockup likely because nobody knows what to do. * custom detach keys are not supported * podman-remote run -it alpine ls does not currently work. only dropping to a shell works. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2882 from baude/remotepsOpenShift Merge Robot2019-04-10
|\ \ \ | |_|/ |/| | podman-remote ps
| * | podman-remote psbaude2019-04-09
| |/ | | | | | | | | | | add the ability to run ps on containers using the remote client. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2663 from jwhonce/wip/remote_umountOpenShift Merge Robot2019-04-09
|\ \ | | | | | | Implement podman-remote umount and rm command
| * | Implement podman-remote rmJhon Honce2019-04-09
| |/ | | | | | | | | | | | | | | | | * refactor command output to use one function * Add new worker pool parallel operations * Implement podman-remote umount * Refactored podman wait to use printCmdOutput() Signed-off-by: Jhon Honce <jhonce@redhat.com>
* / ps: now works with --size and nonrootEd Santiago2019-04-09
|/ | | | | | | | | | Revert the error check from #2832. This is not strictly necessary, since 'podman ps --size' now works perfectly fine in nonroot because some recent change (Giuseppe's, presumably) masked os.Geteuid() return 0... but removing for maintainability's sake. Signed-off-by: Ed Santiago <santiago@redhat.com>
* Merge pull request #2746 from baude/remotecreateOpenShift Merge Robot2019-04-08
|\ | | | | podman-remote create|run
| * podman-remote create|runbaude2019-04-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | add the ability to create and run containers via the podman-remote client. we now create an intermediate layer from the the create/run cli flags. the intermediate layer can be converted into a createconfig or into a varlink struct. Once transported, the varlink struct can be converted back to an intermediate layer and then to a createconfig. remote terminals are not supported yet. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2845 from QiWang19/cpdirOpenShift Merge Robot2019-04-08
|\ \ | |/ |/| fix bug podman cp directory
| * fix bug podman cp directoryQi Wang2019-04-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `podman cp` used to copy the contents under the source directory to the destination. But according to the specification in podman-cp.md. it should copy the whole directory to the destination if the destination directory already exists. - src dir ends with /., copy the contents to dest dir - src dir does not end with /. - dest dir /home does not exist, copy the contents - dest dir /home exists, copy the directory ``` $ sudo podman cp /home/qiwan/Documents/empty 7c47:/home $ sudo podman exec -it 7c47 ls /home $ $ sudo podman cp /home/qiwan/Documents/empty 7c47:/home $ sudo podman exec -it 7c47 ls /home empty ``` Signed-off-by: Qi Wang <qiwan@redhat.com>
* | Revert "Switch to golangci-lint"Brent Baude2019-04-05
| | | | | | | | Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2742 from openSUSE/golangci-lintDaniel J Walsh2019-04-05
|\ \ | | | | | | Switch to golangci-lint
| * | Add deadcode linterSascha Grunert2019-04-04
| | | | | | | | | | | | Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | Merge pull request #2856 from haircommander/kube-entrypointOpenShift Merge Robot2019-04-05
|\ \ \ | | | | | | | | Respect image entrypoint in play kube
| * | | Respect image entrypoint in play kubePeter Hunt2019-04-04
| | | | | | | | | | | | | | | | | | | | | | | | Before we ignored an entrypoint specified in an image, which lead to crashes when a user assumed the entrypoint would be used Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | | podman: enable kube for rootlessGiuseppe Scrivano2019-04-05
| | | | | | | | | | | | | | | | | | | | | | | | Closes: https://github.com/containers/libpod/issues/2852 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | kube: correctly set the default for MemorySwappinessGiuseppe Scrivano2019-04-05
|/ / / | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | / podman-remote image treebaude2019-04-04
| |/ |/| | | | | | | | | | | add the ability for the podman-remote client to be able to print an image tree. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2706 from giuseppe/rootless-single-usernamespaceOpenShift Merge Robot2019-04-04
|\ \ | |/ |/| rootless: single user namespace