summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Add debugging for errors to Cobra compatibility macrosMatthew Heon2019-02-27
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Fix ignored --stop-timeout flag to 'podman create'Matthew Heon2019-02-27
| | | | | | | | | Also add some extra debug information to help figure out what's going on when stop goes bad. Fixes: #2472 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #2454 from mheon/all_your_defaults_belong_to_libpodOpenShift Merge Robot2019-02-27
|\ | | | | Move all storage configuration defaults into libpod
| * Move all storage configuration defaults into libpodMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | | | | | | | Instead of passing in defaults via WithStorageConfig after computing them in cmd/podman/libpodruntime, do all defaults in libpod itself. This can alleviate ordering issues which caused settings in the libpod config (most notably, volume path) to be ignored. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #2456 from edsantiago/better_synopsesOpenShift Merge Robot2019-02-27
|\ \ | | | | | | Better usage synopses for subcommands
| * | Better usage synopses for subcommandsEd Santiago2019-02-26
| |/ | | | | | | | | | | | | Conceptually simple: include, where applicable, a brief description of command-line options for each subcommand. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #2460 from adrianreber/restoreOpenShift Merge Robot2019-02-27
|\ \ | |/ |/| Remove restore as podman subcommand
| * Remove restore as podman subcommandAdrian Reber2019-02-27
| | | | | | | | | | | | | | | | The commands checkpoint and restore should only be available under 'podman container'. This is probably a result of the recent cobra migration. Signed-off-by: Adrian Reber <areber@redhat.com>
* | Merge pull request #2446 from mheon/add_image_volumeOpenShift Merge Robot2019-02-26
|\ \ | | | | | | Only remove image volumes when removing containers
| * | Only remove image volumes when removing containersMatthew Heon2019-02-26
| |/ | | | | | | | | | | | | | | | | | | | | | | When removing volumes with rm --volumes we want to only remove volumes that were created with the container. Volumes created separately via 'podman volume create' should not be removed. Also ensure that --rm implies volumes will be removed. Fixes #2441 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #2443 from baude/playstartrecursiveOpenShift Merge Robot2019-02-26
|\ \ | | | | | | start pod containers recursively
| * | start pod containers recursivelybaude2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | when using the play kube command, we need to make sure that containers with dependancies are started in proper order. in this case, the infra container must be started first. Signed-off-by: baude <bbaude@redhat.com>
* | | Fix podman logs -lAdrian Reber2019-02-26
| |/ |/| | | | | | | | | | | 'podman logs -l' was no longer working. This fixes it by replacing &waitCommand.Latest with &logsCommand.Latest. Signed-off-by: Adrian Reber <areber@redhat.com>
* | When location of c/storage root changes, set VolumePathMatthew Heon2019-02-26
|/ | | | | | | | | | | | | | | We want named volumes to be created in a subdirectory of the c/storage graph root, the same as the libpod root directory is now. As such, we need to adjust its location when the graph root changes location. Also, make a change to how we set the default. There's no need to explicitly set it every time we initialize via an option - that might conflict with WithStorageConfig setting it based on graph root changes. Instead, just initialize it in the default config like our other settings. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* podman-remote pod pause|unpause|restartbaude2019-02-25
| | | | | | | enable the ability for the remote client to pause, unpause, and restart pods. Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #2422 from baude/remotepodcreateOpenShift Merge Robot2019-02-25
|\ | | | | podman-remote create|ps
| * podman-remote create|psbaude2019-02-25
| | | | | | | | | | | | | | enable the podman-remote client to be able to create and list pods on a remote system. Signed-off-by: baude <bbaude@redhat.com>
* | Change exit code to 1 on podman rmi nosuch imageDaniel J Walsh2019-02-25
| | | | | | | | | | | | | | | | Make it easy for scripts to determine if an image removal failure. If only errors were no such image exit with 1 versus 125. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2423 from rhatdan/rmOpenShift Merge Robot2019-02-25
|\ \ | | | | | | Change exit code to 1 on podman rm nosuch container
| * | Change exit code to 1 on podman rm nosuch containerDaniel J Walsh2019-02-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | Make it easy for scripts to determine if a container removal fails versus the container did not exist. If only errors were no such container exit with 1 versus 125. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | remove duplicate commands in mainbaude2019-02-25
|/ / | | | | | | | | | | | | | | | | | | | | kube was erronously being added as main subcommand multiple times. it should not be a subcommand as it should live under either play or generate. also removing the addition of the volume command from the commands.go to eliminate a duplicate. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2419 from rhatdan/playOpenShift Merge Robot2019-02-24
|\ \ | | | | | | Fix play to show up in podman help
| * | Fix play to show up in podman helpDaniel J Walsh2019-02-23
| | | | | | | | | | | | | | | | | | Also change generate cli calls to match other commands. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2416 from rhatdan/networkOpenShift Merge Robot2019-02-24
|\ \ \ | | | | | | | | Allow dns settings with --net=host
| * | | Allow dns settings with --net=hostDaniel J Walsh2019-02-23
| |/ / | | | | | | | | | | | | | | | | | | | | | This seems to be a needless restriction. We make a copy of the hosts /etc/resolv.conf file, so these changes to not modify the host. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2413 from baude/remotepodstopOpenShift Merge Robot2019-02-24
|\ \ \ | | |/ | |/| Enable more podman-remote pod commands
| * | Enable more podman-remote pod commandsbaude2019-02-22
| | | | | | | | | | | | | | | | | | enable pod start, stop, and kill subcommands for the remote-client. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2400 from rhatdan/pullOpenShift Merge Robot2019-02-23
|\ \ \ | | | | | | | | Switch defaults for podman build versus buildah
| * | | Switch defaults for podman build versus buildahDaniel J Walsh2019-02-23
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Switch defaults for --layers, --force-rm and --pull-always from buildah to podman. Only override default values. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2404 from baude/remoteerrorsOpenShift Merge Robot2019-02-23
|\ \ \ | |/ / |/| | make remote-client error messaging more robust
| * | make remote-client error messaging more robustbaude2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | the remote-client is currently weak for carrying error messages over the varlink interface and displaying something useful to users and developers for the purposes of debug. this is a starting point to improve that user experience. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2401 from TomSweeneyRedHat/dev/tsweeney/buildah1.7OpenShift Merge Robot2019-02-22
|\ \ \ | |_|/ |/| | Vendor Buildah v1.7
| * | Vendor Buildah v1.7TomSweeneyRedHat2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Vendors in Buildah 1.7 into Podman. Also the latest imagebuilder and changes for `build --target` Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2406 from rhatdan/errorsOpenShift Merge Robot2019-02-22
|\ \ \ | | | | | | | | Exit with errors not just logging error
| * | | Exit with errors not just logging errorDaniel J Walsh2019-02-22
| |/ / | | | | | | | | | | | | | | | | | | Several commands were logging errors but exiting with a 0 exit code. This patch cleans these up. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2410 from giuseppe/cp-rootless-supportOpenShift Merge Robot2019-02-22
|\ \ \ | |/ / |/| | cmd: support rootless mode for cp command
| * | cmd: support rootless mode for cp commandGiuseppe Scrivano2019-02-22
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2386 from baude/cobravalidationOpenShift Merge Robot2019-02-22
|\ \ \ | |/ / |/| | Improve command line validation
| * | hide --latest on the remote-clientbaude2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | in the case of the remote-client, it was decided to hide the latest flag to avoid confusion for end-users on what the "last" container, volume, or pod are. Signed-off-by: baude <bbaude@redhat.com>
| * | Improve command line validationbaude2019-02-22
| |/ | | | | | | | | | | | | Use the checkallandlatest function to validate flag usage as part of the cobra command args validation. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2402 from baude/remotepodinspectOpenShift Merge Robot2019-02-22
|\ \ | |/ |/| podman-remote pod inspect|exists
| * podman-remote pod inspect|existsbaude2019-02-22
| | | | | | | | | | | | | | | | enable the remote client to be able to inspect a pod. also, bonus of enabling the podman pod exists command which returns a 0 or 1 depending on whether the given pod exists. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2389 from baude/issue2388OpenShift Merge Robot2019-02-22
|\ \ | | | | | | add newline to images output
| * | update: remove duplicate newlineEd Santiago2019-02-21
| | | | | | | | | | | | Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | add newline to images outputbaude2019-02-20
| | | | | | | | | | | | | | | | | | | | | | | | ensure a final newline is always added to images output. fixes #2388 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2350 from mheon/lock_renumberOpenShift Merge Robot2019-02-21
|\ \ \ | |_|/ |/| | Add lock renumbering
| * | Fix typo in commentMatthew Heon2019-02-21
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Do not make renumber shut down the runtimeMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original intent behind the requirement was to ensure that, if two SHM lock structs were open at the same time, we should not make such a runtime available to the user, and should clean it up instead. It turns out that we don't even need to open a second SHM lock struct - if we get an error mapping the first one due to a lock count mismatch, we can just delete it, and it cleans itself up when it errors. So there's no reason not to return a valid runtime. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Add podman system renumber commandMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | This command allows for renumbering Podman locks after an upgrade to Podman with SHM locks from a 1.0 or earlier branch, or after the number of locks was changed. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Add ability to get a runtime that renumbersMatthew Heon2019-02-21
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>