summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Fix handling of --cidfile on create/runDaniel J Walsh2020-04-22
| | | | | | | | Currently create and run are ignoring the cidfile flag. Enable stop_test.go to make sure this works. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #5919 from rhatdan/v2OpenShift Merge Robot2020-04-21
|\ | | | | Lots more fixes for V2 conversion.
| * Handle hostname flag from clientDaniel J Walsh2020-04-21
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Add support for devices from command lineDaniel J Walsh2020-04-21
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Fix handling of CGroupsParent and CGroupsModeDaniel J Walsh2020-04-21
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Throw error on IPv6 ip addressesDaniel J Walsh2020-04-21
| | | | | | | | | | | | Podman does not currently support IPv6 addresses. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5851 from jwhonce/wip/jsonOpenShift Merge Robot2020-04-21
|\ \ | | | | | | Provide a json variable pointing to a configured json API
| * | Provide a json variable pointing to a configured json APIJhon Honce2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | * All commands now using the same instance of json API * `json` variable created in each package to prevent `encoding/json` from being re-introduced Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Modify namespace generation code for specgenMatthew Heon2020-04-21
| |/ |/| | | | | | | | | | | | | | | | | | | | | Namespaces have now been changed to properly handle all cases. Spec handling code for namespaces was consolidated in a single function. Still missing: - Image ports - Pod namespaces likely still broken in Podmanv2 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5917 from vrothberg/v2-login-logoutOpenShift Merge Robot2020-04-21
|\ \ | | | | | | v2: implement log{in,out}
| * | v2: implement log{in,out}Valentin Rothberg2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | Implement podman login and logout. Smoke tests were successful but the system tests are currently failing as we seem unable to run a registry at the moment. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5911 from giuseppe/cgroup-skip-unsetOpenShift Merge Robot2020-04-21
|\ \ \ | | | | | | | | podman: do not set empty cgroup limit blocks
| * | | podman: do not set empty cgroup limit blocksGiuseppe Scrivano2020-04-21
| |/ / | | | | | | | | | | | | | | | | | | refactor cgroup limits in their own function. If there are no limits set avoid to set the block. Basic rootless containers work now. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5923 from baude/mybadOpenShift Merge Robot2020-04-21
|\ \ \ | | | | | | | | my bad
| * | | my badBrent Baude2020-04-21
| | |/ | |/| | | | | | | | | | | | | typos in previous pr are causing panics Signed-off-by: Brent Baude <bbaude@redhat.com>
* / | podmanv2 cpBrent Baude2020-04-21
|/ / | | | | | | | | | | enable podman to copy files between container and host, local mode only. this is a straight port of v1 code to v2. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5908 from baude/v2subsOpenShift Merge Robot2020-04-21
|\ \ | | | | | | podmanv2 container subcommands
| * | podmanv2 container subcommandsBrent Baude2020-04-21
| | | | | | | | | | | | | | | | | | add container subcommands with example text that has proper context. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | v2podman portBrent Baude2020-04-21
|/ / | | | | | | | | | | add port command to podman. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5913 from rhatdan/v2OpenShift Merge Robot2020-04-21
|\ \ | |/ |/| More fixes for podman create tests
| * Need to set the EntrypointDaniel J Walsh2020-04-21
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Fix podman inspect to return errors on failureDaniel J Walsh2020-04-21
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5647 from rhatdan/containers.confOpenShift Merge Robot2020-04-21
|\ \ | |/ |/| Update podmanV2 to use containers.conf
| * Update podman to use containers.confDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | Add more default options parsing Switch to using --time as opposed to --timeout to better match Docker. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5875 from rhatdan/networkOpenShift Merge Robot2020-04-21
|\ \ | | | | | | Cleanup network option parsing
| * | Cleanup network option parsingDaniel J Walsh2020-04-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were not handling the parsing of --ip. This pr adds validation checks and now will support the flag. Move validation to the actual parsing of the network flags. We should only parse the dns flags if the user changed them. We don't want to pass default options if set in containers.conf to the server. Potential for duplicating defaults. Add support for --dns-opt flag passing Begin handling of --network flag, although we don't have a way right now to translate a string into a specgen.Namespace. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | podman rmi: refactor logicValentin Rothberg2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While this commit was initially meant to fix #5847, it has turned into a bigger refactoring which I did not manage to break into smaller pieces: * Fix #5847 by refactoring the image-removal logic. * Make the api handler for image-removal use the ABI code. This way, both (i.e., ABI and Tunnel) end up using the same code. Achieving this code share required to move some code around to prevent circular dependencies. * Everything in pkg/api (excluding pkg/api/types) must now only be accessed from code using `ABISupport`. * Avoid imports from entities on handlers to prevent circular dependencies. * Move `podman system service` logic into `cmd` to prevent circular dependencies - it depends on pkg/api. * Also remove the build header from infra/abi files. It will otherwise confuse swagger and other tools; errors we cannot fix as go doesn't expose a build-tag env variable. Fixes: #5847 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5862 from rhatdan/v2OpenShift Merge Robot2020-04-20
|\ \ \ | | | | | | | | Fix up handling of image data as well as setting Linux Capabilties correctly
| * | | Fix podman inspect to accept -l and -s fieldsDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Podman inspect has a breaking change in that it dropped --latest and --size options. This PR adds these back. Lots of tests rely on podman inspect -l. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | Handle Linux Capabilities correctlyDaniel J Walsh2020-04-20
| | |/ | |/| | | | | | | | | | | | | | | | | | | If user sets capabilities list we need handle minimal capabilities. Also handle seccomp-policy being passed in. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5899 from jwhonce/wip/treeOpenShift Merge Robot2020-04-20
|\ \ \ | | | | | | | | V2 podman image tree
| * | | V2 podman image treeJhon Honce2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Basic port of V1 podman image tree ID TODO: Refactor to return tree from service and format in presentation layer TODO: Support tunneling mode Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #5901 from jwhonce/wip/serviceOpenShift Merge Robot2020-04-20
|\ \ \ \ | |_|/ / |/| | | V2 Remove existing unix domain socket on startup
| * | | V2 Rmove existing unix domain socket on startupJhon Honce2020-04-20
| | | | | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #5896 from giuseppe/fix-cgroup-setOpenShift Merge Robot2020-04-20
|\ \ \ \ | | | | | | | | | | common: setting cgroup resources correctly
| * | | | common: setting cgroup resources correctlyGiuseppe Scrivano2020-04-20
| | |_|/ | |/| | | | | | | | | | | | | | | | | | fix some cgroups related integration tests. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #5897 from jwhonce/wip/diffOpenShift Merge Robot2020-04-20
|\ \ \ \ | |_|/ / |/| | | V2 Fix --latest for podman diff commands
| * | | V2 Fix --latest for podman diff commandsJhon Honce2020-04-20
| | |/ | |/| | | | | | | | | | | | | | | | | | | * --latest now forces container diff * diff options now passed into domain layer * updated help/usage messages Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #5879 from rhatdan/pullOpenShift Merge Robot2020-04-20
|\ \ \ | |/ / |/| | Pull images when doing podman create
| * | Pull images when doing podman createDaniel J Walsh2020-04-20
| |/ | | | | | | | | | | | | | | Currently podman create does not pull images if they don't exist. It should follow the pull policy specified by the user. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5872 from jwhonce/wip/optionsOpenShift Merge Robot2020-04-20
|\ \ | |/ |/| V2 Fix support for tcp://[::]<port> connections
| * V2 Fix support for tcp://[::]<port> connectionsJhon Honce2020-04-17
| | | | | | | | | | | | | | | | | | | | | | | | | | * Fix support for socket activation, on remote and service $ systemd-socket-activate -l 8083 --fdname=podman bin/podman system service --log-level=debug --time=30 $ bin/podman-remote --remote=tcp://[::]:8083 image ls Or, use the podman.{socket,service} unit files $ bin/podman-remote --remote=unix:///run/podman/podman.sock image ls Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5733 from sujil02/v2-pod-pruneOpenShift Merge Robot2020-04-18
|\ \ | | | | | | Add pod prune for api v2
| * | Add pod prune for api v2.Sujil022020-04-17
| |/ | | | | | | | | | | | | | | Add the ability to prune pods for api v2, Includes the addition of force flag, for client side prompt. Update test suite to support this use case. Signed-off-by: Sujil02 <sushah@redhat.com>
* | Merge pull request #5871 from baude/v2t3OpenShift Merge Robot2020-04-18
|\ \ | |/ |/| enable integration testing
| * enable integration testingBrent Baude2020-04-17
| | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | We were not handling the user option on createDaniel J Walsh2020-04-17
|/ | | | | | With this patch we can get run_passwd_test.go to pass Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #5868 from baude/v2t2OpenShift Merge Robot2020-04-17
|\ | | | | Fixes for system tests
| * Fixes for system testsBrent Baude2020-04-17
| | | | | | | | | | | | Various fixes to protect against regressions in system tests Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5819 from vrothberg/v2-buildOpenShift Merge Robot2020-04-17
|\ \ | |/ |/| podmanV2: implement build