summaryrefslogtreecommitdiff
path: root/cmd
Commit message (Collapse)AuthorAge
* Podman pod create now errors on receiving CLI argsMatthew Heon2019-02-19
| | | | | | | It has never accepted arguments, so we should error when passed args we will never use. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #2363 from TomSweeneyRedHat/dev/tsweeney/cobraex5OpenShift Merge Robot2019-02-19
|\ | | | | Fifth chunk of Cobra Examples
| * Fifth chunk of Cobra ExamplesTomSweeneyRedHat2019-02-18
| | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> The fifth and final chunk of examples for the Cobra examples in the CLI help output. Also includes a few man page touchups. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | podman-remote pullbaude2019-02-19
|/ | | | | | Add status for remote users and podman remote-client pull. Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #2361 from TomSweeneyRedHat/dev/tsweeney/cobraex4OpenShift Merge Robot2019-02-18
|\ | | | | Add 4th chunk of Cobra Examples
| * Add 4th chunk of Cobra ExamplesTomSweeneyRedHat2019-02-18
| | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds the 4th chunk of Cobra Examples to the CLI help. One more chunk of 10 to complete. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | OpenTracing support added to start, stop, run, create, pull, and psSebastian Jug2019-02-18
|/ | | | | | Drop context.Context field from cli.Context Signed-off-by: Sebastian Jug <sejug@redhat.com>
* Merge pull request #2354 from rhatdan/varlinkOpenShift Merge Robot2019-02-18
|\ | | | | Add registry name to fields returned by varlink image search
| * Add registry name to fields returned by varlink image searchDaniel J Walsh2019-02-15
| | | | | | | | | | | | | | | | | | | | | | Cockpit team wants to list the registry name where the image was found. Also fix up SearchImages code to check if the user specified a registry in his call to use that rather then all the registries, This matches podman search command. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2357 from TomSweeneyRedHat/dev/tsweeney/cobrahelp3OpenShift Merge Robot2019-02-17
|\ \ | | | | | | Add 3rd chunk of Cobra examples
| * | Add 3rd chunk of Cobra examplesTomSweeneyRedHat2019-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds the third chunk of Cobra examples to the cli help. As were putting together a release tomorrow, tried to hit the heavy commands with this PR. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2295 from haircommander/recursive-startOpenShift Merge Robot2019-02-17
|\ \ \ | |/ / |/| | Recursively start a pod if a container is run in it
| * | pod infra container is started before a container in a pod is run, started, ↵Peter Hunt2019-02-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | or attached. Prior, a pod would have to be started immediately when created, leading to confusion about what a pod state should be immediately after creation. The problem was podman run --pod ... would error out if the infra container wasn't started (as it is a dependency). Fix this by allowing for recursive start, where each of the container's dependencies are started prior to the new container. This is only applied to the case where a new container is attached to a pod. Also rework container_api Start, StartAndAttach, and Init functions, as there was some duplicated code, which made addressing the problem easier to fix. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | Merge pull request #2340 from QiWang19/login_lyingOpenShift Merge Robot2019-02-17
|\ \ \ | | | | | | | | Fix `podman login` lying problem
| * | | Fix `podman login` lying problemQi Wang2019-02-14
| | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #2341 from TomSweeneyRedHat/dev/tsweeney/helpexamples2OpenShift Merge Robot2019-02-16
|\ \ \ \ | |_|/ / |/| | | Second chunk of Cobra help
| * | | Second chunk of Cobra helpTomSweeneyRedHat2019-02-15
| | |/ | |/| | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds examples to Cobra help for a second chunk of commands. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2335 from mheon/enable_detach_rmOpenShift Merge Robot2019-02-15
|\ \ \ | |/ / |/| | Enable --rm with --detach
| * | Fix error code retrieval for podman start --attachMatthew Heon2019-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we start a container with 'podman run' and it exits and is removed before we get the code, we grab its exit code from the Conmon exit file. Podman start --attach wants to do the same, but was missing the logic. Fix that here. Also, remove some --rm handling leftover in start. Don't need it anymore, we have the cleanup process now. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Enable --rm with --detachMatthew Heon2019-02-14
| | | | | | | | | | | | | | | | | | | | | We can now safely remove detached containers as --rm handling has moved into the cleanup process. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | podman: honor --storage-opt againGiuseppe Scrivano2019-02-15
| | | | | | | | | | | | | | | | | | possibly a regression after we moved to Cobra Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2188 from TomSweeneyRedHat/dev/tsweeney/pullallOpenShift Merge Robot2019-02-15
|\ \ \ | | | | | | | | Add --all-tags to pull command
| * | | Add --all-tags to pull commandTomSweeneyRedHat2019-02-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Add --all-tags for the `podman pull` command so all tags of an image will be pulled, not just ':latest'. Emulates the change in Buildah https://github.com/containers/buildah/pull/1263 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Merge pull request #2305 from rhatdan/tlsverifyOpenShift Merge Robot2019-02-15
|\ \ \ \ | | | | | | | | | | Add tlsVerify bool to SearchImage for varlink
| * | | | Add tlsVerify bool to SearchImage for varlinkDaniel J Walsh2019-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cockpit wants to be able to search images on systems without tlsverify turned on. tlsverify should be an optional parameter, if not set then we default to the system defaults defined in /etc/containers/registries.conf. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #2333 from TomSweeneyRedHat/dev/tsweeney/helpexamplesOpenShift Merge Robot2019-02-15
|\ \ \ \ \ | |_|_|_|/ |/| | | | Add examples for Cobra
| * | | | Add examples for CobraTomSweeneyRedHat2019-02-14
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> First pass of entries for the Examples listed in the Cobra Help. Will add others in following PR's.
* | | | Merge pull request #2332 from baude/remotevolumepruneOpenShift Merge Robot2019-02-14
|\ \ \ \ | | | | | | | | | | volume prune
| * | | | enable podman-remote volume prunebaude2019-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | allow users to remotely prune volumes. this is the last volume command for remote enablement. as such, the volume commands are being folded back into main because they are supported for both local and remote clients. also, enable all volume tests that do not use containers as containers are not enabled for the remote client yet. Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #2320 from QiWang19/stdinPWOpenShift Merge Robot2019-02-14
|\ \ \ \ \ | | | | | | | | | | | | --password-stdin flag in `podman login`
| * | | | | --password-stdin flag in `podman login`Qi Wang2019-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support --password-stdin flag, reads a password from STDIN and pass it to `podman login`. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | | Merge pull request #2151 from QiWang19/cpOpenShift Merge Robot2019-02-14
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | 'podman cp' copy between host and container
| * | | | | 'podman cp' copy between host and containerQi Wang2019-02-14
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | / / Fix volume handling in podmanDaniel J Walsh2019-02-14
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | iFix builtin volumes to work with podman volume Currently builtin volumes are not recored in podman volumes when they are created automatically. This patch fixes this. Remove container volumes when requested Currently the --volume option on podman remove does nothing. This will implement the changes needed to remove the volumes if the user requests it. When removing a volume make sure that no container uses the volume. Signed-off-by: Daniel J Walsh dwalsh@redhat.com Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | add build to main and as subcommand to imagebaude2019-02-14
| |/ / |/| | | | | | | | | | | | | | | | | | | | add build as a local and remote-client command in the main podman menu. also ensure it is added to the image subcommands as well. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2321 from baude/remotebuildOpenShift Merge Robot2019-02-14
|\ \ \ | | | | | | | | podman-remote build
| * | | podman-remote buildbaude2019-02-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | add the ability to build images using files local to the remote-client but over a varlink interface to a "remote" server. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #2319 from mheon/unconditional_cleanupOpenShift Merge Robot2019-02-13
|\ \ \ \ | | | | | | | | | | Fix manual detach from containers to not wait for exit
| * | | | Address review comments on #2319Matthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | Retain a copy of container exit file on cleanupMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When cleaning up containers, we presently remove the exit file created by Conmon, to ensure that if we restart the container, we won't have conflicts when Conmon tries writing a new exit file. Unfortunately, we need to retain that exit file (at least until we get a workable events system), so we can read it in cases where the container has been removed before 'podman run' can read its exit code. So instead of removing it, rename it, so there's no conflict with Conmon, and we can still read it later. Fixes: #1640 Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | Fix manual detach from containers to not wait for exitMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At present, when manually detaching from an attached container (using the detach hotkeys, default C-p C-q), Podman will still wait for the container to exit to obtain its exit code (so we can set Podman's exit code to match). This is correct in the case where attach finished because the container exited, but very wrong for the manual detach case. As a result of this, we can no longer guarantee that the cleanup and --rm functions will fire at the end of 'podman run' - we may be exiting before we get that far. Cleanup is easy enough - we swap to unconditionally using the cleanup processes we've used for detached and rootless containers all along. To duplicate --rm we need to also teach 'podman cleanup' to optionally remove containers instead of cleaning them up. (There is an argument for just using 'podman rm' instead of 'podman cleanup --rm', but cleanup does have different semantics given that we only ever expect it to run when the container has just exited. I think it might be useful to keep the two separate for things like 'podman events'...) Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #2331 from baude/issue846OpenShift Merge Robot2019-02-13
|\ \ \ \ \ | |_|/ / / |/| | | | show container ports of network namespace
| * | | | show container ports of network namespacebaude2019-02-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in cases where a container is part of a network namespace, we should show the network namespace's ports when dealing with ports. this impacts ps, kube, and port. fixes: #846 Signed-off-by: baude <bbaude@redhat.com>
* | | | | podman-remote volume inspect|lsbaude2019-02-13
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | add the ability to list and inspect volumes using the remote client and varlink Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #2327 from baude/issue2175OpenShift Merge Robot2019-02-13
|\ \ \ \ | | | | | | | | | | Parse fq name correctly for images
| * | | | Parse fq name correctly for imagesbaude2019-02-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When parsing a string name for repo and tag (for images output), we should be using parsenormalizedname and reference.Canonical to get the proper output. Resolves: #2175 Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #2322 from baude/remotepushOpenShift Merge Robot2019-02-13
|\ \ \ \ \ | | | | | | | | | | | | podman-remote push
| * | | | | podman-remote pushbaude2019-02-13
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | enable podman-remote push so that users can push images from a remote client. change in push API to deal with the need to see output over the varlink connection. Signed-off-by: baude <bbaude@redhat.com>
* / / / / Only build varlink when buildtag is availablebaude2019-02-12
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Correct mistake that broke things like dlv where we should only try to add the varlink command to podman when the 'varlink' build tag is present. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #2264 from larskarlitski/varlink-apiOpenShift Merge Robot2019-02-12
|\ \ \ \ | |/ / / |/| | | Make varlink API more idiomatic
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-07 16:00:57 +0000