summaryrefslogtreecommitdiff
path: root/contrib
Commit message (Collapse)AuthorAge
* turn off color-mode for bindingsBrent Baude2020-03-12
| | | | | | the binding ginkgo tests were using color mode which throws in a bunch of ansi garbage that makes it hard to read the logs Signed-off-by: Brent Baude <bbaude@redhat.com>
* Bump to v1.8.2-devMatthew Heon2020-03-11
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #5395 from cevich/fix_fedora_minimalOpenShift Merge Robot2020-03-08
|\ | | | | Cirrus: Fix fedora-minimal mirroring
| * Cirrus: Fix fedora-minimal mirroringChris Evich2020-03-04
| | | | | | | | | | | | | | Builds of this dockerfile fail on quay.io due to not being able to pull the base image. Use a fully-qualified FROM name to work around this. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Fix spelling mistakes in code found by codespellDaniel J Walsh2020-03-07
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5374 from baude/createOpenShift Merge Robot2020-03-07
|\ \ | | | | | | add default network for apiv2 create
| * | add default network for apiv2 createBrent Baude2020-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | during container creation, if no network is provided, we need to add a default value so the container can be later started. use apiv2 container creation for RunTopContainer instead of an exec to the system podman. RunTopContainer now also returns the container id and an error. added a libpod commit endpoint. also, changed the use of the connections and bindings slightly to make it more convenient to write tests. Fixes: 5366 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5359 from TomSweeneyRedHat/dev/tsweeney/fixquayOpenShift Merge Robot2020-03-07
|\ \ \ | |/ / |/| | Fix upstream dockerfile and add 'by hand' ctrfile
| * | Fix upstream dockerfile and add 'by hand' ctrfileTomSweeneyRedHat2020-03-05
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The podmanimage/upstream/Dockerfile had two rpms in its build procedure that are no longer available. The atomic-registries has been removed and the md2man has been renamed. In addtion conmon was not being installed and I've added that. I've been using a Containerfile to build or rebuild a specific version of the podmanimage stored in the stable repository with a version tag. As the other Containerfiles have been updated by others, and in case anyone else needs to build it, I've added it to the repo and have also updated the readme.md. FWIW, the builds in the quay.io/podman/upstream have been failing for a while due to missing rpms. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #5039 from cevich/fix_gobin_exit_bugOpenShift Merge Robot2020-03-05
|\ \ | |/ |/| Cirrus: Fix gate image & false-positive exits
| * Cirrus: Fix gate image & false-positive exitsChris Evich2020-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A number of scripts relating to tooling used and the gate container image were not exiting upon errors as intended. Coupled with external service unavailability (i.e. downloading golangci-lint) was observed to cause difficult to debug failures. This change corrects the scripts inside/out of the gate container as well as fixes many golang related path consistency problems vs other CI jobs. After this change, all jobs use consistent path names reducing the number of special-case overrides needed. Lastly, I also made a documentation-pass, updating/correcting as needed, including documenting a likely local validation-failure mode, related to `$EPOCH_TEST_COMMIT`. This is dependent on the developers git environment, so documentation is the only possible "fix". Signed-off-by: Chris Evich <cevich@redhat.com>
* | CI: format cirrus logsEd Santiago2020-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This introduces a new cirrus helper script, logformatter. Usage is: [commands...] | logformatter TEST-NAME It reformats its input into a readable, highlighed, linkable form. Some features: - boring stuff (timestamps, standard podman options) is deemphasized - important stuff (warnings, errors) is emphasized - in-page links to the actual failures - active links to source files - jumps to bottom of page on load, because that's where the errors are. (All errors are linked) Add it to select test commands (integration, system) and add a new artifacts_html, run in the 'always' block, which uploads generated *.log.html into Cirrus; from there we generate a live URL that can be viewed in browser. Unfortunately, due to security concerns in Cirrus, it is not currently possible to make the link a live one. Kludge: add a line of dashes after Restoring images; without this, the first test ("systemd PID 1") has no dashes before it, so logformatter doesn't see it. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | CI: add API v2 testsEd Santiago2020-03-02
|/ | | | | | | | | | API v2 has been quiet for a few days, and the test script is actually passing. Let's take advantage of this opportunity to get them running in CI. Requires adding a check for cgroupsv2 Signed-off-by: Ed Santiago <santiago@redhat.com>
* Cirrus: Force runc use in F30Chris Evich2020-02-28
| | | | | | | | | | | Suspect crun might be sneaking in during VM image build via podman RPM dependency. Add it to the removal list when building, then also force use of runc at runtime in F30. Also quote all true/false vars to force them as strings instead of booleans (which will become capitalized) Signed-off-by: Chris Evich <cevich@redhat.com>
* Cirrus: Remove unnecessary handle_crun workaroundChris Evich2020-02-28
| | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* Cirrus: Print env. vars at end of setup.Chris Evich2020-02-28
| | | | | | | There are a number of env. vars set during the setup script. Therefore displaying them at end of the script is more helpful for debugging. Signed-off-by: Chris Evich <cevich@redhat.com>
* Cirrus: Fix not growing Fedora rootChris Evich2020-02-28
| | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* CI: package_versions: include hostinfo, kernelEd Santiago2020-02-27
| | | | | | | | | | | | | | In the package_versions CI step, include Fedora/Ubuntu version, uname -r, and cgroups version. Cgroups version is simply the FS type of /sys/fs/cgroup, which shows 'tmpfs' for v1 and 'cgroup2fs' for v2. I don't think it's worth the effort to prettify those into 'v1/v2' - I think our readers are sophisticated enough to figure it out from context - but am willing to add that feature if requested. Signed-off-by: Ed Santiago <santiago@redhat.com>
* Merge pull request #5329 from baude/contribspecepochOpenShift Merge Robot2020-02-26
|\ | | | | add epoch for specfile
| * add epoch for specfileBrent Baude2020-02-25
| | | | | | | | | | | | to get the copr rpms to jive better with the fedora rpms, we need to set an epoch. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #3901 from cevich/support_f31OpenShift Merge Robot2020-02-25
|\ \ | |/ |/| Cirrus: Support testing with F31
| * Cirrus: SELinux Enforcing for F31 w/ CGv2Chris Evich2020-02-25
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: collect podman system infoChris Evich2020-02-25
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: F31: Force systemd cgroup mgrChris Evich2020-02-25
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Handle runc->crun when both are possibleChris Evich2020-02-25
| | | | | | | | | | | | | | | | | | | | In some distributions it's possible to have both runc and crun installed and/or for podman to be confused about which to use. In these instances, force the decision by adding `OCI_RUNTIME=/usr/bin/crun` into `/etc/environment`. Also in-place modify libpod.conf to use 'crun' instead of 'runc' Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Use deadline elevator in F31Chris Evich2020-02-25
| | | | | | | | | | | | | | | | | | | | | | | | The default scheduler is BFQ but integration tests run into https://bugzilla.redhat.com/show_bug.cgi?id=1767539 aka https://bugzilla.kernel.org/show_bug.cgi?id=205447 Using the deadline elevator as a workaround. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Support testing with F31Chris Evich2020-02-25
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #5312 from raukadah/fixfedora30OpenShift Merge Robot2020-02-25
|\ \ | |/ |/| Fixed build_rpm.sh script for Fedora 30
| * Fixed build_rpm.sh script for Fedora 30Chandan Kumar (raukadah)2020-02-24
| | | | | | | | | | | | | | | | | | | | golang-github-cpuguy83-go-md2man is only available in Fedora 30 and got renamed to golang-github-cpuguy83-md2man for Fedora 31 which breaks the user interface for building rpm on fedora 30. It fixes the same by installing correct md2man package on Fedora 30. Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
* | enable ci on go binding testsBrent Baude2020-02-22
|/ | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* Upgrade make package-install for fedora31Allan Jacquet-Cretides2020-02-21
| | | | | | | | | | | The package golang-github-cpuguy83-go-md2man has been renamed into golang-github-cpuguy83-md2man in f31 repository. That leads to an Error: Unable to find a match: golang-github-cpuguy83-go-md2man This patch handles the renaming of this package and fixes the command for f31 and the one that will follows without breaking compatibility with older versions. Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@gmail.com>
* Merge pull request #5068 from baude/newimagestestOpenShift Merge Robot2020-02-11
|\ | | | | replace prow images test
| * replace prow images testBrent Baude2020-02-10
| | | | | | | | | | | | this is a container-based approach to verifying we can build an rpm based on the contrib spec. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | [CI:DOCS] Update Code of Conduct to Containers variantTomSweeneyRedHat2020-02-10
|/ | | | | | | | | | As the title says. I renamed the old file from the lower case to the upper case name. This makes it appear higher up in the listing on GitHub and also is in line with the rest of the containers projects. Due to this change, I also had to change a few references in a couple of build related files. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* Merge pull request #5107 from cevich/mirror_containersOpenShift Merge Robot2020-02-09
|\ | | | | Add mirroring dockerfiles
| * Add dockerfile to mirror fedora-minimalChris Evich2020-02-06
| | | | | | | | | | | | | | | | This is needed to provide this image under quay.io/libpod/ namespace to provide some resiliency to automated testing (should other repositories be unavailable) Signed-off-by: Chris Evich <cevich@redhat.com>
* | Bump to v1.8.1-devMatthew Heon2020-02-06
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | [CI:DOCS]update contrib systemd userBrent Baude2020-02-06
| | | | | | | | | | | | one more update Signed-off-by: Brent Baude <bbaude@redhat.com>
* | [CI:DOCS]fix systemd files for apiv2Brent Baude2020-02-06
|/ | | | | | the paths and instructions for running the new api via systemd needed updates due to a change in the command. Signed-off-by: Brent Baude <bbaude@redhat.com>
* Update XML to not embed quote in PATH on windowsJhon Honce2020-01-31
| | | | | | | | * Remove the unsupported commend in lua script Fixes #4335 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Bump to v1.8.0-devMatthew Heon2020-01-31
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Bump to v1.8.0-rc1v1.8.0-rc1Matthew Heon2020-01-31
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Assure validate includes lintSorin Sbarnea2020-01-30
| | | | | | Fixed issue where lint was not run on CI, so we missed to prevent regressions. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
* Add link from docker.sock to podman.sockDaniel J Walsh2020-01-27
| | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* [CI:DOCS]Connect API docs and RTDbaude2020-01-17
| | | | Signed-off-by: baude <bbaude@redhat.com>
* post-process swagger yaml for publishbaude2020-01-17
| | | | | Signed-off-by: baude <bbaude@redhat.com> Signed-off-by: Chris Evich <cevich@redhat.com>
* Minor: Bugfix in upload imageChris Evich2020-01-17
| | | | | | | | The release upload process always involves two filenames, however the second filename might (someday) be optional. The code allowed for this, however input validation did not. This change fixes the validation. Signed-off-by: Chris Evich <cevich@redhat.com>
* Merge pull request #4807 from ssbarnea/fix/pre-commitOpenShift Merge Robot2020-01-15
|\ | | | | Enable pre-commit linting
| * Enable pre-commit tool lintingSorin Sbarnea2020-01-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This should help use keep the codebase more consistent, and avoid sevel whitespace related issues, or bad file permissions. pre-commit allows us to easily introduce other linters in follow-ups, like bashate. Note: pre-commit tool does *not* install any git-hooks. Making commits will will call the tool unless you deliverately tell it to install the hooks. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
* | Merge pull request #4870 from vrothberg/gating-dockerfileOpenShift Merge Robot2020-01-15
|\ \ | | | | | | Gating dockerfile