summaryrefslogtreecommitdiff
path: root/contrib
Commit message (Collapse)AuthorAge
* Makefile: include -nobuild install targetsLokesh Mandvekar2020-04-23
| | | | | | | | | | | | | | | Distro packaging often uses non-default build and linker flags. The current Makefile cannot be used in the package build process as it will end up rebuilding the binaries with the default flags. This commit introduces install targets which do not depend on the build targets. Distro packages should prefer these if they want to use any non-default flags. NOTE: This commit effectively leaves prior targets unchanged, so users won't notice any difference. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* Merge pull request #5737 from cevich/add_f32OpenShift Merge Robot2020-04-22
|\ | | | | Cirrus: Add support for Fedora 32 beta
| * Cirrus: Add support for Fedora 32Chris Evich2020-04-20
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: More Ubuntu 19 + Fedora 31Chris Evich2020-04-20
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #5909 from abitrolly/patch-2OpenShift Merge Robot2020-04-21
|\ \ | | | | | | gate/README.md Fix link to .cirrus.yml and reword
| * | gate/README.md Fix link to .cirrus.yml and rewordAnatoli Babenia2020-04-21
| |/ | | | | | | Signed-off-by: Anatoli Babenia <anatoli@rainforce.org>
* | Merge pull request #5910 from abitrolly/shared-depsOpenShift Merge Robot2020-04-21
|\ \ | | | | | | Move Fedora 31 dependencies for building podman into separate file
| * | Move Fedora dependencies for building podman into separate fileAnatoli Babenia2020-04-21
| |/ | | | | | | | | | | This ones listed here are actual for Fedora 31. Signed-off-by: Anatoli Babenia <anatoli@rainforce.org>
* / Add support for containers.conf to podmanimagesDaniel J Walsh2020-04-20
|/ | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Log formatter: add BATS summary lineEd Santiago2020-04-17
| | | | | | | | | | | | | | | | | BATS emits a summary line (number of tests passed/failed)... but only on a tty or when run with --pretty! In our CI context, with TAP output, it gives no end summary. Fix that. Keep track of 'ok', 'not ok', and 'skipped', and display the counts at the end. Also: add a regression test. You don't need to review or even read it: it's stark, and I'm not even enabling it for CI because it almost certainly won't run due to missing Perl library modules. It's just something I need on my end. Signed-off-by: Ed Santiago <santiago@redhat.com>
* Cirrus: Fix gate container build failureChris Evich2020-04-15
| | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* logformat: handle apiv2 results, add anchor linksEd Santiago2020-04-15
| | | | | | | | | | | | | | apiv2 tests emit TAP-compliant output; recognize it and highlight it the same way we do BATS tests. Add anchor links to TAP output, so other tools (e.g. cirrus-flake-summarize) can link to particular lines And, remove a "-f" from "wait" in test-apiv2; looks like there's some version of bash used in some CI VM that doesn't grok it. Signed-off-by: Ed Santiago <santiago@redhat.com>
* Bump to v2.0.0-devMatthew Heon2020-04-15
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Bump to v1.9.0-devMatthew Heon2020-04-13
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Bump to v1.9.0-rc1v1.9.0-rc1Matthew Heon2020-04-13
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Fix repos for CentOS 7 RPM buildSagi Shnaidman2020-04-01
| | | | | | CBS repos are gone, so we need a new repos to configure for RPM. Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
* Merge pull request #5670 from cevich/new_imagesOpenShift Merge Robot2020-04-01
|\ | | | | Cirrus: Update VM Images
| * Cirrus: Minor docs updateChris Evich2020-03-30
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #5683 from larsks/bug/rpm-systemd-tagOpenShift Merge Robot2020-03-31
|\ \ | | | | | | add systemd build tag to podman builds
| * | add systemd build tag to podman buildsLars Kellogg-Stedman2020-03-31
| |/ | | | | | | | | | | | | | | | | | | | | Without the systemd build tag, podman will fail with the error "No support for journald logging". This commit adds the `systemd` build tag explicitly, rather than relying on `hack/systemd_tag.sh` (because we're building an rpm and we've explicitly included systemd-devel as a dependency). Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
* / V2 Move varlink homeJhon Honce2020-03-30
|/ | | | | | | | * move cmd/podman/varlink/* to pkg/varlink to support podmanV2 refactor * update Makefile * reformatted all impacted code Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #5368 from cevich/opensuse_ubuntu_packagesOpenShift Merge Robot2020-03-28
|\ | | | | Opensuse openbuild ubuntu + buildah packages
| * Cirrus: Enable future installing buildah packagesChris Evich2020-03-19
| | | | | | | | | | | | | | | | | | Many of the packages required for CI in buildah overlap with libpod. When building new VM images, attempt to source a package list from the buildah repository. If found, also install the listed packages on the VM. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Include packages for buildah CIChris Evich2020-03-19
| | | | | | | | | | | | Also, move some setup steps at VM image build time to save runtime. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Update Ubuntu base imagesChris Evich2020-03-19
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Use opensuse open build Ubuntu packagesChris Evich2020-03-19
| | | | | | | | | | | | This is necessary as the projectatomic PPA is no longer maintained. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #4340 from cevich/libseccomp_updateOpenShift Merge Robot2020-03-28
|\ \ | | | | | | Log libseccomp package version
| * | Cirrus: Log libseccomp package versionChris Evich2020-02-26
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #5479 from cevich/auto_releaseOpenShift Merge Robot2020-03-23
|\ \ \ | | | | | | | | Cirrus: Disable non-docs release processing
| * | | Cirrus: Disable non-docs release processingChris Evich2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Detecting when it's time to upload a release inside Cirrus-CI is really difficult for many automation and human reasons. Disabling it for now until a more robust solution can be implemented Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Add APIV2 service filesDaniel J Walsh2020-03-20
| | | | | | | | | | | | | | | | | | | | | | | | Also fix issue in pods_test.go Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Bump to v1.8.3-devMatthew Heon2020-03-19
| |_|/ |/| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #5480 from vrothberg/auto-updatesOpenShift Merge Robot2020-03-18
|\ \ \ | | | | | | | | auto update containers in systemd units
| * | | auto updatesValentin Rothberg2020-03-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support to auto-update containers running in systemd units as generated with `podman generate systemd --new`. `podman auto-update` looks up containers with a specified "io.containers.autoupdate" label (i.e., the auto-update policy). If the label is present and set to "image", Podman reaches out to the corresponding registry to check if the image has been updated. We consider an image to be updated if the digest in the local storage is different than the one of the remote image. If an image must be updated, Podman pulls it down and restarts the container. Note that the restarting sequence relies on systemd. At container-creation time, Podman looks up the "PODMAN_SYSTEMD_UNIT" environment variables and stores it verbatim in the container's label. This variable is now set by all systemd units generated by `podman-generate-systemd` and is set to `%n` (i.e., the name of systemd unit starting the container). This data is then being used in the auto-update sequence to instruct systemd (via DBUS) to restart the unit and hence to restart the container. Note that this implementation of auto-updates relies on systemd and requires a fully-qualified image reference to be used to create the container. This enforcement is necessary to know which image to actually check and pull. If we used an image ID, we would not know which image to check/pull anymore. Fixes: #3575 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | fix timeout file flakeBrent Baude2020-03-17
|/ / / | | | | | | | | | | | | | | | this is a temporary fix for the flake that has been troubling us. once conmon is in fedora 30 and 31 stable, we can remove this fix. the images will just need to be rebuilt. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Four small CI fixes:Ed Santiago2020-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1) 'podman system info' (in logcollector): has been silently failing in special_testing_rootless, with: logcollector.sh: line 16: podman: command not found Use ./bin/podman instead of just podman; this is probably the right thing to do in the general case anyway 2) logformatter: highlight 'panic:', seen in bindings test: https://storage.googleapis.com/cirrus-ci-5385732420009984-fcae48/artifacts/containers/libpod/6693715108429824/html/integration_test.log.html 3) logformatter: handle Unicode bullet in front of 'Running', seen in bindings test. 4) logformatter: turn down contrast on BATS 'ok' results, for legibility Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | turn off color-mode for bindingsBrent Baude2020-03-12
|/ / | | | | | | | | | | the binding ginkgo tests were using color mode which throws in a bunch of ansi garbage that makes it hard to read the logs Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Bump to v1.8.2-devMatthew Heon2020-03-11
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #5395 from cevich/fix_fedora_minimalOpenShift Merge Robot2020-03-08
|\ \ | | | | | | Cirrus: Fix fedora-minimal mirroring
| * | Cirrus: Fix fedora-minimal mirroringChris Evich2020-03-04
| | | | | | | | | | | | | | | | | | | | | Builds of this dockerfile fail on quay.io due to not being able to pull the base image. Use a fully-qualified FROM name to work around this. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Fix spelling mistakes in code found by codespellDaniel J Walsh2020-03-07
| | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5374 from baude/createOpenShift Merge Robot2020-03-07
|\ \ \ | | | | | | | | add default network for apiv2 create
| * | | add default network for apiv2 createBrent Baude2020-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | during container creation, if no network is provided, we need to add a default value so the container can be later started. use apiv2 container creation for RunTopContainer instead of an exec to the system podman. RunTopContainer now also returns the container id and an error. added a libpod commit endpoint. also, changed the use of the connections and bindings slightly to make it more convenient to write tests. Fixes: 5366 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5359 from TomSweeneyRedHat/dev/tsweeney/fixquayOpenShift Merge Robot2020-03-07
|\ \ \ \ | |/ / / |/| | | Fix upstream dockerfile and add 'by hand' ctrfile
| * | | Fix upstream dockerfile and add 'by hand' ctrfileTomSweeneyRedHat2020-03-05
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The podmanimage/upstream/Dockerfile had two rpms in its build procedure that are no longer available. The atomic-registries has been removed and the md2man has been renamed. In addtion conmon was not being installed and I've added that. I've been using a Containerfile to build or rebuild a specific version of the podmanimage stored in the stable repository with a version tag. As the other Containerfiles have been updated by others, and in case anyone else needs to build it, I've added it to the repo and have also updated the readme.md. FWIW, the builds in the quay.io/podman/upstream have been failing for a while due to missing rpms. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #5039 from cevich/fix_gobin_exit_bugOpenShift Merge Robot2020-03-05
|\ \ \ | |/ / |/| | Cirrus: Fix gate image & false-positive exits
| * | Cirrus: Fix gate image & false-positive exitsChris Evich2020-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A number of scripts relating to tooling used and the gate container image were not exiting upon errors as intended. Coupled with external service unavailability (i.e. downloading golangci-lint) was observed to cause difficult to debug failures. This change corrects the scripts inside/out of the gate container as well as fixes many golang related path consistency problems vs other CI jobs. After this change, all jobs use consistent path names reducing the number of special-case overrides needed. Lastly, I also made a documentation-pass, updating/correcting as needed, including documenting a likely local validation-failure mode, related to `$EPOCH_TEST_COMMIT`. This is dependent on the developers git environment, so documentation is the only possible "fix". Signed-off-by: Chris Evich <cevich@redhat.com>
* | | CI: format cirrus logsEd Santiago2020-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This introduces a new cirrus helper script, logformatter. Usage is: [commands...] | logformatter TEST-NAME It reformats its input into a readable, highlighed, linkable form. Some features: - boring stuff (timestamps, standard podman options) is deemphasized - important stuff (warnings, errors) is emphasized - in-page links to the actual failures - active links to source files - jumps to bottom of page on load, because that's where the errors are. (All errors are linked) Add it to select test commands (integration, system) and add a new artifacts_html, run in the 'always' block, which uploads generated *.log.html into Cirrus; from there we generate a live URL that can be viewed in browser. Unfortunately, due to security concerns in Cirrus, it is not currently possible to make the link a live one. Kludge: add a line of dashes after Restoring images; without this, the first test ("systemd PID 1") has no dashes before it, so logformatter doesn't see it. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | CI: add API v2 testsEd Santiago2020-03-02
|/ / | | | | | | | | | | | | | | | | | | API v2 has been quiet for a few days, and the test script is actually passing. Let's take advantage of this opportunity to get them running in CI. Requires adding a check for cgroupsv2 Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Cirrus: Force runc use in F30Chris Evich2020-02-28
| | | | | | | | | | | | | | | | | | | | | | Suspect crun might be sneaking in during VM image build via podman RPM dependency. Add it to the removal list when building, then also force use of runc at runtime in F30. Also quote all true/false vars to force them as strings instead of booleans (which will become capitalized) Signed-off-by: Chris Evich <cevich@redhat.com>