summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* v2podman attach and execBrent Baude2020-04-05
| | | | | | | | add the ability to attach to a running container. the tunnel side of this is not enabled yet as we have work on the endpoints and plumbing to do yet. add the ability to exec a command in a running container. the tunnel side is also being deferred for same reason. Signed-off-by: Brent Baude <bbaude@redhat.com>
* v2podman container createBrent Baude2020-04-03
| | | | | | create a container in podmanv2 using specgen approach. this is the core implementation and still has quite a bit of code commented out specifically around volumes, devices, and namespaces. need contributions from smes on these parts. Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #5672 from baude/v2saveOpenShift Merge Robot2020-04-03
|\ | | | | podmanv2 save image
| * podmanv2 save imageBrent Baude2020-04-03
| | | | | | | | | | | | add ability to save an image for podman v2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5638 from baude/v2containercheckOpenShift Merge Robot2020-04-03
|\ \ | | | | | | podmanv2 checkpoint and restore
| * | podmanv2 checkpoint and restoreBrent Baude2020-04-03
| | | | | | | | | | | | | | | | | | add the ability to checkpoint and restore containers on v2podman Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5676 from kolyshkin/volume-flags-altOpenShift Merge Robot2020-04-03
|\ \ \ | |_|/ |/| | Fix/improve pkg/storage.InitFSMounts
| * | pkg/spec.InitFSMounts: optimizeKir Kolyshkin2020-04-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of getting mount options from /proc/self/mountinfo, which is very costly to read/parse (and can even be unreliable), let's use statfs(2) to figure out the flags we need. [v2: move getting default options to pkg/util, make it linux-specific] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
| * | pkg/spec.InitFSMounts: fix mount opts in placeKir Kolyshkin2020-04-01
| | | | | | | | | | | | | | | | | | | | | ... rather than create a new slice and then make the caller replace the original with the new one. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
| * | pkg/spec/initFSMounts: fixKir Kolyshkin2020-03-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > $ ./bin/podman run -v /tmp:/tmp alpine true; echo $? > 0 > $ ./bin/podman run -v /tmp:/tmp:ro alpine true; echo $? > 0 > $ ./bin/podman run -v /tmp:/w0w:ro alpine true; echo $? > Error: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"rootfs_linux.go:58: mounting \\\"/tmp\\\" to rootfs \\\"/home/kir/.local/share/containers/storage/overlay/7636ef3650fc91ee4996ccc026532bb3cff7182c0430db662fffb933e0bcadc9/merged\\\" at \\\"/home/kir/.local/share/containers/storage/overlay/7636ef3650fc91ee4996ccc026532bb3cff7182c0430db662fffb933e0bcadc9/merged/w0w\\\" caused \\\"operation not permitted\\\"\"": OCI runtime permission denied error > 126 The last command is not working because in-container mount point is used to search for a parent mount in /proc/self/mountinfo. And yet the following > $ ./bin/podman run -v /tmp:/run/test:ro alpine true; echo $? > 0 still works fine! Here's why: > $ mount | grep -E '/run |/tmp ' > tmpfs on /run type tmpfs (rw,nosuid,nodev,seclabel,mode=755) > tmpfs on /tmp type tmpfs (rw,nosuid,nodev,seclabel) This is the reason why previous commit modified in-container mount point. Fixes: 0f5ae3c5af Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
* | | Merge pull request #5701 from vrothberg/v2-pushOpenShift Merge Robot2020-04-03
|\ \ \ | |_|/ |/| | podmanV2: implement push
| * | podmanV2: implement pushValentin Rothberg2020-04-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Implement `podman-push` and `podman-image-push` for the podmanV2 client. * Tests for `pkg/bindings` are not possible at the time of writing as we don't have a local registry running. * Implement `/images/{name}/push` compat endpoint. Tests are not implemented for this v2 endpoint. It has been tested manually. General note: The auth config extraction from the http header is not implement for push. Since it's not yet supported for other endpoints either, I deferred it to future work. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Fix environment handling from containers.confDaniel J Walsh2020-04-02
|/ / | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5688 from baude/v2importOpenShift Merge Robot2020-04-02
|\ \ | | | | | | podmanv2 import
| * | podmanv2 importBrent Baude2020-04-01
| | | | | | | | | | | | | | | | | | add the ability to import a container image from a container export Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | podmanv2 exportBrent Baude2020-04-01
|/ / | | | | | | | | | | add ability to export a container to a tarball Signed-off-by: Brent Baude <bbaude@redhat.com>
* | podmanv2 loadBrent Baude2020-04-01
| | | | | | | | | | | | | | | | | | | | enable podman load for v2 add reexec into main add systemd build flag to v2 makefile Signed-off-by: Brent Baude <bbaude@redhat.com>
* | V2 podman inspectJhon Honce2020-04-01
| | | | | | | | | | | | | | * Expose podman container inspect * Expose podman image inspect Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5656 from baude/v2imagetagOpenShift Merge Robot2020-04-01
|\ \ | | | | | | podman v2 image tag and untag
| * | podman v2 image tag and untagBrent Baude2020-03-31
| | | | | | | | | | | | | | | | | | add the ability to tag and untag images in podmanv2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | podmanv2 pod psBrent Baude2020-03-31
|/ / | | | | | | | | | | add the ability to list pods in podmanv2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5655 from baude/v2hcrunOpenShift Merge Robot2020-03-31
|\ \ | | | | | | podmanv2 enable healthcheck run
| * | podmanv2 enable healthcheck runBrent Baude2020-03-29
| | | | | | | | | | | | | | | | | | run healthcheck with podmanv2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5675 from vrothberg/v2-pullOpenShift Merge Robot2020-03-31
|\ \ \ | | | | | | | | podmanV2: implement pull
| * | | podmanV2: implement pullValentin Rothberg2020-03-31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement pulling images for the v2 client. What I _really_ don't like is the fact that we are now having a near identical code clone among `pkg/domain/infra/abi` and `pkg/api/handlers/libpod`. Partly because we don't yet have a higher-level pull function and partly because we have redudancy among `pkg/domain` and `pkg/api`. Pull might be a high outlier but I am concerned already by the potential of introducing more redundancy. I'd love to `infra/abi` and `pkg/abi` to really use the same code in the future. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5649 from jwhonce/wip/varlinkOpenShift Merge Robot2020-03-31
|\ \ \ | | | | | | | | V2 Move varlink home
| * | | V2 Move varlink homeJhon Honce2020-03-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * move cmd/podman/varlink/* to pkg/varlink to support podmanV2 refactor * update Makefile * reformatted all impacted code Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Switch to using --time as opposed to --timeout to better match Docker.Daniel J Walsh2020-03-31
| |_|/ |/| | | | | | | | | | | | | | | | | We need to consistently use --time rather then --timeout throughout the code. Fix locations where timeout defaults are not set correctly as well. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | fix more swagger inconsistenciesEd Santiago2020-03-30
|/ / | | | | | | | | | | I'm getting really tired of doing this manually. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #5639 from vrothberg/v2-pod-topOpenShift Merge Robot2020-03-30
|\ \ | |/ |/| V2 pod top
| * swagger: top: remove "Docker" from the identifiersValentin Rothberg2020-03-28
| | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * podmanv2: implement pod topValentin Rothberg2020-03-28
| | | | | | | | | | | | Implement `podman pod top` for podmanV2. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * v2 api: implement pods top endpointValentin Rothberg2020-03-28
| | | | | | | | | | | | | | Note that this commit does not add tests for the pod-top endpoint. They will be added in a later change. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | podmanv2 commitBrent Baude2020-03-28
|/ | | | | | add commit of a container to a container-image Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #4698 from rhatdan/containers.confOpenShift Merge Robot2020-03-27
|\ | | | | Add support for containers.conf
| * Add support for containers.confDaniel J Walsh2020-03-27
| | | | | | | | | | | | | | vendor in c/common config pkg for containers.conf Signed-off-by: Qi Wang qiwan@redhat.com Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5642 from tylarb/5610_play_kube_networkOpenShift Merge Robot2020-03-27
|\ \ | |/ |/| Sanitize port parsing for pods in play kube
| * Sanitize port parsing for pods in play kubeTyler Ramer2020-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The logic used in parsing the ports to be utilized in a kubenetes api defined pod did not fully adhere to the kubenetes spec, nor did it map well to a podman context. This fix sanitizes the input of container ports to meet the following rules: - A defined containerPort with no defined hostPort does nothing in a podman context, or is informational. This is line with [usage in Kubernetes.](https://github.com/kubernetes/kubernetes/issues/4332) - A defined hostPort with no defined containerPort acts like a publish [hostPort]:[hostPort] - A defined containerPort and defined hostPort works like it does in kubernetes, as in a publish [hostPort]:[containerPort] Addresses https://github.com/containers/libpod/issues/5610 Signed-off-by: Tyler Ramer <tyaramer@gmail.com>
* | Merge pull request #5632 from jwhonce/wip/imagesOpenShift Merge Robot2020-03-27
|\ \ | | | | | | V2 podman image prune
| * | V2 podman image pruneJhon Honce2020-03-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixed header for `podman image ls` * Implemented prune `all` flag, preserved filter method for backwards capability * Updated binding tests Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | podmanv2 pod create using podspecgenBrent Baude2020-03-27
| | | | | | | | | | | | | | | | | | | | | | | | using the factory approach similar to container, we now create pods based on a pod spec generator. wired up the podmanv2 pod create command, podcreatewithspec binding, simple binding test, and apiv2 endpoint. also included some code refactoring as it introduced as easy circular import. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | podmanV2: implement topValentin Rothberg2020-03-27
|/ / | | | | | | | | | | Implement the `top` command for podmanV2. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | podmanv2 container inspectBrent Baude2020-03-26
| | | | | | | | | | | | add ability to inspect a container Signed-off-by: Brent Baude <bbaude@redhat.com>
* | podmanv2 pod subcommandsBrent Baude2020-03-26
| | | | | | | | | | | | add pod kill, pause, restart, rm, start, stop, and unpause Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5573 from mheon/add_basic_exec_endpointsOpenShift Merge Robot2020-03-26
|\ \ | | | | | | Implement APIv2 Exec Create and Inspect Endpoints
| * | Add bindings for Container Exec Create + InspectMatthew Heon2020-03-26
| | | | | | | | | | | | | | | | | | | | | Also adds some basic tests for these two. More tests are needed but will have to wait for state to be finished. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Implement APIv2 Exec Create and Inspect EndpointsMatthew Heon2020-03-23
| | | | | | | | | | | | | | | | | | Start and Resize require further implementation work. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #5627 from baude/apiv2createnetOpenShift Merge Robot2020-03-26
|\ \ \ | | | | | | | | apiv2 add default network in specgen
| * | | apiv2 add default network in specgenBrent Baude2020-03-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when a network is not provided, we should set a default mode based on rootless or rootfull. Fixes: #5366 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5615 from jwhonce/wip/imagesOpenShift Merge Robot2020-03-26
|\ \ \ \ | |/ / / |/| | | V2 podman image rm | podman rmi [IMAGE]