summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* Sanitize port parsing for pods in play kubeTyler Ramer2020-03-27
| | | | | | | | | | | | | | | | | | | | | The logic used in parsing the ports to be utilized in a kubenetes api defined pod did not fully adhere to the kubenetes spec, nor did it map well to a podman context. This fix sanitizes the input of container ports to meet the following rules: - A defined containerPort with no defined hostPort does nothing in a podman context, or is informational. This is line with [usage in Kubernetes.](https://github.com/kubernetes/kubernetes/issues/4332) - A defined hostPort with no defined containerPort acts like a publish [hostPort]:[hostPort] - A defined containerPort and defined hostPort works like it does in kubernetes, as in a publish [hostPort]:[containerPort] Addresses https://github.com/containers/libpod/issues/5610 Signed-off-by: Tyler Ramer <tyaramer@gmail.com>
* Merge pull request #5604 from jwhonce/wip/imagesOpenShift Merge Robot2020-03-25
|\ | | | | V2 podman images/image list
| * V2 podman images/image listJhon Honce2020-03-24
| | | | | | | | | | | | | | | | | | | | * Updated entities to support flags/options * Updated bindings caused by entities changes * Removed handlers.ImageSummary in favor of entities.ImageSummary * Introduced StringSet() container object to simply error checking Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | podmanv2 volumesBrent Baude2020-03-24
|/ | | | | | add volume commands: create, inspect, ls, prune, and rm Signed-off-by: Brent Baude <bbaude@redhat.com>
* Combine GlobalFlags and EngineFlags into EngineOptionsJhon Honce2020-03-24
| | | | | | | * EngineOptions obtained in command via `opt, err := registry.Options(cmd)` Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #5589 from giuseppe/rootlessport-use-unixOpenShift Merge Robot2020-03-24
|\ | | | | rootlessport: use x/sys/unix instead of syscall
| * rootlessport: use x/sys/unix instead of syscallGiuseppe Scrivano2020-03-24
| | | | | | | | | | | | | | | | Dup2 is not defined on arm64 in the syscall package. Closes: https://github.com/containers/libpod/issues/5587 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Complete podmanV2 history commandJhon Honce2020-03-24
| | | | | | | | | | | | * All format options now implemented Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5598 from marusak/doc_commit_endpointOpenShift Merge Robot2020-03-24
|\ \ | |/ |/| Correctly document libpod commit endpoint
| * Correctly document libpod commit endpointMatej Marusak2020-03-24
| | | | | | | | | | | | In #5588 it was forgotten and documentation still points to `/commit`. Signed-off-by: Matej Marusak <mmarusak@redhat.com>
* | Merge pull request #5581 from baude/v2containersOpenShift Merge Robot2020-03-24
|\ \ | |/ |/| podmanv2 add core container commands
| * podmanv2 add core container commandsBrent Baude2020-03-22
| | | | | | | | | | | | add core container commands for podmanv2: kill, pause, restart, rm, stop, unpause Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5560 from QiWang19/remote_cedsOpenShift Merge Robot2020-03-23
|\ \ | | | | | | Use creds form PullImage remote
| * | Use creds form PullImage remoteQi Wang2020-03-19
| | | | | | | | | | | | | | | | | | | | | fix #5511 Adds creds argument to PullImage API and Enables podman-remote to pull image with --creds Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | apiv2 container commit for libpodBrent Baude2020-03-23
| | | | | | | | | | | | | | | | | | | | | | | | add an endpoint for a libpod specific commit. add the abilility to define the format. also update documentation accordingly. Fixes: #5586 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5436 from QiWang19/rm_created_ctrOpenShift Merge Robot2020-03-23
|\ \ \ | | | | | | | | container prune remove state created, configured
| * | | container prune remove state created, configuredQi Wang2020-03-10
| | | | | | | | | | | | | | | | | | | | | | | | podman container prune should remove containers with state Created, Configured to be compatible with docker Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #5567 from rhatdan/serviceOpenShift Merge Robot2020-03-23
|\ \ \ \ | | | | | | | | | | Add APIV2 service files
| * | | | Add APIV2 service filesDaniel J Walsh2020-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also fix issue in pods_test.go Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #5552 from giuseppe/rootlessport-handle-sigpipeOpenShift Merge Robot2020-03-22
|\ \ \ \ \ | |_|_|_|/ |/| | | | rootlessport: handle SIGPIPE
| * | | | rootlessport: handle SIGPIPEGiuseppe Scrivano2020-03-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when a sigpipe is received the stdout/stderr pipe was closed, so reopen them with /dev/null. Closes: https://github.com/containers/libpod/issues/5541 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #5579 from mtrmac/macOS-unit-testsOpenShift Merge Robot2020-03-21
|\ \ \ \ \ | | | | | | | | | | | | Make macOS unit tests runnable
| * | | | | Add stubs for pkg/adapter/terminal_linux.goMiloslav Trmač2020-03-21
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | | | | Only run TestGetImageConfigStopSignal on LinuxMiloslav Trmač2020-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... because the implementation requires Linux-only pkg/signal Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | | | | Fix the pkg/specgen/SpecGenerator.getSeccompConfig stubMiloslav Trmač2020-03-20
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* | | | | | Merge pull request #5577 from baude/v2volumecreateOpenShift Merge Robot2020-03-21
|\ \ \ \ \ \ | | | | | | | | | | | | | | podmanv2 volume create
| * | | | | | podmanv2 volume createBrent Baude2020-03-20
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add volume create Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5578 from baude/v2podexistsOpenShift Merge Robot2020-03-21
|\ \ \ \ \ \ | | | | | | | | | | | | | | podmanv2 pod exists
| * | | | | | podmanv2 pod existsBrent Baude2020-03-20
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add pod exists for podman v2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5555 from mheon/pod_specgenOpenShift Merge Robot2020-03-21
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Add basic structure of a spec generator for pods
| * | | | | Add basic structure of a spec generator for podsMatthew Heon2020-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be used for remote creation of pods initially. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | | [CI:DOCS]fix type issue in pod binding testBrent Baude2020-03-20
| | |/ / / | |/| | | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | podmanv2 enable remote waitBrent Baude2020-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | enable remote container wait with condition Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | fix remote connection use of contextBrent Baude2020-03-20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | use boolreport for containerexists responseBrent Baude2020-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in the case of exists, use a boolreport structure so that responses can be consistent pointer and error Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | podmanv2 container exists|waitBrent Baude2020-03-20
|/ / / / | | | | | | | | | | | | | | | | | | | | enable container exists and wait for podmanv2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5525 from baude/apiv2bindinglogsOpenShift Merge Robot2020-03-19
|\ \ \ \ | | | | | | | | | | apiv2 add bindings for logs|events
| * | | | apiv2 add bindings for logs|eventsBrent Baude2020-03-19
| |/ / / | | | | | | | | | | | | | | | | | | | | add go-bindings for logs and events. tests were also added. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5088 from mheon/begin_exec_reworkOpenShift Merge Robot2020-03-19
|\ \ \ \ | | | | | | | | | | Begin exec rework
| * | | | Add structure for new exec session tracking to DBMatthew Heon2020-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of the rework of exec sessions, we need to address them independently of containers. In the new API, we need to be able to fetch them by their ID, regardless of what container they are associated with. Unfortunately, our existing exec sessions are tied to individual containers; there's no way to tell what container a session belongs to and retrieve it without getting every exec session for every container. This adds a pointer to the container an exec session is associated with to the database. The sessions themselves are still stored in the container. Exec-related APIs have been restructured to work with the new database representation. The originally monolithic API has been split into a number of smaller calls to allow more fine-grained control of lifecycle. Support for legacy exec sessions has been retained, but in a deprecated fashion; we should remove this in a few releases. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #5546 from jwhonce/wip/entitiesOpenShift Merge Robot2020-03-19
|\ \ \ \ \ | | | | | | | | | | | | V2 podman command
| * | | | | V2 podman commandJhon Honce2020-03-18
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | Merge pull request #5554 from baude/compatfixOpenShift Merge Robot2020-03-19
|\ \ \ \ \ \ | | | | | | | | | | | | | | fix reported compat issues
| * | | | | | fix reported compat issuesBrent Baude2020-03-19
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | honor -1 in in list containers for compatibility mode. it is commonly used to indicate no limit. change the json id parameter to Id in container create. Fixes: #5553 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5445 from sujil02/podFilter-newOpenShift Merge Robot2020-03-19
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Filter pods through pod list api
| * | | | | Filter pods through pod list apiSujil022020-03-17
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored current filter pods flow through the shared pod functions so filter pod functionalities can be shared between api and cmd. Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | | rootless: fix usage with hidepid=1Giuseppe Scrivano2020-03-19
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when /proc is mounted with hidepid=1 a process doesn't see processes from the outer user namespace. This causes an issue reading the cmdline from the parent process. To address it, always read the command line from /proc/self instead of using /proc/PARENT_PID. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #5540 from jwhonce/issues/5531OpenShift Merge Robot2020-03-18
|\ \ \ \ | | | | | | | | | | Reduce CPU usage when --timeout=0
| * | | | Reduce CPU usage when --timeout=0Jhon Honce2020-03-18
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add second go routine for when a Timer is not needed. * goimports updated some project files Fixes #5531 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #5544 from baude/apiv2serveswaggerOpenShift Merge Robot2020-03-18
|\ \ \ \ | | | | | | | | | | serve swagger when present