summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* Merge pull request #9509 from mlegenovic/masterOpenShift Merge Robot2021-03-01
|\ | | | | Correct compat images/create?fromImage response
| * Correct compat images/create?fromImage responseMilivoje Legenovic2021-02-26
| | | | | | | | Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
* | Merge pull request #9505 from TristanCacqueray/masterOpenShift Merge Robot2021-02-26
|\ \ | | | | | | [CI:DOCS] swagger: removes the schema type for PodSpecGenerator $ref
| * | swagger: removes the schema type for PodSpecGenerator $refTristan Cacqueray2021-02-24
| |/ | | | | | | | | | | | | | | | | | | | | When using a $ref, the type is ignored and it can confuse the openapi codegen and make it fails with this error: attribute paths.'/libpod/pods/create'(post).[create].type is unexpected This change removes the schema type attribute. Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
* / prune remotecommand dependencybaude2021-02-25
|/ | | | | | | | | | | prune a dependency that was only being used for a simple struct. Should correct checksum issue on tarballs [NO TESTS NEEDED] Fixes: #9355 Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #9485 from vrothberg/fix-9479OpenShift Merge Robot2021-02-23
|\ | | | | container removal: handle already removed containers
| * container removal: handle already removed containersValentin Rothberg2021-02-23
| | | | | | | | | | | | | | | | | | | | | | | | Since commit d54478d8eaec, a container's lock is released before attempting to stop it via the OCI runtime. This opened the window for various kinds of race conditions. One of them led to #9479 where the removal+cleanup sequences of a `run --rm` session overlapped with `rm -af`. Make both execution paths more robust by handling the case of an already removed container. Fixes: #9479 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Add U volume flag to chown source volumesEduardo Vega2021-02-22
|/ | | | Signed-off-by: Eduardo Vega <edvegavalerio@gmail.com>
* Merge pull request #9480 from jmguzik/replace-nil-with-braces-network-resourceOpenShift Merge Robot2021-02-22
|\ | | | | [NO TESTS NEEDED] Replace Labels and Options nulls with {} in NetworkResource
| * Replace Labels and Options nulls with {} in NetworkResourceJakub Guzik2021-02-23
| | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | Merge pull request #9464 from giuseppe/fix-cgroupv1-statsOpenShift Merge Robot2021-02-22
|\ \ | | | | | | cgroup: change cgroup deletion logic on v1
| * | cgroup: change cgroup deletion logic on v1Giuseppe Scrivano2021-02-22
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | do not raise an error if the cgroup exists at least on one controller. Previously it expected the cgroup to exists under all the controllers. [NO TESTS NEEDED] Closes: https://github.com/containers/podman/issues/9252 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #9456 from matejvasek/make_internalOpenShift Merge Robot2021-02-22
|\ \ | | | | | | Make binding util internal
| * | [NO TESTS NEEDED] Make binding util internalMatej Vasek2021-02-22
| | | | | | | | | | | | | | | | | | The functions are supposed to be called only from generated code Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #9445 from jmguzik/no-header-info-for-systemd-generationOpenShift Merge Robot2021-02-22
|\ \ \ | | | | | | | | No header info for systemd generation
| * | | --no-header flag implementation for generate systemdJakub Guzik2021-02-22
| | | | | | | | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | | Merge pull request #9117 from tmds/swagger_missing_schema_propertiesOpenShift Merge Robot2021-02-22
|\ \ \ \ | |_|/ / |/| | | [NO TESTS NEEDED] swagger: add missing schema properties
| * | | swagger: add missing schema propertiesTom Deseyn2021-02-22
| | |/ | |/| | | | | | | | | | | | | NO_TESTS_NEEDED Signed-off-by: Tom Deseyn <tom.deseyn@gmail.com>
* | | Merge pull request #9275 from rhatdan/buildOpenShift Merge Robot2021-02-22
|\ \ \ | | | | | | | | Add missing params for podman-remote build
| * | | Add missing params for podman-remote buildDaniel J Walsh2021-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/9290 Currently we still have hard coded --isolation=chroot for podman-remote build. Implement missing arguments for podman build Implements --jobs, --disable-compression, --excludes Fixes: MaxPullPushRetries RetryDuration Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | bump go module to v3Valentin Rothberg2021-02-22
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | We missed bumping the go module, so let's do it now :) * Automated go code with github.com/sirkon/go-imports-rename * Manually via `vgrep podman/v2` the rest Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #9436 from jonas-schievink/patch-1OpenShift Merge Robot2021-02-21
|\ \ \ | |_|/ |/| | [NO TESTS NEEDED] Log working dir when chdir fails
| * | Log working dir when chdir failsJonas Schievink2021-02-19
| | | | | | | | | | | | Signed-off-by: Jonas Schievink <jonasschievink@gmail.com>
* | | Merge pull request #9339 from matejvasek/update_wait_swaggerOpenShift Merge Robot2021-02-19
|\ \ \ | |/ / |/| | [CI:DOCS] Update swagger doc for libpod container wait
| * | [CI:DOCS] [NO TESTS NEEDED] Update swagger doc for libpod container waitMatej Vasek2021-02-18
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #9434 from jmguzik/rootless-linux-bugOpenShift Merge Robot2021-02-19
|\ \ \ | | | | | | | | [NO TESTS NEEDED] leak fix in rootless_linux.c fcn can_use_shortcut
| * | | leak fix in rootless_linux.c fcn can_use_shortcutJakub Guzik2021-02-19
| |/ / | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | Merge pull request #9428 from vrothberg/cp-content-fixOpenShift Merge Robot2021-02-19
|\ \ \ | |/ / |/| | cp: treat "." and "/." correctly
| * | cp: treat "." and "/." correctlyValentin Rothberg2021-02-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure to treat "." and "/." correctly. Both cases imply to copy the contents of a directory in contrast to the directory. This implies to unset the KeepDirectoryNames options of the copiah package. Previously, the code was performing a simple string suffix check which is not enough since it would match files and directories ending with ".". Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Don't switch on a single caseNikolay Edigaryev2021-02-18
| | | | | | | | | | | | Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>
* | | bindings: support simple types that implement fmt.Stringer interfaceNikolay Edigaryev2021-02-18
| | | | | | | | | | | | Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>
* | | API: fix libpod's container wait endpoint condition conversionNikolay Edigaryev2021-02-18
|/ / | | | | | | Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>
* | Merge pull request #9404 from rhatdan/entrypointOpenShift Merge Robot2021-02-17
|\ \ | | | | | | Ignore entrypoint=[""]
| * | Ignore entrypoint=[\"\"]Daniel J Walsh2021-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We recieved an issue with an image that was built with entrypoint=[""] This blows up on Podman, but works on Docker. When we setup the OCI Runtime, we should drop entrypoint if it is == [""] https://github.com/containers/podman/issues/9377 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #9407 from giuseppe/downgrade-warning-to-debugOpenShift Merge Robot2021-02-17
|\ \ \ | | | | | | | | [NO TEST NEEDED] infra: downgrade warning to debug
| * | | infra: downgrade warning to debugGiuseppe Scrivano2021-02-17
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | if the current process could not be moved to a different systemd cgroup do not raise a warning but debug message. [NO TESTS NEEDED] Closes: https://github.com/containers/podman/issues/9353 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* / / Add missing early returns in compat APIRiyad Preukschas2021-02-16
|/ / | | | | | | | | | | [NO TESTS NEEDED] Signed-off-by: Riyad Preukschas <riyad@informatik.uni-bremen.de>
* | podman kill should report rawInput not container idDaniel J Walsh2021-02-16
| | | | | | | | | | | | | | Docker always reports back the users input, not the full id, we should do the same. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #9396 from rhatdan/stopOpenShift Merge Robot2021-02-16
|\ \ | | | | | | When stopping a container, print rawInput
| * | When stopping a container, print rawInputDaniel J Walsh2021-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we stop a container we are printing the full id, this does not match Docker behaviour or the start behavior. We should be printing the users rawInput when we successfully stop the container. Fixes: https://github.com/containers/podman/issues/9386 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #9397 from vrothberg/fix-9232OpenShift Merge Robot2021-02-16
|\ \ \ | | | | | | | | images/create: always pull image
| * | | images/create: always pull imageValentin Rothberg2021-02-16
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | The `images/create` endpoint should always attempt to pull a newer image. Previously, the local images was used which is not compatible with Docker and caused issues in the Gitlab CI. Fixes: #9232 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #9369 from vrothberg/startup-errorsOpenShift Merge Robot2021-02-16
|\ \ \ | |/ / |/| | correct startup error message
| * | correct startup error messageValentin Rothberg2021-02-16
| |/ | | | | | | | | | | | | | | | | | | | | | | | | The error message when failing to create an image engine unconditionally pointed to the Podman socket which is quite confusing when running locally. Move the error message to the point where the first ping to the service fails. [NO TESTS NEEDED] Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* / Fix broken podman generate systemd --new with podsPaul Holzinger2021-02-16
|/ | | | | | | | | | | The unit generation accidentally escaped the %t in the pod id file path. This is a regression caused by #9178. This was not caught by the tests because the test itself was wrong. It used a full path instead of the systemd variable %t like the actual code does. Fixes #9373 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* Merge pull request #9348 from matejvasek/refactor_gen_codeOpenShift Merge Robot2021-02-15
|\ | | | | Refactor generated code
| * [NO TESTS NEEDED] Refactor generated codeMatej Vasek2021-02-14
| | | | | | | | | | | | Extracted common functionality to util function. Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | Merge pull request #9342 from Luap99/lintOpenShift Merge Robot2021-02-13
|\ \ | | | | | | Enable more golangci-lint linters
| * | Enable more golangci-lint lintersPaul Holzinger2021-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleanup the golangci.yml file and enable more linters. `pkg/spec` and `iopodman.io` is history. The vendor directory is excluded by default. The dependencies dir was listed twice. Fix the reported problems in `pkg/specgen` because that was also excluded by `pkg/spec`. Enable the structcheck, typecheck, varcheck, deadcode and depguard linters. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Fix superfluous response.WriteHeader call in WaitContainerLibpod()Nikolay Edigaryev2021-02-12
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | When the query decoding fails at the beginning of WaitContainerLibpod(), the Error() sets the header but doesn't returns after that. This causes the execution flow to reach the WriteResponse() at the end of WaitContainerLibpod(), which attempts to set another header, thus causing the following error: http: superfluous response.WriteHeader call from github.com/containers/podman/pkg/api/handlers/utils.WriteResponse (handler.go:124) [NO TESTS NEEDED] Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-15 07:00:02 +0000