summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* Merge pull request #5976 from QiWang19/manifest-add-osOpenShift Merge Robot2020-04-27
|\ | | | | Add --os to manifest add
| * Add --os to manifest addQi Wang2020-04-24
| | | | | | | | | | | | Add --os to manifest add for overriding the os field. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | Enable pod inspect integration testSujil022020-04-26
| | | | | | | | | | | | | | | | Enable pod inspect integration test Get rid of libpod pod inspect references Remove libpod PodInspect struct. Signed-off-by: Sujil02 <sushah@redhat.com>
* | Enable pod ps integration testsBrent Baude2020-04-25
| | | | | | | | | | | | | | | | Enable integration tests for pod ps. In addition, fixed bug where output was still using slice go template routines and would fail when no infra container was present. Added integration test to prevent future regressions. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5971 from giuseppe/fix-userns-testsOpenShift Merge Robot2020-04-24
|\ \ | | | | | | v2, podman: fix and enable all run_userns_test.go tests
| * | podman: assume user namespace if there are mappingsGiuseppe Scrivano2020-04-24
| | | | | | | | | | | | | | | | | | | | | if some mappings are specified, assume there is a private user namespace. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | podman: implement userns=keep-idGiuseppe Scrivano2020-04-24
| | | | | | | | | | | | | | | | | | | | | add missing implementation for userns=keep-id and enable the user namespaces tests. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5974 from giuseppe/fix-initOpenShift Merge Robot2020-04-24
|\ \ \ | |_|/ |/| | [v2] containers, init: skip invalid state errors with --all
| * | containers, init: skip invalid state errors with --allGiuseppe Scrivano2020-04-24
| |/ | | | | | | | | | | reintroduce the same check that exists in v1.9. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #5967 from giuseppe/run-test-fixesOpenShift Merge Robot2020-04-24
|\ \ | | | | | | v2, tests: fix various run_test.go failures
| * | podman: add support for --rootfsGiuseppe Scrivano2020-04-24
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | specgen: fix error messageGiuseppe Scrivano2020-04-24
| | | | | | | | | | | | | | | | | | the check is correct but the error message was stating the opposite. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | create: move validate after setting default nsGiuseppe Scrivano2020-04-24
| |/ | | | | | | | | | | validate the configuration only after we set the default namespaces. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Do not join pod namespaces without an infra ctrMatthew Heon2020-04-24
| | | | | | | | | | | | | | | | | | | | | | We do not want to join pod namespaces if no infra container is present. A pod may claim it shares namespaces without an infra container (I'll take an action item to fix that - it really should not be allowed), which was tripping up our default namespace code and forcing us to try and join the namespaces of the nonexistant infra container. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Fix SELinux functions names to not be repetitiveDaniel J Walsh2020-04-23
|/ | | | | | | Since functions are now in an selinux subpackage, they should not start with SELinux Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #5933 from giuseppe/fix-namespacesOpenShift Merge Robot2020-04-23
|\ | | | | podman, v2: handle namespaces specified on the CLI
| * podman: handle namespaces specified on the CLIGiuseppe Scrivano2020-04-23
| | | | | | | | | | | | | | and handle differently the user namespace as it supports additional options. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * pkg: fix shmsize error messageGiuseppe Scrivano2020-04-23
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #5946 from jwhonce/wip/shutdownOpenShift Merge Robot2020-04-23
|\ \ | |/ |/| V2 restore libpod.Shutdown() when exiting podman commands
| * V2 restore libpod.Shutdown() when exiting podman commandsJhon Honce2020-04-22
| | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5843 from QiWang19/manifest_createOpenShift Merge Robot2020-04-23
|\ \ | | | | | | manifest create,add,inspect
| * | manifest create,add,inspectQi Wang2020-04-22
| | | | | | | | | | | | | | | | | | Implememts manifest subcommands create, add, inspect. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Stop wrapping pull messagesDaniel J Walsh2020-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The length and size of our error messages on failure to pull is huge. This patch at least eliminates some of the wrapping. But I think eventually we need to look at containers/image and see if we can modify the error messages to something a little more human friendly. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | V2 Restore rmi testsJhon Honce2020-04-22
| | | | | | | | | | | | | | | | | | | | | * Introduced define.ErrImageInUse to assist in determining the exit code without resorting string searches. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #5942 from mheon/volume_flagsOpenShift Merge Robot2020-04-22
|\ \ \ | |_|/ |/| | Enable basic volumes support in Podmanv2
| * | Enable basic volumes support in Podmanv2Matthew Heon2020-04-22
| | | | | | | | | | | | | | | | | | | | | | | | This enables the --volume, --mount, and --tmpfs flags in Podmanv2. It does not enable init-related flags, image volumes, and --volumes-from. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #5936 from rhatdan/selinux1OpenShift Merge Robot2020-04-22
|\ \ \ | |_|/ |/| | Move selinux labeling support from pkg/util to pkg/selinux
| * | Move selinux labeling support from pkg/util to pkg/selinuxDaniel J Walsh2020-04-22
| |/ | | | | | | | | | | | | The goal here is to make the package less heavy and not overload the pkg/util. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5930 from jwhonce/issues/5765OpenShift Merge Robot2020-04-22
|\ \ | | | | | | Instrumentation to answer #5765
| * | Instrumentation to answer #5765Jhon Honce2020-04-22
| |/ | | | | | | | | | | * currently wired to localhost:8888 to prevent access from off machine Signed-off-by: Jhon Honce <jhonce@redhat.com>
* / Fix integration tests for untagBrent Baude2020-04-22
|/ | | | | Signed-off-by: Brent Baude <bbaude@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #5916 from giuseppe/userns-autoOpenShift Merge Robot2020-04-21
|\ | | | | v2, podman: plug --userns=auto
| * v2, podman: plug --userns=autoGiuseppe Scrivano2020-04-21
| | | | | | | | | | | | --userns=auto tests pass now. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Modify namespace generation code for specgenMatthew Heon2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | Namespaces have now been changed to properly handle all cases. Spec handling code for namespaces was consolidated in a single function. Still missing: - Image ports - Pod namespaces likely still broken in Podmanv2 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5900 from baude/v2cpOpenShift Merge Robot2020-04-21
|\ \ | | | | | | podmanv2 cp
| * | podmanv2 cpBrent Baude2020-04-21
| | | | | | | | | | | | | | | | | | enable podman to copy files between container and host, local mode only. this is a straight port of v1 code to v2. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5921 from baude/v2imageepOpenShift Merge Robot2020-04-21
|\ \ \ | | | | | | | | add entrypoint from image where needed
| * | | add entrypoint from image where neededBrent Baude2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | if the image specifies both the image and entrypoint, we need to account for that and preprend the entrypoint to the command. this only happens if no user command and entrypoint were supplied. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5912 from giuseppe/v2-rlimitsOpenShift Merge Robot2020-04-21
|\ \ \ \ | |_|/ / |/| | | v2, pkg: implement rlimits
| * | | pkg: implement rlimitsGiuseppe Scrivano2020-04-21
| | |/ | |/| | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | v2podman portBrent Baude2020-04-21
| |/ |/| | | | | | | | | add port command to podman. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5913 from rhatdan/v2OpenShift Merge Robot2020-04-21
|\ \ | | | | | | More fixes for podman create tests
| * | Handle annotations passed in via the clientDaniel J Walsh2020-04-21
| | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5647 from rhatdan/containers.confOpenShift Merge Robot2020-04-21
|\ \ \ | |/ / |/| | Update podmanV2 to use containers.conf
| * | Update podman to use containers.confDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | Add more default options parsing Switch to using --time as opposed to --timeout to better match Docker. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5875 from rhatdan/networkOpenShift Merge Robot2020-04-21
|\ \ \ | | | | | | | | Cleanup network option parsing
| * | | Cleanup network option parsingDaniel J Walsh2020-04-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were not handling the parsing of --ip. This pr adds validation checks and now will support the flag. Move validation to the actual parsing of the network flags. We should only parse the dns flags if the user changed them. We don't want to pass default options if set in containers.conf to the server. Potential for duplicating defaults. Add support for --dns-opt flag passing Begin handling of --network flag, although we don't have a way right now to translate a string into a specgen.Namespace. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | podman rmi: refactor logicValentin Rothberg2020-04-21
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While this commit was initially meant to fix #5847, it has turned into a bigger refactoring which I did not manage to break into smaller pieces: * Fix #5847 by refactoring the image-removal logic. * Make the api handler for image-removal use the ABI code. This way, both (i.e., ABI and Tunnel) end up using the same code. Achieving this code share required to move some code around to prevent circular dependencies. * Everything in pkg/api (excluding pkg/api/types) must now only be accessed from code using `ABISupport`. * Avoid imports from entities on handlers to prevent circular dependencies. * Move `podman system service` logic into `cmd` to prevent circular dependencies - it depends on pkg/api. * Also remove the build header from infra/abi files. It will otherwise confuse swagger and other tools; errors we cannot fix as go doesn't expose a build-tag env variable. Fixes: #5847 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5883 from abitrolly/patch-3OpenShift Merge Robot2020-04-20
|\ \ \ | | | | | | | | Return labes in API (fixes #5882)
| * | | Return labes in API (fixes #5882)Anatoli Babenia2020-04-20
| |/ / | | | | | | | | | Signed-off-by: Anatoli Babenia <anatoli@rainforce.org>