summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* Merge pull request #9593 from vrothberg/cp-tmpOpenShift Merge Robot2021-03-05
|\ | | | | podman cp: support copying on tmpfs mounts
| * podman cp: support copying on tmpfs mountsValentin Rothberg2021-03-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Traditionally, the path resolution for containers has been resolved on the *host*; relative to the container's mount point or relative to specified bind mounts or volumes. While this works nicely for non-running containers, it poses a problem for running ones. In that case, certain kinds of mounts (e.g., tmpfs) will not resolve correctly. A tmpfs is held in memory and hence cannot be resolved relatively to the container's mount point. A copy operation will succeed but the data will not show up inside the container. To support these kinds of mounts, we need to join the *running* container's mount namespace (and PID namespace) when copying. Note that this change implies moving the copy and stat logic into `libpod` since we need to keep the container locked to avoid race conditions. The immediate benefit is that all logic is now inside `libpod`; the code isn't scattered anymore. Further note that Docker does not support copying to tmpfs mounts. Tests have been extended to cover *both* path resolutions for running and created containers. New tests have been added to exercise the tmpfs-mount case. For the record: Some tests could be improved by using `start -a` instead of a start-exec sequence. Unfortunately, `start -a` is flaky in the CI which forced me to use the more expensive start-exec option. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #9550 from baude/issue9517OpenShift Merge Robot2021-03-04
|\ \ | | | | | | Support label type dict on compat build
| * | Support label type dict on compat buildbaude2021-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | The compatibility endpoint for build labels should be of type dict (not list). For backwards compatibility, we support both. Fixes: #9517 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #9617 from vrothberg/fix-9588OpenShift Merge Robot2021-03-04
|\ \ \ | | | | | | | | image removal: ignore unknown-layer errors
| * | | image removal: ignore unknown-layer errorsValentin Rothberg2021-03-04
| | |/ | |/| | | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] as I have absolutely no idea how to force a reliable reproducer. Fixes: #9588 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* / | Use version package to track all versionsJhon Honce2021-03-03
|/ / | | | | | | | | | | | | | | | | | | | | | | * Server, bindings, and CLI all now pull version information from version package. * Current /libpod API version slaved to podman/libpod Version * Bindings validate against libpod API Minimal version * Remove pkg/bindings/bindings.go and updated tests Fixes: #9207 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #9536 from jmguzik/enable-cgroupsv2-sec-optsOpenShift Merge Robot2021-03-03
|\ \ | | | | | | Enable cgroupsv2 rw mount via security-opt unmask
| * | Enable cgroupsv2 rw mount via security-opt unmaskJakub Guzik2021-02-28
| | | | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | Merge pull request #9581 from baude/issue9529OpenShift Merge Robot2021-03-03
|\ \ \ | | | | | | | | Add network summary to compat ps
| * | | Add network summary to compat psbaude2021-03-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The compatibility endpoint for listing containers should have the summarized network configuration with it. Fixes: #9529 Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #9583 from ashley-cui/secOpenShift Merge Robot2021-03-03
|\ \ \ \ | | | | | | | | | | Add version field to secret compat list/inspect api
| * | | | Add version field to secret compat list/inspect apiAshley Cui2021-03-02
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Docker api expects secrets endpoint to have a version field. So, the version field is added into the compat endpoint only. The version field is always 1, since Docker uses the version to keep track of updates to the secret, and currently we cannot update a secret. Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Merge pull request #9580 from rhatdan/timestampDaniel J Walsh2021-03-03
|\ \ \ \ | | | | | | | | | | Fix support for podman build --timestamp
| * | | | Fix support for podman build --timestampDaniel J Walsh2021-03-02
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently podman is ignoreing the build --timestamp flag. This PR fixes this for local and remote clients. Fixes: https://github.com/containers/podman/issues/9569 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #9521 from adrianreber/2021-02-25-checkpointctlOpenShift Merge Robot2021-03-03
|\ \ \ \ | | | | | | | | | | Reorder checkpoint/restore code for CRI-O
| * | | | Use functions and defines from checkpointctlAdrian Reber2021-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No functional changes. [NO TESTS NEEDED] - only moving code around Signed-off-by: Adrian Reber <areber@redhat.com>
| * | | | Move checkpoint/restore code to pkg/checkpoint/crutilsAdrian Reber2021-03-02
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To be able to reuse common checkpoint/restore functions this commit moves code to pkg/checkpoint/crutils. This commit has not functional changes. It only moves code around. [NO TESTS NEEDED] - only moving code around Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | Merge pull request #9560 from TristanCacqueray/libpodPutArchiveOpenShift Merge Robot2021-03-02
|\ \ \ \ | |/ / / |/| | | [NO TESTS NEEDED] swagger: update the libpodPutArchive verb
| * | | swagger: update the libpodPutArchive operation verbTristan Cacqueray2021-03-02
| | |/ | |/| | | | | | | | | | | | | | | | This change fixes the libpodPutArchive verb to PUT (POST results in 405). Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
* / | Compat api containers/json Ports field is nullMilivoje Legenovic2021-03-02
|/ / | | | | | | | | | | Fixes #9553 Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
* | Merge pull request #9531 from Luap99/fix-9526OpenShift Merge Robot2021-03-01
|\ \ | | | | | | compat api network ls accept both format options
| * | compat api network ls accept both format optionsPaul Holzinger2021-02-26
| |/ | | | | | | | | | | | | | | | | | | Docker allows both the old `map[string]map[string]bool` and the newer `map[string][]string` for the filter param so we should too. Fixes #9526 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | Merge pull request #9509 from mlegenovic/masterOpenShift Merge Robot2021-03-01
|\ \ | |/ |/| Correct compat images/create?fromImage response
| * Correct compat images/create?fromImage responseMilivoje Legenovic2021-02-26
| | | | | | | | Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
* | Merge pull request #9505 from TristanCacqueray/masterOpenShift Merge Robot2021-02-26
|\ \ | | | | | | [CI:DOCS] swagger: removes the schema type for PodSpecGenerator $ref
| * | swagger: removes the schema type for PodSpecGenerator $refTristan Cacqueray2021-02-24
| |/ | | | | | | | | | | | | | | | | | | | | When using a $ref, the type is ignored and it can confuse the openapi codegen and make it fails with this error: attribute paths.'/libpod/pods/create'(post).[create].type is unexpected This change removes the schema type attribute. Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
* / prune remotecommand dependencybaude2021-02-25
|/ | | | | | | | | | | prune a dependency that was only being used for a simple struct. Should correct checksum issue on tarballs [NO TESTS NEEDED] Fixes: #9355 Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #9485 from vrothberg/fix-9479OpenShift Merge Robot2021-02-23
|\ | | | | container removal: handle already removed containers
| * container removal: handle already removed containersValentin Rothberg2021-02-23
| | | | | | | | | | | | | | | | | | | | | | | | Since commit d54478d8eaec, a container's lock is released before attempting to stop it via the OCI runtime. This opened the window for various kinds of race conditions. One of them led to #9479 where the removal+cleanup sequences of a `run --rm` session overlapped with `rm -af`. Make both execution paths more robust by handling the case of an already removed container. Fixes: #9479 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Add U volume flag to chown source volumesEduardo Vega2021-02-22
|/ | | | Signed-off-by: Eduardo Vega <edvegavalerio@gmail.com>
* Merge pull request #9480 from jmguzik/replace-nil-with-braces-network-resourceOpenShift Merge Robot2021-02-22
|\ | | | | [NO TESTS NEEDED] Replace Labels and Options nulls with {} in NetworkResource
| * Replace Labels and Options nulls with {} in NetworkResourceJakub Guzik2021-02-23
| | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | Merge pull request #9464 from giuseppe/fix-cgroupv1-statsOpenShift Merge Robot2021-02-22
|\ \ | | | | | | cgroup: change cgroup deletion logic on v1
| * | cgroup: change cgroup deletion logic on v1Giuseppe Scrivano2021-02-22
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | do not raise an error if the cgroup exists at least on one controller. Previously it expected the cgroup to exists under all the controllers. [NO TESTS NEEDED] Closes: https://github.com/containers/podman/issues/9252 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #9456 from matejvasek/make_internalOpenShift Merge Robot2021-02-22
|\ \ | | | | | | Make binding util internal
| * | [NO TESTS NEEDED] Make binding util internalMatej Vasek2021-02-22
| | | | | | | | | | | | | | | | | | The functions are supposed to be called only from generated code Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #9445 from jmguzik/no-header-info-for-systemd-generationOpenShift Merge Robot2021-02-22
|\ \ \ | | | | | | | | No header info for systemd generation
| * | | --no-header flag implementation for generate systemdJakub Guzik2021-02-22
| | | | | | | | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | | Merge pull request #9117 from tmds/swagger_missing_schema_propertiesOpenShift Merge Robot2021-02-22
|\ \ \ \ | |_|/ / |/| | | [NO TESTS NEEDED] swagger: add missing schema properties
| * | | swagger: add missing schema propertiesTom Deseyn2021-02-22
| | |/ | |/| | | | | | | | | | | | | NO_TESTS_NEEDED Signed-off-by: Tom Deseyn <tom.deseyn@gmail.com>
* | | Merge pull request #9275 from rhatdan/buildOpenShift Merge Robot2021-02-22
|\ \ \ | | | | | | | | Add missing params for podman-remote build
| * | | Add missing params for podman-remote buildDaniel J Walsh2021-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/9290 Currently we still have hard coded --isolation=chroot for podman-remote build. Implement missing arguments for podman build Implements --jobs, --disable-compression, --excludes Fixes: MaxPullPushRetries RetryDuration Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | bump go module to v3Valentin Rothberg2021-02-22
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | We missed bumping the go module, so let's do it now :) * Automated go code with github.com/sirkon/go-imports-rename * Manually via `vgrep podman/v2` the rest Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #9436 from jonas-schievink/patch-1OpenShift Merge Robot2021-02-21
|\ \ \ | |_|/ |/| | [NO TESTS NEEDED] Log working dir when chdir fails
| * | Log working dir when chdir failsJonas Schievink2021-02-19
| | | | | | | | | | | | Signed-off-by: Jonas Schievink <jonasschievink@gmail.com>
* | | Merge pull request #9339 from matejvasek/update_wait_swaggerOpenShift Merge Robot2021-02-19
|\ \ \ | |/ / |/| | [CI:DOCS] Update swagger doc for libpod container wait
| * | [CI:DOCS] [NO TESTS NEEDED] Update swagger doc for libpod container waitMatej Vasek2021-02-18
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #9434 from jmguzik/rootless-linux-bugOpenShift Merge Robot2021-02-19
|\ \ \ | | | | | | | | [NO TESTS NEEDED] leak fix in rootless_linux.c fcn can_use_shortcut
| * | | leak fix in rootless_linux.c fcn can_use_shortcutJakub Guzik2021-02-19
| |/ / | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-07 19:30:19 +0000