summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* standardize logrus messages to upper caseDaniel J Walsh2021-09-22
| | | | | | | | Remove ERROR: Error stutter from logrus messages also. [ NO TESTS NEEDED] This is just code cleanup. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* podman save: add `--uncompressed`Valentin Rothberg2021-09-22
| | | | | | | | | | Add an option to `podman save` to allow uncompressed layers when copying OCI images. Do the neccessary plumbing for the remote client, add tests and vendor in the latest commit from c/common to fetch the neccessary changes in libimage. Closes: #11613 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Add a backoff and retries to retrieving exited eventMatthew Heon2021-09-21
| | | | | | | | | | | | | | | | | | There's a potential race around extremely short-running containers and events with journald. Events may not be written for some time (small, but appreciable) after they are received, and as such we can fail to retrieve it if there is a sufficiently short time between us writing the event and trying to read it. Work around this by just retrying, with a 0.25 second delay between retries, up to 4 times. [NO TESTS NEEDED] because I have no idea how to reproduce this race in CI. Fixes #11633 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #11662 from baude/kubenodevOpenShift Merge Robot2021-09-21
|\ | | | | Remove references to kube being development
| * Remove references to kube being developmentBrent Baude2021-09-20
| | | | | | | | | | | | | | | | | | | | At this point and even though we are always improving the play and generate kube functions, I would say it no longers needs to be denoted as under development. [NO TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Generate kube should'd add podman default environment varsDaniel J Walsh2021-09-21
| | | | | | | | | | | | | | | | Currently we add the default PATH, TERM and container from Podman to every kubernetes.yaml file. These values should not be recorded in the yaml files. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Pod Device Supportcdoern2021-09-20
| | | | | | | | | | | | | | | | | | | | added support for pod devices. The device gets added to the infra container and recreated in all containers that join the pod. This required a new container config item to keep track of the original device passed in by the user before the path was parsed into the container device. Signed-off-by: cdoern <cdoern@redhat.com>
* | Merge pull request #11601 from cdoern/mapOptionsOpenShift Merge Robot2021-09-20
|\ \ | |/ |/| Created MapOptions for PodCreate
| * Created MapOptions for PodCreatecdoern2021-09-20
| | | | | | | | | | | | | | | | MapOptions take the pod and container create options, assigning matching values from infra back to the pod for the Libpod API. This function, unlike the previous one, does not require any manual additions when new options are added since it uses the structs JSON tags, this is a more modular approach. Signed-off-by: cdoern <cdoern@redhat.com>
* | Merge pull request #11656 from Luap99/compat-idOpenShift Merge Robot2021-09-20
|\ \ | | | | | | compat API: /images/json prefix image id with sha256
| * | compat API: /images/json prefix image id with sha256Paul Holzinger2021-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | Docker adds the `sha256:` prefix to the image ID, so our compat endpoint has to do this as well. Fixes #11623 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #11652 from vrothberg/vendor-commonOpenShift Merge Robot2021-09-20
|\ \ \ | | | | | | | | vendor c/common@main
| * | | vendor c/common@mainValentin Rothberg2021-09-20
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Finalizes the linked BZ to fix passing down custom authfiles during auto updates. Also fixes the if-newer pull policy. [NO TESTS NEEDED] for now validated manually. There's a TODO to add a new system test that I did not find time for before PTO. BZ: bugzilla.redhat.com/show_bug.cgi?id=2000943 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* / / remote untag: support digestsValentin Rothberg2021-09-20
|/ / | | | | | | | | | | | | | | | | Fix a bug when remotely untagging an image via tag@digest. The digest has been lost in the remote client and hence led to a wrong behaviour on the server. Fixes: #11557 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #11606 from giuseppe/always-move-pause-process-to-scopeOpenShift Merge Robot2021-09-17
|\ \ | | | | | | runtime: move pause process to scope
| * | system: move MovePauseProcessToScope to utilsGiuseppe Scrivano2021-09-16
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | system: always move pause process when running on systemdGiuseppe Scrivano2021-09-16
| | | | | | | | | | | | | | | | | | | | | when running on a systemd with systemd, always try to move the pause process to its own scope. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | system: avoid reading pause pid fileGiuseppe Scrivano2021-09-16
| | | | | | | | | | | | | | | | | | | | | we already know the path to the pause PID file, no need to calculate it again. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Do not allow network modes to be used as network namesPaul Holzinger2021-09-16
|/ / | | | | | | | | | | | | | | | | `podman network create` should not allow users to create networks with a name which is already used for a network mode in `podman run --network`. Fixes #11448 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* / fix inverted conditionMatej Vasek2021-09-16
|/ | | | | | [NO TESTS NEEDED] Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Merge pull request #11322 from Luap99/network-libpodOpenShift Merge Robot2021-09-15
|\ | | | | Wire network interface into libpod
| * Drop OCICNI dependencyPaul Holzinger2021-09-15
| | | | | | | | | | | | | | | | | | | | | | We do not use the ocicni code anymore so let's get rid of it. Only the port struct is used but we can copy this into libpod network types so we can debloat the binary. The next step is to remove the OCICNI port mapping form the container config and use the better PortMapping struct everywhere. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * Wire network interface into libpodPaul Holzinger2021-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make use of the new network interface in libpod. This commit contains several breaking changes: - podman network create only outputs the new network name and not file path. - podman network ls shows the network driver instead of the cni version and plugins. - podman network inspect outputs the new network struct and not the cni conflist. - The bindings and libpod api endpoints have been changed to use the new network structure. The container network status is stored in a new field in the state. The status should be received with the new `c.getNetworkStatus`. This will migrate the old status to the new format. Therefore old containers should contine to work correctly in all cases even when network connect/ disconnect is used. New features: - podman network reload keeps the ip and mac for more than one network. - podman container restore keeps the ip and mac for more than one network. - The network create compat endpoint can now use more than one ipam config. The man pages and the swagger doc are updated to reflect the latest changes. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #11595 from matejvasek/fix-auth-epOpenShift Merge Robot2021-09-15
|\ \ | | | | | | Fix /auth compat endpoint
| * | Fix /auth compat endpointMatej Vasek2021-09-15
| |/ | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | Merge pull request #11592 from Luap99/runlabel-nameOpenShift Merge Robot2021-09-15
|\ \ | |/ |/| container runlabel remove image tag from name
| * container runlabel remove image tag from namePaul Holzinger2021-09-15
| | | | | | | | | | | | | | | | | | | | | | When no name is given for podman container runlabel it will default to the image base name. However this can contain a tag. Since podman does not accept container names with a colon the run command will fail if it contains something like `podman run --name NAME ...`. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2004263 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #11409 from cdoern/podVolumesOpenShift Merge Robot2021-09-15
|\ \ | |/ |/| Pod Volumes Support
| * Pod Volumes Supportcdoern2021-09-14
| | | | | | | | | | | | | | | | | | added support for the --volume flag in pods using the new infra container design. users can specify all volume options they can with regular containers resolves #10379 Signed-off-by: cdoern <cdoern@redhat.com>
* | Merge pull request #11578 from jelly/handle_nil_pointer_derefOpenShift Merge Robot2021-09-15
|\ \ | | | | | | api: handle nil pointer dereference in api endpoints
| * | api: handle nil pointer dereference in rest endpointsJelle van der Waa2021-09-15
| | | | | | | | | | | | | | | | | | | | | | | | When `?all=garbage` is passed to an API endpoint schema validation fails and err is nil. Wrapf uses err to create an error message causing a nil pointer dereference. Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
* | | Merge pull request #11574 from nalind/buildah-platformsOpenShift Merge Robot2021-09-15
|\ \ \ | |/ / |/| | build: take advantage of --platform lists
| * | build: take advantage of --platform listsNalin Dahyabhai2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The builder can take a list of platforms in the Platforms field of its BuildOptions argument, and we should definitely take advantage of that. The `bud-multiple-platform-values` test from buildah exercises support for this, so [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | Merge pull request #11575 from jelly/doc_all_optionOpenShift Merge Robot2021-09-14
|\ \ \ | |/ / |/| | [CI:DOCS] Document `all` query parameter for /libpod/images/prune
| * | Document `all` query parameter for /libpod/images/pruneJelle van der Waa2021-09-14
| | | | | | | | | | | | Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
* | | Merge pull request #11170 from flouthoc/support-rootfs-overlayOpenShift Merge Robot2021-09-14
|\ \ \ | | | | | | | | rootfs: Add support for rootfs-overlay.
| * | | rootfs: Add support for rootfs-overlay and bump to buildah v1.22.1-0.202108flouthoc2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows users to specify a readonly rootfs with :O, in exchange podman will create a writable overlay. bump builah to v1.22.1-0.20210823173221-da2b428c56ce [NO TESTS NEEDED] Signed-off-by: flouthoc <flouthoc.git@gmail.com>
* | | | Merge pull request #11569 from baude/macaarch64pullfcosOpenShift Merge Robot2021-09-14
|\ \ \ \ | | | | | | | | | | Use new aarch64 fcos repos
| * | | | Use new aarch64 fcos reposbaude2021-09-14
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Now that aarch64 fcos is an official thing, we no longer need to use the side repo (for lack of a better word). We can now use the same image lookup technique as x86_64. I removed the special lookup, moved the x86_64 lookup to generic arch, and removed the arch specific files that we no longer needed. [NO TESTS NEEDED] Signed-off-by: baude <baude@redhat.com>
* | | | Merge pull request #11559 from jwhonce/wip/generatorOpenShift Merge Robot2021-09-14
|\ \ \ \ | |_|_|/ |/| | | Enhance bindings for IDE hints
| * | | Enhance bindings for IDE hintsJhon Honce2021-09-14
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Follow https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source for leading comment * Add godoc strings for all exposed methods for IDE support * Copy field godoc strings into generated code as function godoc string * Remove unused/unnecessary fields from generator.go structures * Cleanup code regarding template usage Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #11551 from Luap99/rootlessport-restartOpenShift Merge Robot2021-09-14
|\ \ \ | |_|/ |/| | fix restart always with rootlessport
| * | remove rootlessport socket to prevent EADDRINUSEPaul Holzinger2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | When we restart a container via podman restart or restart policy the rootlessport process fails with `address already in use` because the socketfile still exists. This is a regression and was introduced in commit abdedc31a25e. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Search gvproxy with config.FindHelperBinary()Hyeon Kim2021-09-14
| |/ |/| | | | | | | | | | | | | Closes #11531 [NO TESTS NEEDED] Signed-off-by: Hyeon Kim <simnalamburt@gmail.com>
* | Merge pull request #11529 from n1hility/fix-oldfieldsOpenShift Merge Robot2021-09-13
|\ \ | | | | | | Add deprecated event fields for 1.22+ clients that still expect them
| * | Add deprecated fields for 1.22+ clients that still expect themJason T. Greene2021-09-10
| | | | | | | | | | | | Signed-off-by: Jason Greene <jason.greene@redhat.com>
* | | Merge pull request #11440 from ashley-cui/sshOpenShift Merge Robot2021-09-13
|\ \ \ | | | | | | | | Use default username for podman machine ssh
| * | | Use default username for podman machine sshAshley Cui2021-09-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When using the defaut conection for podman machine ssh, use the default username too. Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Fix #11444: remote breaks with stdout redirectionAnton Tykhyy2021-09-13
| |_|/ |/| | | | | | | | | | | | | | | | | `setConsoleMode` should do nothing if the handle is not a terminal. The proposed change is [exactly what `golang.org/x/term/IsTerminal()` does on Windows](https://cs.opensource.google/go/x/term/+/6886f2df:term_windows.go). [NO TESTS NEEDED] Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
* | | Merge pull request #11517 from jwhonce/issues/10053OpenShift Merge Robot2021-09-12
|\ \ \ | | | | | | | | Refactor API server emphasis on logging