summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* Merge pull request #5777 from jwhonce/issues/5599OpenShift Merge Robot2020-04-13
|\ | | | | Refactor service idle support
| * Refactor service idle supportJhon Honce2020-04-13
| | | | | | | | | | | | | | | | | | | | | | * Move connection tracking into APIServer using ConnState() * Remove Connection counters from CLI code * Update events handler to support client not closing connection * Improve logging messages Fixes #5599 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5778 from baude/v2removetemplatesOpenShift Merge Robot2020-04-13
|\ \ | |/ |/| podmanv2 history and image remove templates
| * podmanv2 history and image remove templatesBrent Baude2020-04-13
| | | | | | | | | | | | remove the use of template functions images and history to allow for straight-forward user experience. instead of templates we use structs and struct methods. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5797 from giuseppe/use-snprintfOpenShift Merge Robot2020-04-13
|\ \ | |/ |/| rootless: use snprintf
| * rootless: use snprintfGiuseppe Scrivano2020-04-13
| | | | | | | | | | | | use directly snprintf instead of strlen+strcpy. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | v2podman container cleanupBrent Baude2020-04-09
| | | | | | | | | | | | | | | | add the ability to clean up after a container has attempted to run. this is also important for podman run --rm --rmi. also included are fixes and tweaks to various code bits to correct regressions on output. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5754 from baude/v2psformatOpenShift Merge Robot2020-04-09
|\ \ | | | | | | v2podman ps alter formats
| * | v2podman ps alter formatsBrent Baude2020-04-08
| |/ | | | | | | | | | | in order to get the go templating to work for custom input, we now use structure methods instead of template map funcs. this requires some manipulation of fields so that the funcs can have the proper names. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5634 from jwhonce/wip/serviceOpenShift Merge Robot2020-04-09
|\ \ | | | | | | V2 podman system service
| * | V2 podman system serviceJhon Honce2020-04-07
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added support for system service * Enabled linting on the varlinkapi source, needed to support V2 service command * Added support for PODMAN_SOCKET Skip linting deprecated code Rather than introduce bugs by correcting deprecated code, linting the code is being skipped. Code that is being ported into V2 is being checked. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | podmanV2: implement logsValentin Rothberg2020-04-09
| | | | | | | | | | | | | | | | | | | | | | Implement the `podman {container} logs` for the v2 client. The remote client does not yet support it. There's some more work needed for the rest api; some options are missing (e.g., printing names) while others are broken (e.g., the until http parameter). The remote parts will be tackled in a future change. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | add tests for kill and existsLokesh Mandvekar2020-04-08
|/ | | | Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* Merge pull request #5739 from jwhonce/wip/diffOpenShift Merge Robot2020-04-07
|\ | | | | V2 Podman diff(changes) support
| * V2 podman diff(changes) supportJhon Honce2020-04-07
| | | | | | | | | | | | | | | | | | * Ported CLI command * Added API endpoint * Added bindings * Updated swagger (TODO: n endpoints, one handler) Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5738 from baude/v2infoOpenShift Merge Robot2020-04-07
|\ \ | |/ |/| podmanv2 info
| * podmanv2 infoBrent Baude2020-04-07
| | | | | | | | | | | | add ability to run info for v2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5728 from openSUSE/pids.currentOpenShift Merge Robot2020-04-07
|\ \ | |/ |/| Do not error on pids.current stats if ctr.path is empty
| * Do not error on pids.current stats if ctr.path is emptySascha Grunert2020-04-07
| | | | | | | | | | | | | | | | | | | | If the ctr.path is empty, then we do not try to access `/sys/fs/cgroup/pids/pids.current` any more because this path will be wrong in any case. We now return and do not set the PIDs stats. Refers to https://github.com/cri-o/cri-o/issues/3522 Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | Merge pull request #5734 from baude/v2runOpenShift Merge Robot2020-04-07
|\ \ | | | | | | v2podman run
| * | v2podman runBrent Baude2020-04-06
| | | | | | | | | | | | | | | | | | add the ability to run a container Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5478 from giuseppe/auto-usernsOpenShift Merge Robot2020-04-06
|\ \ \ | |/ / |/| | userns: support --userns=auto
| * | userns: support --userns=autoGiuseppe Scrivano2020-04-06
| | | | | | | | | | | | | | | | | | | | | automatically pick an empty range and create an user namespace for the container. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5716 from baude/v2psOpenShift Merge Robot2020-04-06
|\ \ \ | | | | | | | | podmanv2 ps
| * | | podmanv2 psBrent Baude2020-04-06
| | | | | | | | | | | | | | | | | | | | | | | | add the ability to list containers Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | refactor infoBrent Baude2020-04-06
|/ / / | | | | | | | | | | | | | | | the current implementation of info, while typed, is very loosely done so. we need stronger types for our apiv2 implmentation and bindings. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5620 from cfelder/play-kube-networkingOpenShift Merge Robot2020-04-06
|\ \ \ | | | | | | | | Add support for specifying CNI networks in podman play kube
| * | | Add support for specifying CNI networks in podman play kubeChristian Felder2020-03-27
| | | | | | | | | | | | | | | | | | | | Fixes: #5609 Signed-off-by: Christian Felder <c.felder@fz-juelich.de>
| * | | Fix typo in pod createChristian Felder2020-03-27
| | | | | | | | | | | | | | | | Signed-off-by: Christian Felder <c.felder@fz-juelich.de>
* | | | podmanv2 startBrent Baude2020-04-06
| |/ / |/| | | | | | | | | | | | | | add the ability to start containers Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5689 from sujil02/v2-pod-inspectOpenShift Merge Robot2020-04-06
|\ \ \ | | | | | | | | podmanv2 pod inspect
| * | | podmanv2 pod inspectSujil022020-04-01
| | | | | | | | | | | | | | | | | | | | | | | | Add the ability to inspect pod in podmanv2 Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | Merge pull request #5714 from baude/v2attachOpenShift Merge Robot2020-04-06
|\ \ \ \ | | | | | | | | | | v2podman attach
| * | | | v2podman attach and execBrent Baude2020-04-05
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | add the ability to attach to a running container. the tunnel side of this is not enabled yet as we have work on the endpoints and plumbing to do yet. add the ability to exec a command in a running container. the tunnel side is also being deferred for same reason. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5713 from baude/v2versionOpenShift Merge Robot2020-04-06
|\ \ \ \ | |/ / / |/| | | podmanv2 version
| * | | podmanv2 versionBrent Baude2020-04-03
| | | | | | | | | | | | | | | | | | | | | | | | this is only for the abi side and does not print out the remote information yet. the remote information will need to be worked on and agreed upon later. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | v2podman container createBrent Baude2020-04-03
| | | | | | | | | | | | | | | | | | | | | | | | create a container in podmanv2 using specgen approach. this is the core implementation and still has quite a bit of code commented out specifically around volumes, devices, and namespaces. need contributions from smes on these parts. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5672 from baude/v2saveOpenShift Merge Robot2020-04-03
|\ \ \ \ | | | | | | | | | | podmanv2 save image
| * | | | podmanv2 save imageBrent Baude2020-04-03
| |/ / / | | | | | | | | | | | | | | | | | | | | add ability to save an image for podman v2 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5638 from baude/v2containercheckOpenShift Merge Robot2020-04-03
|\ \ \ \ | | | | | | | | | | podmanv2 checkpoint and restore
| * | | | podmanv2 checkpoint and restoreBrent Baude2020-04-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add the ability to checkpoint and restore containers on v2podman Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5676 from kolyshkin/volume-flags-altOpenShift Merge Robot2020-04-03
|\ \ \ \ \ | |_|/ / / |/| | | | Fix/improve pkg/storage.InitFSMounts
| * | | | pkg/spec.InitFSMounts: optimizeKir Kolyshkin2020-04-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of getting mount options from /proc/self/mountinfo, which is very costly to read/parse (and can even be unreliable), let's use statfs(2) to figure out the flags we need. [v2: move getting default options to pkg/util, make it linux-specific] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
| * | | | pkg/spec.InitFSMounts: fix mount opts in placeKir Kolyshkin2020-04-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... rather than create a new slice and then make the caller replace the original with the new one. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
| * | | | pkg/spec/initFSMounts: fixKir Kolyshkin2020-03-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > $ ./bin/podman run -v /tmp:/tmp alpine true; echo $? > 0 > $ ./bin/podman run -v /tmp:/tmp:ro alpine true; echo $? > 0 > $ ./bin/podman run -v /tmp:/w0w:ro alpine true; echo $? > Error: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"rootfs_linux.go:58: mounting \\\"/tmp\\\" to rootfs \\\"/home/kir/.local/share/containers/storage/overlay/7636ef3650fc91ee4996ccc026532bb3cff7182c0430db662fffb933e0bcadc9/merged\\\" at \\\"/home/kir/.local/share/containers/storage/overlay/7636ef3650fc91ee4996ccc026532bb3cff7182c0430db662fffb933e0bcadc9/merged/w0w\\\" caused \\\"operation not permitted\\\"\"": OCI runtime permission denied error > 126 The last command is not working because in-container mount point is used to search for a parent mount in /proc/self/mountinfo. And yet the following > $ ./bin/podman run -v /tmp:/run/test:ro alpine true; echo $? > 0 still works fine! Here's why: > $ mount | grep -E '/run |/tmp ' > tmpfs on /run type tmpfs (rw,nosuid,nodev,seclabel,mode=755) > tmpfs on /tmp type tmpfs (rw,nosuid,nodev,seclabel) This is the reason why previous commit modified in-container mount point. Fixes: 0f5ae3c5af Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
* | | | | Merge pull request #5701 from vrothberg/v2-pushOpenShift Merge Robot2020-04-03
|\ \ \ \ \ | |_|/ / / |/| | | | podmanV2: implement push
| * | | | podmanV2: implement pushValentin Rothberg2020-04-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Implement `podman-push` and `podman-image-push` for the podmanV2 client. * Tests for `pkg/bindings` are not possible at the time of writing as we don't have a local registry running. * Implement `/images/{name}/push` compat endpoint. Tests are not implemented for this v2 endpoint. It has been tested manually. General note: The auth config extraction from the http header is not implement for push. Since it's not yet supported for other endpoints either, I deferred it to future work. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Fix environment handling from containers.confDaniel J Walsh2020-04-02
|/ / / / | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #5688 from baude/v2importOpenShift Merge Robot2020-04-02
|\ \ \ \ | | | | | | | | | | podmanv2 import
| * | | | podmanv2 importBrent Baude2020-04-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add the ability to import a container image from a container export Signed-off-by: Brent Baude <bbaude@redhat.com>