summaryrefslogtreecommitdiff
path: root/pkg
Commit message (Collapse)AuthorAge
* Fix SELinux functions names to not be repetitiveDaniel J Walsh2020-04-23
| | | | | | | Since functions are now in an selinux subpackage, they should not start with SELinux Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #5933 from giuseppe/fix-namespacesOpenShift Merge Robot2020-04-23
|\ | | | | podman, v2: handle namespaces specified on the CLI
| * podman: handle namespaces specified on the CLIGiuseppe Scrivano2020-04-23
| | | | | | | | | | | | | | and handle differently the user namespace as it supports additional options. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * pkg: fix shmsize error messageGiuseppe Scrivano2020-04-23
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #5946 from jwhonce/wip/shutdownOpenShift Merge Robot2020-04-23
|\ \ | |/ |/| V2 restore libpod.Shutdown() when exiting podman commands
| * V2 restore libpod.Shutdown() when exiting podman commandsJhon Honce2020-04-22
| | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5843 from QiWang19/manifest_createOpenShift Merge Robot2020-04-23
|\ \ | | | | | | manifest create,add,inspect
| * | manifest create,add,inspectQi Wang2020-04-22
| | | | | | | | | | | | | | | | | | Implememts manifest subcommands create, add, inspect. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Stop wrapping pull messagesDaniel J Walsh2020-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The length and size of our error messages on failure to pull is huge. This patch at least eliminates some of the wrapping. But I think eventually we need to look at containers/image and see if we can modify the error messages to something a little more human friendly. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | V2 Restore rmi testsJhon Honce2020-04-22
| | | | | | | | | | | | | | | | | | | | | * Introduced define.ErrImageInUse to assist in determining the exit code without resorting string searches. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #5942 from mheon/volume_flagsOpenShift Merge Robot2020-04-22
|\ \ \ | |_|/ |/| | Enable basic volumes support in Podmanv2
| * | Enable basic volumes support in Podmanv2Matthew Heon2020-04-22
| | | | | | | | | | | | | | | | | | | | | | | | This enables the --volume, --mount, and --tmpfs flags in Podmanv2. It does not enable init-related flags, image volumes, and --volumes-from. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #5936 from rhatdan/selinux1OpenShift Merge Robot2020-04-22
|\ \ \ | |_|/ |/| | Move selinux labeling support from pkg/util to pkg/selinux
| * | Move selinux labeling support from pkg/util to pkg/selinuxDaniel J Walsh2020-04-22
| |/ | | | | | | | | | | | | The goal here is to make the package less heavy and not overload the pkg/util. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5930 from jwhonce/issues/5765OpenShift Merge Robot2020-04-22
|\ \ | | | | | | Instrumentation to answer #5765
| * | Instrumentation to answer #5765Jhon Honce2020-04-22
| |/ | | | | | | | | | | * currently wired to localhost:8888 to prevent access from off machine Signed-off-by: Jhon Honce <jhonce@redhat.com>
* / Fix integration tests for untagBrent Baude2020-04-22
|/ | | | | Signed-off-by: Brent Baude <bbaude@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #5916 from giuseppe/userns-autoOpenShift Merge Robot2020-04-21
|\ | | | | v2, podman: plug --userns=auto
| * v2, podman: plug --userns=autoGiuseppe Scrivano2020-04-21
| | | | | | | | | | | | --userns=auto tests pass now. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Modify namespace generation code for specgenMatthew Heon2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | Namespaces have now been changed to properly handle all cases. Spec handling code for namespaces was consolidated in a single function. Still missing: - Image ports - Pod namespaces likely still broken in Podmanv2 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5900 from baude/v2cpOpenShift Merge Robot2020-04-21
|\ \ | | | | | | podmanv2 cp
| * | podmanv2 cpBrent Baude2020-04-21
| | | | | | | | | | | | | | | | | | enable podman to copy files between container and host, local mode only. this is a straight port of v1 code to v2. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5921 from baude/v2imageepOpenShift Merge Robot2020-04-21
|\ \ \ | | | | | | | | add entrypoint from image where needed
| * | | add entrypoint from image where neededBrent Baude2020-04-21
| | | | | | | | | | | | | | | | | | | | | | | | if the image specifies both the image and entrypoint, we need to account for that and preprend the entrypoint to the command. this only happens if no user command and entrypoint were supplied. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5912 from giuseppe/v2-rlimitsOpenShift Merge Robot2020-04-21
|\ \ \ \ | |_|/ / |/| | | v2, pkg: implement rlimits
| * | | pkg: implement rlimitsGiuseppe Scrivano2020-04-21
| | |/ | |/| | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | v2podman portBrent Baude2020-04-21
| |/ |/| | | | | | | | | add port command to podman. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5913 from rhatdan/v2OpenShift Merge Robot2020-04-21
|\ \ | | | | | | More fixes for podman create tests
| * | Handle annotations passed in via the clientDaniel J Walsh2020-04-21
| | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5647 from rhatdan/containers.confOpenShift Merge Robot2020-04-21
|\ \ \ | |/ / |/| | Update podmanV2 to use containers.conf
| * | Update podman to use containers.confDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | Add more default options parsing Switch to using --time as opposed to --timeout to better match Docker. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5875 from rhatdan/networkOpenShift Merge Robot2020-04-21
|\ \ \ | | | | | | | | Cleanup network option parsing
| * | | Cleanup network option parsingDaniel J Walsh2020-04-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were not handling the parsing of --ip. This pr adds validation checks and now will support the flag. Move validation to the actual parsing of the network flags. We should only parse the dns flags if the user changed them. We don't want to pass default options if set in containers.conf to the server. Potential for duplicating defaults. Add support for --dns-opt flag passing Begin handling of --network flag, although we don't have a way right now to translate a string into a specgen.Namespace. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | podman rmi: refactor logicValentin Rothberg2020-04-21
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While this commit was initially meant to fix #5847, it has turned into a bigger refactoring which I did not manage to break into smaller pieces: * Fix #5847 by refactoring the image-removal logic. * Make the api handler for image-removal use the ABI code. This way, both (i.e., ABI and Tunnel) end up using the same code. Achieving this code share required to move some code around to prevent circular dependencies. * Everything in pkg/api (excluding pkg/api/types) must now only be accessed from code using `ABISupport`. * Avoid imports from entities on handlers to prevent circular dependencies. * Move `podman system service` logic into `cmd` to prevent circular dependencies - it depends on pkg/api. * Also remove the build header from infra/abi files. It will otherwise confuse swagger and other tools; errors we cannot fix as go doesn't expose a build-tag env variable. Fixes: #5847 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5883 from abitrolly/patch-3OpenShift Merge Robot2020-04-20
|\ \ \ | | | | | | | | Return labes in API (fixes #5882)
| * | | Return labes in API (fixes #5882)Anatoli Babenia2020-04-20
| |/ / | | | | | | | | | Signed-off-by: Anatoli Babenia <anatoli@rainforce.org>
* | | Merge pull request #5862 from rhatdan/v2OpenShift Merge Robot2020-04-20
|\ \ \ | | | | | | | | Fix up handling of image data as well as setting Linux Capabilties correctly
| * | | Fix podman inspect to accept -l and -s fieldsDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Podman inspect has a breaking change in that it dropped --latest and --size options. This PR adds these back. Lots of tests rely on podman inspect -l. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | Handle Linux Capabilities correctlyDaniel J Walsh2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If user sets capabilities list we need handle minimal capabilities. Also handle seccomp-policy being passed in. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | Add functions to return image informationsDaniel J Walsh2020-04-20
| | |/ | |/| | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5899 from jwhonce/wip/treeOpenShift Merge Robot2020-04-20
|\ \ \ | | | | | | | | V2 podman image tree
| * | | V2 podman image treeJhon Honce2020-04-20
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | * Basic port of V1 podman image tree ID TODO: Refactor to return tree from service and format in presentation layer TODO: Support tunneling mode Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #5889 from giuseppe/rootless-fd-joinOpenShift Merge Robot2020-04-20
|\ \ \ | |/ / |/| | rootless: move join namespace inside child process
| * | rootless: move join namespace inside child processGiuseppe Scrivano2020-04-20
| | | | | | | | | | | | | | | | | | | | | | | | open the namespace file descriptors inside of the child process. Closes: https://github.com/containers/libpod/issues/5873 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | rootless: skip looking up parent user nsGiuseppe Scrivano2020-04-20
| |/ | | | | | | | | | | | | | | since we join directly the conmon user namespace, there is no need to look up its parent user namespace, as we can safely assume it is the init namespace. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #5872 from jwhonce/wip/optionsOpenShift Merge Robot2020-04-20
|\ \ | | | | | | V2 Fix support for tcp://[::]<port> connections
| * | V2 Fix support for tcp://[::]<port> connectionsJhon Honce2020-04-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix support for socket activation, on remote and service $ systemd-socket-activate -l 8083 --fdname=podman bin/podman system service --log-level=debug --time=30 $ bin/podman-remote --remote=tcp://[::]:8083 image ls Or, use the podman.{socket,service} unit files $ bin/podman-remote --remote=unix:///run/podman/podman.sock image ls Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Update pod inspect report to hold current pod status.Sujil022020-04-20
| |/ |/| | | | | | | | | | | Added status field in pod inspect report. Fixed pod tests to use it. Signed-off-by: Sujil02 <sushah@redhat.com>
* | Add pod prune for api v2.Sujil022020-04-17
|/ | | | | | | | Add the ability to prune pods for api v2, Includes the addition of force flag, for client side prompt. Update test suite to support this use case. Signed-off-by: Sujil02 <sushah@redhat.com>
* Merge pull request #5868 from baude/v2t2OpenShift Merge Robot2020-04-17
|\ | | | | Fixes for system tests