summaryrefslogtreecommitdiff
path: root/test
Commit message (Collapse)AuthorAge
* Add --include-volumes flag to 'podman commit'Matthew Heon2019-04-11
| | | | | | | | | | | | | The 'docker commit' will never include a container's volumes when committing, without an explicit request through '--change'. Podman, however, defaulted to including user volumes as image volumes. Make this behavior depend on a new flag, '--include-volumes', and make the default behavior match Docker. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Implement podman-remote rmJhon Honce2019-04-09
| | | | | | | | | * refactor command output to use one function * Add new worker pool parallel operations * Implement podman-remote umount * Refactored podman wait to use printCmdOutput() Signed-off-by: Jhon Honce <jhonce@redhat.com>
* test: fix remote tests for rootlessGiuseppe Scrivano2019-04-08
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* test: enable userns e2e tests for rootlessGiuseppe Scrivano2019-04-08
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #2845 from QiWang19/cpdirOpenShift Merge Robot2019-04-08
|\ | | | | fix bug podman cp directory
| * fix bug podman cp directoryQi Wang2019-04-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `podman cp` used to copy the contents under the source directory to the destination. But according to the specification in podman-cp.md. it should copy the whole directory to the destination if the destination directory already exists. - src dir ends with /., copy the contents to dest dir - src dir does not end with /. - dest dir /home does not exist, copy the contents - dest dir /home exists, copy the directory ``` $ sudo podman cp /home/qiwan/Documents/empty 7c47:/home $ sudo podman exec -it 7c47 ls /home $ $ sudo podman cp /home/qiwan/Documents/empty 7c47:/home $ sudo podman exec -it 7c47 ls /home empty ``` Signed-off-by: Qi Wang <qiwan@redhat.com>
* | Merge pull request #2841 from openSUSE/ginkgo-unitOpenShift Merge Robot2019-04-08
|\ \ | | | | | | Update registrar unit tests to match them of cri-o
| * | Update registrar unit tests to match them of cri-oSascha Grunert2019-04-04
| |/ | | | | | | | | | | | | - Add the test framework abstraction - Update the unit tests to run with ginkgo Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | Revert "Switch to golangci-lint"Brent Baude2019-04-05
| | | | | | | | Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2742 from openSUSE/golangci-lintDaniel J Walsh2019-04-05
|\ \ | | | | | | Switch to golangci-lint
| * | Add deadcode linterSascha Grunert2019-04-04
| |/ | | | | | | Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | Merge pull request #2858 from giuseppe/rootless-enable-healthcheckOpenShift Merge Robot2019-04-05
|\ \ | | | | | | rootless: enable healthcheck
| * | rootless: enable healthcheck testsGiuseppe Scrivano2019-04-05
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | podman: enable kube for rootlessGiuseppe Scrivano2019-04-05
|/ / | | | | | | | | | | Closes: https://github.com/containers/libpod/issues/2852 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Fix E2E testsMatthew Heon2019-04-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Commit test is blatantly wrong and testing buggy behavior. We should be commiting the destination, if anything - and more likely nothing at all. When force-removing volumes, don't remove the volumes of containers we need to remove. This can lead to a chicken and the egg problem where the container removes the volume before we can. When we re-add volume locks this could lead to deadlocks. I don't really want to deal with this, and this doesn't seem a particularly harmful quirk, so we'll let this slide until we get a bug report. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Major rework of --volumes-from flagMatthew Heon2019-04-04
|/ | | | | | | | | | The flag should be substantially more durable, and no longer relies on the create artifact. This should allow it to properly handle our new named volume implementation. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Improve podman pod rm -a testChris Evich2019-04-03
| | | | | | | | | | | | | | | When running as a user, the order of removal is database ID dependent. This results in this test randomly failing. This condition was very difficult to debug and the test was missing two critical checks. One to confirm an expected error message was produced, and another to verify the expected running container, remains running. Fix the container and missing error-message checks, and vastly improve the debug-ability of this test. Fixing the random-failures requires intensive fixes in other areas, so that task will be left up to future work. Signed-off-by: Chris Evich <cevich@redhat.com>
* test: test that an unprivileged user cannot access the storageEd Santiago2019-03-29
| | | | | Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #2747 from mheon/dns_noneOpenShift Merge Robot2019-03-27
|\ | | | | Add --dns=none
| * Add a test that --add-host conflicts with --no-hostsMatthew Heon2019-03-27
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Sigh; disable pod-top test, it's unreliable (#2780)Ed Santiago2019-03-27
|/ | | | Signed-off-by: Ed Santiago <santiago@redhat.com>
* size is optional for container inspectionbaude2019-03-26
| | | | | | | | | | on the remote client, if a user wants to know the rootfs size of a container, a -s should be passed. this corrects a behavior where size was shown by default. Fixes #2765 Signed-off-by: baude <bbaude@redhat.com>
* Add three test cases for podman attach testYiqiao Pu2019-03-26
| | | | | | | | | Add following test cases for podman attach test: 1. podman attach to a running container 2. podman attach to the latest container 3. podman attach to a container with --sig-proxy set to false Signed-off-by: Yiqiao Pu <ypu@redhat.com>
* Merge pull request #2498 from QiWang19/sysdfOpenShift Merge Robot2019-03-26
|\ | | | | podman system df- show podman disk usage
| * system df to show podman disk usageQi Wang2019-03-25
| | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | podman health check phase3baude2019-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman will not start a transient service and timer for healthchecks. this handles the tracking of the timing for health checks. added the 'started' status which represents the time that a container is in its start-period. the systemd timing can be disabled with an env variable of DISABLE_HC_SYSTEMD="true". added filter for ps where --filter health=[starting, healthy, unhealthy] can now be used. Signed-off-by: baude <bbaude@redhat.com>
* | userns: use the intermediate mountns for volumesGiuseppe Scrivano2019-03-21
|/ | | | | | | | | | | when --uidmap is used, the user won't be able to access /var/lib/containers/storage/volumes. Use the intermediate mount namespace, that is accessible to root in the container, for mounting the volumes inside the container. Closes: https://github.com/containers/libpod/issues/2713 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* podman: do not split --env on commaGiuseppe Scrivano2019-03-20
| | | | | | | | if --env "a=b,c" is used, do not split into a=b and c=. Closes: https://github.com/containers/libpod/issues/2712 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Add new key and never-expiring test certificateChris Evich2019-03-20
| | | | | | | | Former `domain.crt` was created with a one-year life and expired causing all testing to fail. Create a replacement, along with configuration and documentation on how to make a new certificate if ever required. Signed-off-by: Chris Evich <cevich@redhat.com>
* Merge pull request #2703 from edsantiago/batsOpenShift Merge Robot2019-03-19
|\ | | | | BATS: new tests, and improvements to existing ones
| * BATS: new tests, and improvements to existing onesEd Santiago2019-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | New: - podman exec - podman load (requires #2674) - CLI parsing (regression test for #2574) Improved: - help: test "podman NoSuchCommand", and subcommands - help: test "podman cmd" without required args - pod: start with --infra=false; this allows running rootless - log: also run 'logs' after container is run - log: test -f with two containers Also, use helpful descriptions for skip_if_rootless Tested on f29, root and rootless. As soon as podman-remote supports rm, I'll start testing that too. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | ps: fix segfault if the store is not initializedGiuseppe Scrivano2019-03-19
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | tests: re-enable some tests for rootless modeGiuseppe Scrivano2019-03-19
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | test: fix SkipIfRootless() helperGiuseppe Scrivano2019-03-19
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Enable rootless integration testsbaude2019-03-19
| | | | | | | | Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2688 from baude/issue2671OpenShift Merge Robot2019-03-18
|\ \ | | | | | | support GO template {{ json . }}
| * | support GO template {{ json . }}baude2019-03-18
| | | | | | | | | | | | | | | | | | | | | | | | for podman version, we now support a GO template for json output. fixes #2671 Signed-off-by: baude <bbaude@redhat.com>
* | | Export ConmonPidFile in 'podman inspect' for containersDebarshi Ray2019-03-18
| |/ |/| | | | | | | | | | | | | | | This can help scripts provide a more meaningful message when coming across issues [1] which require the container to be re-created. [1] eg., https://github.com/containers/libpod/issues/2673 Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
* | Merge pull request #2632 from ↵OpenShift Merge Robot2019-03-18
|\ \ | | | | | | | | | | | | debarshiray/wip/rishi/podman-rm-exit-with-125-for-bogus-and-running Make 'podman rm' exit with 125 if it had a bogus & a running container
| * | Make 'podman rm' exit with 125 if it had a bogus & a running containerDebarshi Ray2019-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Getting a list of containers, and then deleting them are two separate fallible steps that can run into different sets of errors. eg., in the case of a bogus missing container and a container that's running or paused, the first step will only trigger libpod.ErrNoSuchCtr. At this point it might appear that the exit code ought to be 1. However, when attempting the deletion, it will fail once more due to the status of the running or paused container. Since libpod.ErrNoSuchCtr is no longer the only error encountered, the exit code should be reset to 125. This problem is currently masked for rootless usage due to commit 35432ecaae4a8372 ("rootless: fix rm when uid in the container != 0"). Fixes: 85db895012bead6b ("rm: set exit code to 1 if a specified ...") e41279b902a334e5 ("Change exit code to 1 on podman rm ...") Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
* | | podman logs on created container should exitbaude2019-03-18
| |/ |/| | | | | | | | | | | | | | | | | | | when running podman logs on a created container (which has no logs), podman should return gracefully (like docker) with a 0 return code. if multiple containers are provided and one is only in the created state (and no follow is used), we still display the logs for the other ids. fixes issue #2677 Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2683 from giuseppe/fix-pod-topOpenShift Merge Robot2019-03-18
|\ \ | | | | | | rootless: fix pod top
| * | rootless: fix pod topGiuseppe Scrivano2019-03-18
| |/ | | | | | | | | | | | | | | we need to join the namespace of the target pod. Closes: https://github.com/containers/libpod/issues/2682 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #2620 from baude/multilogsOpenShift Merge Robot2019-03-16
|\ \ | | | | | | display logs for multiple containers at the same time
| * | display logs for multiple containers at the same timebaude2019-03-15
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | add the ability for users to specify more than one container at a time while using podman logs. If more than one container is being displayed, podman will also prepend a shortened container id of the container on the log line. also, enabled the podman-remote logs command during the refactoring of the above ability. fixes issue #2219 Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2664 from kunalkushwaha/ps-port-fixOpenShift Merge Robot2019-03-16
|\ \ | |/ |/| port grouping in ps command output
| * testcase added for listing range of ports in ps commandKunal Kushwaha2019-03-15
| | | | | | | | Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
* | build: fix build DIR -t TAGGiuseppe Scrivano2019-03-15
| | | | | | | | | | | | | | | | accept also the order "build DIR -t TAG" Closes: https://github.com/containers/libpod/issues/2636 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #2645 from mheon/fix_some_flakesOpenShift Merge Robot2019-03-15
|\ \ | |/ |/| Fix a few flakes
| * Bump timeout on a podman info test to defaultMatthew Heon2019-03-14
| | | | | | | | | | | | Saw this flake a few times because of a timeout issue. Signed-off-by: Matthew Heon <matthew.heon@pm.me>