| Commit message (Collapse) | Author | Age |
|\
| |
| | |
Fix when the --format flag prints a new line at the end
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the output is to a terminal, return a new line at the end of the
output so that the output is visually appealing. If the output is being
piped, or saved to a file, basically not being outputted to a terminal, do
not print a new line at the end of the output. This ensures any further data
manipulation with the results happens smoothly without requiring to remember
the '/n' at the end of the output.
Signed-off-by: umohnani8 <umohnani@redhat.com>
|
|\ \
| |/
|/| |
More ginkgo migration
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* attach
* run_exit
* save
* tag
* version
* run_privileged -> privileged
Signed-off-by: baude <bbaude@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Made a change to make sure that the output paths of podman inspect
matches that of docker inspect. For example to get the stop signal
you should be able to do podman inspect ctr --format {{.Config.StopSignal}}
and the same thing in docker will give the same results.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #292
Approved by: rhatdan
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
podman search queries a registry for a matching image and prints
the output.
I added a new flag called "registry" giving the user the option
to search a specific registry if they don't want to search all
their default registries.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #241
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate the following to the ginkgo integration tests:
* images
* import
* inspect
* logs
* run_dns
Signed-off-by: baude <bbaude@redhat.com>
Closes: #295
Approved by: mheon
|
|
|
|
|
|
|
|
|
| |
sysfs should be mounted rw for a privileged container.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #279
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
| |
Migrate the diff, exec, export, and history bats tests to
the ginkgo test suite.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #287
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue #169 describes a common failure when running podman top where
if the commands inside the container container a space in them, podman
will panic. This was occuring because we take the output from ps and
attempt to format it nicely for output and things like JSON. Given that
this cannot be predicted or dealt with programatically, the decision was
made to deprecate the format switch and simply output what ps provides
us.
Migrated top integration tests to ginkgo.
Resolves Issue: https://github.com/projectatomic/libpod/issues/169
Signed-off-by: baude <bbaude@redhat.com>
Closes: #291
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to have sd_notify from systemd to work in containers
we need to pass down the NOTIFY_SOCKET environment variable to
the container.
LISTEN_FDS, tells the application inside of the container to use
socket activation and grab the FDS that are leaked into the container.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #271
Approved by: umohnani8
|
|
|
|
|
|
|
| |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #135
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate create and commit bats tests to the ginkgo
test suite. In doing so, some structures had to be
moved to pkg/podmanstructs/podmanstructs.go so we
could do better verification of test results.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #286
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
| |
Migrate kill tests to the ginkgo suite and remove the
podman_kill bats.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #281
Approved by: baude
|
|
|
|
|
|
|
|
|
|
| |
When network == none, the container should only have a
loopback interface and that's it.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #176
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate ps, pull, push, and rm from bats to ginkgo.
Also, fixed a conditional issue with adding ports
when an image defines the port and the user wants
to override it.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #277
Approved by: baude
|
|
|
|
|
|
|
|
|
|
| |
Migrate the start, stats, and stop integration tests to the
Ginkgo style.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #274
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements the ginkgo integration test framework for
podman. As tests are migrated from bats to ginkgo, we will
still run both integration suites. When a test is migrated,
we remove the tests from bats at that time. All new tests
should be just for the ginkgo framework.
One exception is that we only run the ginkgo suit in the
travis/ubuntu environment. The CentOS and Fedora PAPR nodes
will more than cover those.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #261
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
| |
conmon should not be built in two different places.
conmon is now a separate package in Fedora so we can just
add requires, for use on Ubuntu we can just require cri-o to
be installed.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #151
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
|
| |
Add results check to make sure the container is not shows up after
it is stopped. And also add some debug lines to help to figure out
which step has problem if case failed.
Signed-off-by: Yiqiao Pu <ypu@redhat.com>
Closes: #264
Approved by: rhatdan
|
|
|
|
|
|
|
| |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #255
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
| |
The order of the flags was casuing issue.
Enabled SkipArgReorder to fix the problem.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #259
Approved by: rhatdan
|
|\
| |
| | |
podman port
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
podman port reports the port mappings per container. it can be used
to report the ports ofa single container or latest container or all
containers.
in the case of a single container, the user can add an option filter for
port and protocol.
Signed-off-by: baude <bbaude@redhat.com>
|
|\ \
| |/
|/| |
Update podman_import test to use podman
|
| |
| |
| |
| |
| |
| |
| | |
Update the podman_import test to use podman run, and update the
check method for string check method.
Signed-off-by: Yiqiao Pu <ypu@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When an image has a port to expose, we need to expose it. User's input overrides the
image's port information.
Also, enable port information in ps so we can see which random port is assigned.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #249
Approved by: rhatdan
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Adds the ability to override the container's hostname. Also, uses
the first twelve characters of the container ID as the default hostname
if none is provided.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #248
Approved by: baude
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Set up nbetworking ports for the following use cases:
* bind the same port between host and container
* bind a specific host port to a different container port
* bind a random host port to a specific container port
Signed-off-by: baude <bbaude@redhat.com>
Closes: #214
Approved by: baude
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the dns commit, tests were accidently omitted due to a
rebase against master.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #245
Approved by: baude
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove the use of bash -c unless it involves a bash pipe. Also, use
run test_runner.sh inside script so that centos can be happy.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #239
Approved by: baude
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
this test was still referring to KPOD_BINARY and not podman
Signed-off-by: baude <bbaude@redhat.com>
Closes: #235
Approved by: baude
|
|/
|
|
|
|
|
|
|
|
|
| |
memory, memory-reservation, memory-swap, memory-swappiness, kernel-memory,
cpu-period, cou-quota, cpu-shares, cpus, cpuset-cpus, cpuset-mems,
blkio-weight, blkio-weight-device, sysctl, and ulimit
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #221
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
| |
podman run --cidfile /tmp/foo writes the container's id
to a file.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #205
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is desirable to have a --latest switch on the podman wait
command so we can wait on the latest container created to end.
Also, fixes a panic with latest where no containers are available.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #201
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
| |
With certain short name usages, rmi still was unable to delete
certain images. This was also reflected in several commit tests
that were temporarily disabled.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #200
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is desirable to have a shortcut for the most
recently created container. We can now use "**latest"
to represent the most recent container instead of its
container ID or name. For example:
Signed-off-by: baude <bbaude@redhat.com>
Closes: #179
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
| |
Removing by shortname was not working. Also pruned
container storage's remove func from rmi and moved it into
an image.Remove func, which consolidates our usage of cs.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #188
Approved by: baude
|
|
|
|
|
|
|
|
|
|
| |
In our tests, each test instance is already seeded with images. In that case,
we do not need to pull down an image that is already seeded.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #191
Approved by: baude
|
|
|
|
|
|
|
| |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Closes: #190
Approved by: mheon
|
|
|
|
|
|
|
|
|
| |
Also add buildah as a requirement so that kpod build tests will run
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #187
Approved by: mheon
|
|
|
|
|
|
|
| |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #183
Approved by: TomSweeneyRedHat
|
|
|
|
|
|
|
|
|
| |
Remove the skip for three tests as podman rm -f and podman stop works
Signed-off-by: Yiqiao Pu <ypu@redhat.com>
Closes: #180
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
| |
The output from podman run may include some debug information which
will make the ctr_id contains unexpect lines.
Signed-off-by: Yiqiao Pu <ypu@redhat.com>
Closes: #180
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
|
| |
Allow for the user to specify network=host|bridge. If network
is not specified, the default will be bridge. While "none" is now
a valid option, it is not included in this.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #164
Approved by: rhatdan
|
|
|
|
|
|
|
| |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Closes: #162
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
| |
podman needs a pair of configuration files to set up its default
network configuration: a bridge and loopback file.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #161
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
| |
podman commit allows the user to commit containers
as images with options of tagging th image, setting
a commit message, setting the auther, and making
changes to the instructions.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #143
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
| |
Also add --quiet option to kpod create/run since
this will help with writing tests.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #140
Approved by: TomSweeneyRedHat
|
|
|
|
|
|
|
|
|
| |
The decision is in, kpod is going to be named podman.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #145
Approved by: umohnani8
|