From 9f8f9a0d1b59eddc15ba3523f55e6d3cc872822e Mon Sep 17 00:00:00 2001 From: Šimon Lukašík Date: Sun, 4 Nov 2018 18:50:53 +0100 Subject: Lint: Exclude autogenerated files from lint test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Šimon Lukašík --- .tool/lint | 1 + 1 file changed, 1 insertion(+) (limited to '.tool/lint') diff --git a/.tool/lint b/.tool/lint index b7006c8fd..60ba3f32a 100755 --- a/.tool/lint +++ b/.tool/lint @@ -40,6 +40,7 @@ ${LINTER} \ --exclude='.*_test\.go:.*error return value not checked.*\(errcheck\)$'\ --exclude='duplicate of.*_test.go.*\(dupl\)$'\ --exclude='cmd\/client\/.*\.go.*\(dupl\)$'\ + --exclude='libpod\/.*_easyjson.go:.*'\ --exclude='vendor\/.*'\ --exclude='podman\/.*'\ --exclude='server\/seccomp\/.*\.go.*$'\ -- cgit v1.2.3-54-g00ecf From e93834576036ef0a5e1d5867e522d1d90a63d358 Mon Sep 17 00:00:00 2001 From: Šimon Lukašík Date: Sat, 10 Nov 2018 10:44:03 +0100 Subject: Lint: Silence few given goconst lint warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While we have these string literals on repeated on multiple places in the library, I cannot see real tangible benefit extracting these to constants considering following facts: (1) while 'unknown' or 'host' are repeated, they are often times used in different context and thus perhaps worth extra const per each use. (2) while these string literals repeat, the library is full of string literals with special meaning that should be made constants too (3) readability would suffer Signed-off-by: Šimon Lukašík --- .tool/lint | 1 + 1 file changed, 1 insertion(+) (limited to '.tool/lint') diff --git a/.tool/lint b/.tool/lint index 60ba3f32a..f7bf81c1d 100755 --- a/.tool/lint +++ b/.tool/lint @@ -41,6 +41,7 @@ ${LINTER} \ --exclude='duplicate of.*_test.go.*\(dupl\)$'\ --exclude='cmd\/client\/.*\.go.*\(dupl\)$'\ --exclude='libpod\/.*_easyjson.go:.*'\ + --exclude='.* other occurrence\(s\) of "(container|host|tmpfs|unknown)" found in: .*\(goconst\)$'\ --exclude='vendor\/.*'\ --exclude='podman\/.*'\ --exclude='server\/seccomp\/.*\.go.*$'\ -- cgit v1.2.3-54-g00ecf