From 32564df172659dd844c0bd72671468f058f964de Mon Sep 17 00:00:00 2001
From: Giuseppe Scrivano <gscrivan@redhat.com>
Date: Tue, 28 Apr 2020 12:21:36 +0200
Subject: cmd, podman: use String instead of variable+StringVar

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
---
 cmd/podman/common/create.go | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/cmd/podman/common/create.go b/cmd/podman/common/create.go
index a0aed984c..e64b84519 100644
--- a/cmd/podman/common/create.go
+++ b/cmd/podman/common/create.go
@@ -49,9 +49,7 @@ func GetCreateFlags(cf *ContainerCLIOpts) *pflag.FlagSet {
 		"cap-drop", []string{},
 		"Drop capabilities from the container",
 	)
-	cgroupNS := ""
-	createFlags.StringVar(
-		&cgroupNS,
+	createFlags.String(
 		"cgroupns", containerConfig.CgroupNS(),
 		"cgroup namespace to use",
 	)
@@ -248,9 +246,7 @@ func GetCreateFlags(cf *ContainerCLIOpts) *pflag.FlagSet {
 		"interactive", "i", false,
 		"Keep STDIN open even if not attached",
 	)
-	ipcNS := ""
-	createFlags.StringVar(
-		&ipcNS,
+	createFlags.String(
 		"ipc", containerConfig.IPCNS(),
 		"IPC namespace to use",
 	)
@@ -331,9 +327,7 @@ func GetCreateFlags(cf *ContainerCLIOpts) *pflag.FlagSet {
 		"use `OS` instead of the running OS for choosing images",
 	)
 	// markFlagHidden(createFlags, "override-os")
-	pid := ""
-	createFlags.StringVar(
-		&pid,
+	createFlags.String(
 		"pid", containerConfig.PidNS(),
 		"PID namespace to use",
 	)
@@ -397,9 +391,7 @@ func GetCreateFlags(cf *ContainerCLIOpts) *pflag.FlagSet {
 		"security-opt", containerConfig.SecurityOptions(),
 		"Security Options",
 	)
-	shmSize := ""
-	createFlags.StringVar(
-		&shmSize,
+	createFlags.String(
 		"shm-size", containerConfig.ShmSize(),
 		"Size of /dev/shm "+sizeWithUnitFormat,
 	)
@@ -464,15 +456,11 @@ func GetCreateFlags(cf *ContainerCLIOpts) *pflag.FlagSet {
 		"user", "u", "",
 		"Username or UID (format: <name|uid>[:<group|gid>])",
 	)
-	userNS := ""
-	createFlags.StringVar(
-		&userNS,
+	createFlags.String(
 		"userns", containerConfig.Containers.UserNS,
 		"User namespace to use",
 	)
-	utsNS := ""
-	createFlags.StringVar(
-		&utsNS,
+	createFlags.String(
 		"uts", containerConfig.Containers.UTSNS,
 		"UTS namespace to use",
 	)
-- 
cgit v1.2.3-54-g00ecf