From 3690532b3be186c03071d9c845295e7158a0f7f5 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Wed, 10 Nov 2021 21:16:30 +0100 Subject: network reload return error if we cannot reload ports As rootless we have to reload the port mappings. If it fails we should return an error instead of the warning. Signed-off-by: Paul Holzinger --- libpod/networking_slirp4netns.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libpod/networking_slirp4netns.go b/libpod/networking_slirp4netns.go index 8dbd12c6e..674075e23 100644 --- a/libpod/networking_slirp4netns.go +++ b/libpod/networking_slirp4netns.go @@ -686,10 +686,7 @@ func (c *Container) reloadRootlessRLKPortMapping() error { conn, err := openUnixSocket(filepath.Join(c.runtime.config.Engine.TmpDir, "rp", c.config.ID)) if err != nil { - // This is not a hard error for backwards compatibility. A container started - // with an old version did not created the rootlessport socket. - logrus.Warnf("Could not reload rootless port mappings, port forwarding may no longer work correctly: %v", err) - return nil + return errors.Wrap(err, "could not reload rootless port mappings, port forwarding may no longer work correctly") } defer conn.Close() enc := json.NewEncoder(conn) -- cgit v1.2.3-54-g00ecf