From 484f1834ab17a2ccb56ed05dfbf50941a2e58d25 Mon Sep 17 00:00:00 2001 From: Chris Evich Date: Tue, 3 May 2022 13:59:00 -0400 Subject: Cirrus: Fix Makefile including 'hack' in $PATH This path should never, ever, ever be included in `$PATH` as it is almost guaranteed to cause serious and non-obvious breakage in CI. Fix it and include a warning comment. Signed-off-by: Chris Evich --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bf60d26c8..66d1a94ff 100644 --- a/Makefile +++ b/Makefile @@ -134,7 +134,8 @@ ifeq ($(GOBIN),) GOBIN := $(FIRST_GOPATH)/bin endif -export PATH := $(PATH):$(GOBIN):$(CURDIR)/hack +# This must never include the 'hack' directory +export PATH := $(PATH):$(GOBIN) GOMD2MAN ?= $(shell command -v go-md2man || echo '$(GOBIN)/go-md2man') -- cgit v1.2.3-54-g00ecf