From 55c9cfb80e066713f009547f7df7dddd2da35eb8 Mon Sep 17 00:00:00 2001
From: baude <bbaude@redhat.com>
Date: Thu, 9 Nov 2017 09:29:15 -0600
Subject: Add cpu-profiling to kpod

Add a global flag for cpu-profiling to allow us to
profile kpod for performance issues.

To parse its results, use:

go tool pprof --text <profile_path>

Signed-off-by: baude <bbaude@redhat.com>

Closes: #36
Approved by: mheon
---
 cmd/kpod/main.go      | 20 +++++++++++++++++++-
 completions/bash/kpod |  1 +
 docs/kpod.1.md        |  3 +++
 3 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/cmd/kpod/main.go b/cmd/kpod/main.go
index ab95995fe..97d942a3c 100644
--- a/cmd/kpod/main.go
+++ b/cmd/kpod/main.go
@@ -3,8 +3,10 @@ package main
 import (
 	"fmt"
 	"os"
+	"runtime/pprof"
 
 	"github.com/containers/storage/pkg/reexec"
+	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 	"github.com/urfave/cli"
 )
@@ -15,6 +17,7 @@ var kpodVersion = ""
 
 func main() {
 	debug := false
+	cpuProfile := false
 
 	if reexec.Init() {
 		return
@@ -77,12 +80,23 @@ func main() {
 			debug = true
 
 		}
-
+		if c.GlobalIsSet("cpu-profile") {
+			f, err := os.Create(c.GlobalString("cpu-profile"))
+			if err != nil {
+				return errors.Wrapf(err, "unable to create cpu profiling file %s",
+					c.GlobalString("cpu-profile"))
+			}
+			cpuProfile = true
+			pprof.StartCPUProfile(f)
+		}
 		return nil
 	}
 	app.After = func(*cli.Context) error {
 		// called by Run() when the command handler succeeds
 		shutdownStores()
+		if cpuProfile {
+			pprof.StopCPUProfile()
+		}
 		return nil
 	}
 	cli.OsExiter = func(code int) {
@@ -99,6 +113,10 @@ func main() {
 			Name:  "conmon",
 			Usage: "path of the conmon binary",
 		},
+		cli.StringFlag{
+			Name:  "cpu-profile",
+			Usage: "path for the cpu profiling results",
+		},
 		cli.StringFlag{
 			Name:  "log-level",
 			Usage: "log messages above specified level: debug, info, warn, error (default), fatal or panic",
diff --git a/completions/bash/kpod b/completions/bash/kpod
index 2387228cb..c13e64379 100644
--- a/completions/bash/kpod
+++ b/completions/bash/kpod
@@ -1410,6 +1410,7 @@ _kpod_logout() {
 _kpod_kpod() {
      local options_with_args="
            --config -c
+           --cpu-profile
            --root
            --runroot
            --storage-driver
diff --git a/docs/kpod.1.md b/docs/kpod.1.md
index 408ad3877..f1b74b58f 100644
--- a/docs/kpod.1.md
+++ b/docs/kpod.1.md
@@ -26,6 +26,9 @@ has the capability to debug pods/images created by crio.
 **--config value, -c**=**"config.file"**
    Path of a config file detailing container server configuration options
 
+**--cpu-profile**
+   Path to where the cpu performance results should be written
+
 **--log-level**
    log messages above specified level: debug, info, warn, error (default), fatal or panic
 
-- 
cgit v1.2.3-54-g00ecf