From 5c108f75ebdf4bf9214504f8b170ffabff1a38d4 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Wed, 29 Apr 2020 14:42:30 +0200 Subject: login system test: enable "push ok" Signed-off-by: Valentin Rothberg --- pkg/bindings/images/images.go | 5 +++-- test/system/150-login.bats | 2 -- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/bindings/images/images.go b/pkg/bindings/images/images.go index ff49ca914..63fe2556b 100644 --- a/pkg/bindings/images/images.go +++ b/pkg/bindings/images/images.go @@ -311,8 +311,9 @@ func Push(ctx context.Context, source string, destination string, options entiti params.Set("credentials", options.Credentials) params.Set("destination", destination) if options.SkipTLSVerify != types.OptionalBoolUndefined { - val := bool(options.SkipTLSVerify == types.OptionalBoolTrue) - params.Set("tlsVerify", strconv.FormatBool(!val)) + // Note: we have to verify if skipped is false. + verifyTLS := bool(options.SkipTLSVerify == types.OptionalBoolFalse) + params.Set("tlsVerify", strconv.FormatBool(verifyTLS)) } path := fmt.Sprintf("/images/%s/push", source) diff --git a/test/system/150-login.bats b/test/system/150-login.bats index 3edb11c2f..a6f9aab85 100644 --- a/test/system/150-login.bats +++ b/test/system/150-login.bats @@ -166,8 +166,6 @@ function setup() { # Some push tests @test "podman push fail" { - skip "Not working for v2 yet" - # Create an invalid authfile authfile=${PODMAN_LOGIN_WORKDIR}/auth-$(random_string 10).json rm -f $authfile -- cgit v1.2.3-54-g00ecf