From d628de31d71b1849fdb102f8689faa80fe286b83 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Tue, 21 Jul 2020 13:30:07 +0200 Subject: unit tests: root check The unit tests currently require running as root. This has caused some confusion that justifies adding a root check to `make localunit` and error out for non-root users instead of starting the tests deemed to fail. Signed-off-by: Valentin Rothberg --- Makefile | 1 + hack/check_root.sh | 5 +++++ 2 files changed, 6 insertions(+) create mode 100755 hack/check_root.sh diff --git a/Makefile b/Makefile index 71b4772c4..132dde939 100644 --- a/Makefile +++ b/Makefile @@ -307,6 +307,7 @@ testunit: libpodimage ## Run unittest on the built image .PHONY: localunit localunit: test/goecho/goecho varlink_generate + hack/check_root.sh make localunit ginkgo \ -r \ $(TESTFLAGS) \ diff --git a/hack/check_root.sh b/hack/check_root.sh new file mode 100755 index 000000000..203eae9d3 --- /dev/null +++ b/hack/check_root.sh @@ -0,0 +1,5 @@ +#!/bin/bash +if ! [ $(id -u) = 0 ]; then + echo "Please run as root! '$@' requires root privileges." + exit 1 +fi -- cgit v1.2.3-54-g00ecf