From 84021cfdc3c968535208c6c25bef18a477f8bea1 Mon Sep 17 00:00:00 2001 From: Radostin Stoyanov Date: Fri, 19 Nov 2021 13:02:58 +0000 Subject: test: Update error string for --file-locks test Use a substring matching the end of the error message. Closes: #12366 Signed-off-by: Radostin Stoyanov --- test/e2e/checkpoint_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/checkpoint_test.go b/test/e2e/checkpoint_test.go index 4963b04fc..6b9a96e9f 100644 --- a/test/e2e/checkpoint_test.go +++ b/test/e2e/checkpoint_test.go @@ -1355,7 +1355,7 @@ var _ = Describe("Podman checkpoint", func() { result := podmanTest.Podman([]string{"container", "checkpoint", "test_name"}) result.WaitWithDefaultTimeout() Expect(result).Should(Exit(125)) - Expect(result.ErrorToString()).To(ContainSubstring("criu failed")) + Expect(result.ErrorToString()).To(ContainSubstring("failed: exit status 1")) Expect(podmanTest.NumberOfContainersRunning()).To(Equal(1)) // Checkpoint is expected to succeed with --file-locks -- cgit v1.2.3-54-g00ecf From b2623ceb4b8a55ba46d1262dac220f0eb4e4eabd Mon Sep 17 00:00:00 2001 From: Radostin Stoyanov Date: Fri, 19 Nov 2021 13:03:06 +0000 Subject: api/handlers: Add checkpoint/restore FileLocks Signed-off-by: Radostin Stoyanov --- pkg/api/handlers/libpod/containers.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/api/handlers/libpod/containers.go b/pkg/api/handlers/libpod/containers.go index d5da22a91..21c72bbda 100644 --- a/pkg/api/handlers/libpod/containers.go +++ b/pkg/api/handlers/libpod/containers.go @@ -221,6 +221,7 @@ func Checkpoint(w http.ResponseWriter, r *http.Request) { PrintStats bool `schema:"printStats"` PreCheckpoint bool `schema:"preCheckpoint"` WithPrevious bool `schema:"withPrevious"` + FileLocks bool `schema:"fileLocks"` }{ // override any golang type defaults } @@ -246,6 +247,7 @@ func Checkpoint(w http.ResponseWriter, r *http.Request) { PrintStats: query.PrintStats, PreCheckPoint: query.PreCheckpoint, WithPrevious: query.WithPrevious, + FileLocks: query.FileLocks, } if query.Export { @@ -305,6 +307,7 @@ func Restore(w http.ResponseWriter, r *http.Request) { IgnoreStaticIP bool `schema:"ignoreStaticIP"` IgnoreStaticMAC bool `schema:"ignoreStaticMAC"` PrintStats bool `schema:"printStats"` + FileLocks bool `schema:"fileLocks"` PublishPorts string `schema:"publishPorts"` }{ // override any golang type defaults @@ -324,6 +327,7 @@ func Restore(w http.ResponseWriter, r *http.Request) { IgnoreStaticIP: query.IgnoreStaticIP, IgnoreStaticMAC: query.IgnoreStaticMAC, PrintStats: query.PrintStats, + FileLocks: query.FileLocks, PublishPorts: strings.Fields(query.PublishPorts), } -- cgit v1.2.3-54-g00ecf