From 774a36d1771b083825fcf4c89385e90499537cb1 Mon Sep 17 00:00:00 2001
From: Alex Jia <chuanchang.jia@gmail.com>
Date: Fri, 18 Oct 2019 12:43:23 +0800
Subject: System tests: make sure exec pid hash w/o leaking

podman exec leaks an exec_pid_<hash> file for every exec in tmpfs,
it's known rhbz#1731117, this case makes sure leakage issue has
been fixed.

rhbz: https://bugzilla.redhat.com/show_bug.cgi?id=1731117

Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
---
 test/system/075-exec.bats | 20 ++++++++++++++++++++
 test/system/helpers.bash  | 14 ++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/test/system/075-exec.bats b/test/system/075-exec.bats
index 11cb98269..472fdd1ab 100644
--- a/test/system/075-exec.bats
+++ b/test/system/075-exec.bats
@@ -29,4 +29,24 @@ load helpers
     run_podman rm $cid
 }
 
+@test "podman exec - leak check" {
+    skip_if_remote
+
+    # Start a container in the background then run exec command
+    # three times and make sure no any exec pid hash file leak
+    run_podman run -td $IMAGE /bin/sh
+    cid="$output"
+
+    is "$(check_exec_pid)" "" "exec pid hash file indeed doesn't exist"
+
+    for i in {1..3}; do
+        run_podman exec $cid /bin/true
+    done
+
+    is "$(check_exec_pid)" "" "there isn't any exec pid hash file leak"
+
+    run_podman stop --time 1 $cid
+    run_podman rm -f $cid
+}
+
 # vim: filetype=sh
diff --git a/test/system/helpers.bash b/test/system/helpers.bash
index 3d607f4bd..8c061d2c9 100644
--- a/test/system/helpers.bash
+++ b/test/system/helpers.bash
@@ -373,5 +373,19 @@ function random_string() {
     head /dev/urandom | tr -dc a-zA-Z0-9 | head -c$length
 }
 
+
+#########################
+#  find_exec_pid_files  #  Returns nothing or exec_pid hash files
+#########################
+#
+# Return exec_pid hash files if exists, otherwise, return nothing
+#
+function find_exec_pid_files() {
+    run_podman info --format '{{.store.RunRoot}}'
+    local storage_path="$output"
+    if [ -d $storage_path ]; then
+        find $storage_path -type f -iname 'exec_pid_*'
+    fi
+}
 # END   miscellaneous tools
 ###############################################################################
-- 
cgit v1.2.3-54-g00ecf