From cabe1345f8d8462421853c864c6d8a898713986c Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Mon, 16 Sep 2019 09:22:26 -0400 Subject: Unmounting a container that is already unmounted is OK We should not be throwing errors because the operation we wanted to perform is already done. Now, it is definitely strange that a container is actually unmounted, but shows as mounted in the DB - if this reoccurs in a way where we can investigate, it's worth tearing into. Fixes #4033 Signed-off-by: Matthew Heon --- libpod/container_internal.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libpod/container_internal.go b/libpod/container_internal.go index 6bf8439da..8b96b3f62 100644 --- a/libpod/container_internal.go +++ b/libpod/container_internal.go @@ -1368,7 +1368,7 @@ func (c *Container) cleanupStorage() error { // error // We still want to be able to kick the container out of the // state - if errors.Cause(err) == storage.ErrNotAContainer || errors.Cause(err) == storage.ErrContainerUnknown { + if errors.Cause(err) == storage.ErrNotAContainer || errors.Cause(err) == storage.ErrContainerUnknown || errors.Cause(err) == storage.ErrLayerNotMounted { logrus.Errorf("Storage for container %s has been removed", c.ID()) } else { if cleanupErr != nil { -- cgit v1.2.3-54-g00ecf