From cf42bdcb41f34b5cdfc15e865089ec1e88681e25 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Mon, 15 Feb 2021 15:07:25 +0100 Subject: e2e: fix network alias test The logic in the e2e test for multiple network aliases is indicating the test should wait for the containerized nginx to be ready. As this may take some time, the test does an exponential backoff starting at 2050ms. Fix the logic by removing the `Expect(...)` call during the exponential backoff. Otherwise, the test errors immediately. Signed-off-by: Valentin Rothberg --- test/e2e/network_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/e2e/network_test.go b/test/e2e/network_test.go index df8ff0684..d191cb6bb 100644 --- a/test/e2e/network_test.go +++ b/test/e2e/network_test.go @@ -407,6 +407,7 @@ var _ = Describe("Podman network", func() { Expect(lines[0]).To(Equal(netName1)) Expect(lines[1]).To(Equal(netName2)) }) + It("podman network with multiple aliases", func() { var worked bool netName := "aliasTest" + stringid.GenerateNonCryptoID() @@ -424,7 +425,7 @@ var _ = Describe("Podman network", func() { // Test curl against the container's name c1 := podmanTest.Podman([]string{"run", "--network=" + netName, nginx, "curl", "web"}) c1.WaitWithDefaultTimeout() - worked = Expect(c1.ExitCode()).To(BeZero()) + worked = c1.ExitCode() == 0 if worked { break } -- cgit v1.2.3-54-g00ecf