From 11fbd20f5dcd095cf010c4c1903b8a8989db16bb Mon Sep 17 00:00:00 2001 From: Peter Hunt Date: Wed, 19 Jun 2019 10:04:06 -0400 Subject: Spoof json-file logging support For docker scripting compatibility, allow for json-file logging when creating args for conmon. That way, when json-file is supported, that case can be easily removed. Signed-off-by: Peter Hunt --- libpod/oci_linux.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libpod/oci_linux.go b/libpod/oci_linux.go index 9bbefdb06..6e84c0759 100644 --- a/libpod/oci_linux.go +++ b/libpod/oci_linux.go @@ -246,7 +246,9 @@ func (r *OCIRuntime) createOCIContainer(ctr *Container, cgroupParent string, res } logDriver := KubernetesLogging - if ctr.LogDriver() != "" { + if ctr.LogDriver() == JSONLogging { + logrus.Errorf("json-file logging specified but not supported. Choosing k8s-file logging instead") + } else if ctr.LogDriver() != "" { logDriver = ctr.LogDriver() } args = append(args, "-l", fmt.Sprintf("%s:%s", logDriver, ctr.LogPath())) -- cgit v1.2.3-54-g00ecf From 47e2ad8ec37a136851639145579cba34ab973e0d Mon Sep 17 00:00:00 2001 From: Peter Hunt Date: Wed, 19 Jun 2019 12:50:05 -0400 Subject: Fix documentation for log-driver Signed-off-by: Peter Hunt --- docs/podman-create.1.md | 2 +- docs/podman-run.1.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/podman-create.1.md b/docs/podman-create.1.md index 9ab7b201a..b08488d7b 100644 --- a/docs/podman-create.1.md +++ b/docs/podman-create.1.md @@ -382,7 +382,7 @@ Not implemented **--log-driver**="*k8s-file*" -Logging driver for the container. Currently not supported. This flag is a NOOP provided solely for scripting compatibility. +Logging driver for the container. Currently available options are *k8s-file* and *journald*, with *json-file* aliased to *k8s-file* for scripting compatibility. **--log-opt**=*path* diff --git a/docs/podman-run.1.md b/docs/podman-run.1.md index c678d2a4c..042a7a561 100644 --- a/docs/podman-run.1.md +++ b/docs/podman-run.1.md @@ -395,7 +395,7 @@ Not implemented **--log-driver**="*k8s-file*" -Logging driver for the container. Currently not supported. This flag is a NOOP provided solely for scripting compatibility. +Logging driver for the container. Currently available options are *k8s-file* and *journald*, with *json-file* aliased to *k8s-file* for scripting compatibility. **--log-opt**=*path* -- cgit v1.2.3-54-g00ecf