From ca4f6ec1dbdfd06f3d403eda70dbb2eff3824888 Mon Sep 17 00:00:00 2001
From: Paul Holzinger <paul.holzinger@web.de>
Date: Fri, 23 Apr 2021 10:52:52 +0200
Subject: Parse slirp4netns net options with compat api

Parse the slirp4netns network options when called via compat api. The
options must be extracted from the NetworkMode string.

Fixes #10110

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
---
 cmd/podman/common/create_opts.go                 | 21 ++++++++++++---------
 test/compose/slirp4netns_opts/docker-compose.yml |  5 +++++
 test/compose/slirp4netns_opts/setup.sh           |  8 ++++++++
 test/compose/slirp4netns_opts/teardown.sh        |  4 ++++
 test/compose/slirp4netns_opts/tests.sh           |  6 ++++++
 5 files changed, 35 insertions(+), 9 deletions(-)
 create mode 100644 test/compose/slirp4netns_opts/docker-compose.yml
 create mode 100644 test/compose/slirp4netns_opts/setup.sh
 create mode 100644 test/compose/slirp4netns_opts/teardown.sh
 create mode 100644 test/compose/slirp4netns_opts/tests.sh

diff --git a/cmd/podman/common/create_opts.go b/cmd/podman/common/create_opts.go
index 040dc6570..983b9e5ca 100644
--- a/cmd/podman/common/create_opts.go
+++ b/cmd/podman/common/create_opts.go
@@ -252,21 +252,24 @@ func ContainerCreateToContainerCLIOpts(cc handlers.CreateContainerConfig, cgroup
 		return nil, nil, err
 	}
 
-	netNS := specgen.Namespace{
-		NSMode: nsmode.NSMode,
-		Value:  nsmode.Value,
+	var netOpts map[string][]string
+	parts := strings.SplitN(string(cc.HostConfig.NetworkMode), ":", 2)
+	if len(parts) > 1 {
+		netOpts = make(map[string][]string)
+		netOpts[parts[0]] = strings.Split(parts[1], ",")
 	}
 
 	// network
 	// Note: we cannot emulate compat exactly here. we only allow specifics of networks to be
 	// defined when there is only one network.
 	netInfo := entities.NetOptions{
-		AddHosts:     cc.HostConfig.ExtraHosts,
-		DNSOptions:   cc.HostConfig.DNSOptions,
-		DNSSearch:    cc.HostConfig.DNSSearch,
-		DNSServers:   dns,
-		Network:      netNS,
-		PublishPorts: specPorts,
+		AddHosts:       cc.HostConfig.ExtraHosts,
+		DNSOptions:     cc.HostConfig.DNSOptions,
+		DNSSearch:      cc.HostConfig.DNSSearch,
+		DNSServers:     dns,
+		Network:        nsmode,
+		PublishPorts:   specPorts,
+		NetworkOptions: netOpts,
 	}
 
 	// network names
diff --git a/test/compose/slirp4netns_opts/docker-compose.yml b/test/compose/slirp4netns_opts/docker-compose.yml
new file mode 100644
index 000000000..dcdcae04c
--- /dev/null
+++ b/test/compose/slirp4netns_opts/docker-compose.yml
@@ -0,0 +1,5 @@
+services:
+  alpine:
+    image: alpine
+    network_mode: "slirp4netns:allow_host_loopback=true"
+    command: sh -c "echo teststring | nc 10.0.2.2 5001"
diff --git a/test/compose/slirp4netns_opts/setup.sh b/test/compose/slirp4netns_opts/setup.sh
new file mode 100644
index 000000000..35bbf7c70
--- /dev/null
+++ b/test/compose/slirp4netns_opts/setup.sh
@@ -0,0 +1,8 @@
+# -*- bash -*-
+
+# create tempfile to store nc output
+OUTFILE=$(mktemp)
+# listen on a port, the container will try to connect to it
+nc -l 5001 > $OUTFILE &
+
+nc_pid=$!
diff --git a/test/compose/slirp4netns_opts/teardown.sh b/test/compose/slirp4netns_opts/teardown.sh
new file mode 100644
index 000000000..656724363
--- /dev/null
+++ b/test/compose/slirp4netns_opts/teardown.sh
@@ -0,0 +1,4 @@
+# -*- bash -*-
+
+kill $nc_pid &> /dev/null
+rm -f $OUTFILE
diff --git a/test/compose/slirp4netns_opts/tests.sh b/test/compose/slirp4netns_opts/tests.sh
new file mode 100644
index 000000000..1efce45c4
--- /dev/null
+++ b/test/compose/slirp4netns_opts/tests.sh
@@ -0,0 +1,6 @@
+# -*- bash -*-
+
+output="$(cat $OUTFILE)"
+expected="teststring"
+
+is "$output" "$expected" "$testname : nc received teststring"
-- 
cgit v1.2.3-54-g00ecf