From 0f0ba530306701cc7443d4a0e514149d8329b75d Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Thu, 7 Feb 2019 13:20:14 +0100 Subject: make vendor: always check for latest vndr @baude and I have recently debugged a `make vendor` issue, where different versions of `vndr` leave slightly different states behind. This ultimately leads to inconsistencies with the CI, which always fetches the latest version. To avoid such issues in the future, always use the latest version of `vndr` by checking for new versions of it prior to execution. Signed-off-by: Valentin Rothberg --- Makefile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'Makefile') diff --git a/Makefile b/Makefile index df8549541..2ec7f7a4e 100644 --- a/Makefile +++ b/Makefile @@ -289,7 +289,7 @@ uninstall: install.tools: .install.gitvalidation .install.gometalinter .install.md2man .install.ginkgo ## Install needed tools .install.vndr: .gopathok - $(GO) get github.com/LK4D4/vndr + $(GO) get -u github.com/LK4D4/vndr .install.ginkgo: .gopathok if [ ! -x "$(GOBIN)/ginkgo" ]; then \ @@ -348,10 +348,11 @@ build-all-new-commits: # Validate that all the commits build on top of $(GIT_BASE_BRANCH) git rebase $(GIT_BASE_BRANCH) -x make -vendor: - vndr -whitelist "github.com/varlink/go" \ - -whitelist "github.com/onsi/ginkgo" \ - -whitelist "github.com/onsi/gomega" +vendor: .install.vndr + $(GOPATH)/bin/vndr \ + -whitelist "github.com/varlink/go" \ + -whitelist "github.com/onsi/ginkgo" \ + -whitelist "github.com/onsi/gomega" .PHONY: \ .gopathok \ -- cgit v1.2.3-54-g00ecf