From de05e5816869073600ae8e851093b4b9a9d7fab0 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Mon, 18 Jan 2021 13:20:32 +0100 Subject: ginkgo: install on demand via `go get -u` Install ginkgo on demand via `go get -u` rather than keeping a copy it's entire source code in the vendor dirctory. The main motivation for that is to make `golangci-lint` happy which is continuously throwing up on the import of a program (i.e., ginkgo). The linter is broken and stupid as it ignores flags to ignore dirs and ignores build tags (at least some linters do) which is blocking us from updating to newer versions. Signed-off-by: Valentin Rothberg --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Makefile') diff --git a/Makefile b/Makefile index 7d307793c..864efa03e 100644 --- a/Makefile +++ b/Makefile @@ -598,7 +598,7 @@ endef .PHONY: .install.ginkgo .install.ginkgo: .gopathok if [ ! -x "$(GOBIN)/ginkgo" ]; then \ - $(GO) install $(BUILDFLAGS) ./vendor/github.com/onsi/ginkgo/ginkgo ; \ + go get -u github.com/onsi/ginkgo/ginkgo@v1.14.2; \ fi .PHONY: .install.gitvalidation -- cgit v1.2.3-54-g00ecf