From 677a0e5d60c45711cba56032c23783c1d010a49e Mon Sep 17 00:00:00 2001 From: TomSweeneyRedHat Date: Wed, 30 Oct 2019 19:36:42 -0400 Subject: Validate contextdir on build We never verified that the context directory passed into the build command was a valid directory. When we then slapped a default Containerfile name onto it, things went south fast if the user had passed us a file and not a directory. Fixes: #4383 Signed-off-by: TomSweeneyRedHat --- cmd/podman/build.go | 3 +++ 1 file changed, 3 insertions(+) (limited to 'cmd/podman/build.go') diff --git a/cmd/podman/build.go b/cmd/podman/build.go index 896d5661a..bbc1d5b5f 100644 --- a/cmd/podman/build.go +++ b/cmd/podman/build.go @@ -238,6 +238,9 @@ func buildCmd(c *cliconfig.BuildValues) error { if contextDir == "" { return errors.Errorf("no context directory specified, and no containerfile specified") } + if !fileIsDir(contextDir) { + return errors.Errorf("context must be a directory: %v", contextDir) + } if len(containerfiles) == 0 { if checkIfFileExists(filepath.Join(contextDir, "Containerfile")) { containerfiles = append(containerfiles, filepath.Join(contextDir, "Containerfile")) -- cgit v1.2.3-54-g00ecf