From 4344639508ccd16041d1ec7fd531b6427f930374 Mon Sep 17 00:00:00 2001 From: baude Date: Tue, 6 Mar 2018 10:42:13 -0600 Subject: podman import, load, and commit are too verbose The progress should not be show for import, load, and commit. It makes machine parsing of the output much more difficult. Also, each command should output an image ID or name for the user. Added a --verbose flag for users that still want to see progress. Resolves issue #450 Signed-off-by: baude Closes: #456 Approved by: rhatdan --- cmd/podman/commit.go | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) (limited to 'cmd/podman/commit.go') diff --git a/cmd/podman/commit.go b/cmd/podman/commit.go index 5d37458ea..59ced293f 100644 --- a/cmd/podman/commit.go +++ b/cmd/podman/commit.go @@ -1,6 +1,9 @@ package main import ( + "fmt" + "os" + "github.com/opencontainers/image-spec/specs-go/v1" "github.com/pkg/errors" "github.com/projectatomic/libpod/libpod" @@ -25,6 +28,10 @@ var ( Name: "pause, p", Usage: "Pause container during commit", }, + cli.BoolFlag{ + Name: "quiet, q", + Usage: "Suppress output", + }, } commitDescription = `Create an image from a container's changes. Optionally tag the image created, set the author with the --author flag, @@ -84,10 +91,19 @@ func commitCmd(c *cli.Context) error { Author: c.String("author"), } opts.ImageConfig = config + opts.Writer = nil + + if !c.Bool("quiet") { + opts.Writer = os.Stderr + } ctr, err := runtime.LookupContainer(container) if err != nil { return errors.Wrapf(err, "error looking up container %q", container) } - return ctr.Commit(c.BoolT("pause"), opts) + img, err := ctr.Commit(c.BoolT("pause"), opts) + if err == nil { + fmt.Println(img.ID) + } + return nil } -- cgit v1.2.3-54-g00ecf