From e61838bc3b25faba708856e2208aa2026381a341 Mon Sep 17 00:00:00 2001 From: Peter Hunt Date: Sun, 14 Apr 2019 16:27:52 -0400 Subject: Incorporate image and default environment variables in play kube Also put Environment variable parsing from image data into a helper function Signed-off-by: Peter Hunt --- cmd/podman/play_kube.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'cmd/podman/play_kube.go') diff --git a/cmd/podman/play_kube.go b/cmd/podman/play_kube.go index cbe961279..942794cbe 100644 --- a/cmd/podman/play_kube.go +++ b/cmd/podman/play_kube.go @@ -236,7 +236,6 @@ func getPodPorts(containers []v1.Container) []ocicni.PortMapping { func kubeContainerToCreateConfig(ctx context.Context, containerYAML v1.Container, runtime *libpod.Runtime, newImage *image.Image, namespaces map[string]string, volumes map[string]string) (*createconfig.CreateConfig, error) { var ( containerConfig createconfig.CreateConfig - envs map[string]string ) // The default for MemorySwappiness is -1, not 0 @@ -298,9 +297,10 @@ func kubeContainerToCreateConfig(ctx context.Context, containerYAML v1.Container if len(containerConfig.WorkDir) == 0 { containerConfig.WorkDir = "/" } - if len(containerYAML.Env) > 0 { - envs = make(map[string]string) - } + + // Set default environment variables and incorporate data from image, if necessary + envs := shared.EnvVariablesFromData(imageData) + // Environment Variables for _, e := range containerYAML.Env { envs[e.Name] = e.Value -- cgit v1.2.3-54-g00ecf