From 6a586992c117bd34c69ca6747ac0c0f101c6ea89 Mon Sep 17 00:00:00 2001 From: Jhon Honce Date: Thu, 23 Apr 2020 09:38:35 -0700 Subject: V2 restore podman -v command * Removed extra spaces and improved error message * Updated tests to use gomega matchers Signed-off-by: Jhon Honce --- cmd/podman/root.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'cmd/podman/root.go') diff --git a/cmd/podman/root.go b/cmd/podman/root.go index 56ca549b6..d4fa9ea5b 100644 --- a/cmd/podman/root.go +++ b/cmd/podman/root.go @@ -78,6 +78,10 @@ func init() { ) rootFlags(registry.PodmanConfig(), rootCmd.PersistentFlags()) + + // "version" is a local flag to avoid collisions with sub-commands that use "-v" + var dummyVersion bool + rootCmd.Flags().BoolVarP(&dummyVersion, "version", "v", false, "Version of Podman") } func Execute() { @@ -206,11 +210,6 @@ func rootFlags(opts *entities.PodmanConfig, flags *pflag.FlagSet) { flags.StringVarP(&opts.Uri, "remote", "r", "", "URL to access Podman service") flags.StringSliceVar(&opts.Identities, "identity", []string{}, "path to SSH identity file") - // Override default --help information of `--version` global flag - // TODO: restore -v option for version without breaking -v for volumes - var dummyVersion bool - flags.BoolVar(&dummyVersion, "version", false, "Version of Podman") - cfg := opts.Config flags.StringVar(&cfg.Engine.CgroupManager, "cgroup-manager", cfg.Engine.CgroupManager, opts.CGroupUsage) flags.StringVar(&opts.CpuProfile, "cpu-profile", "", "Path for the cpu profiling results") -- cgit v1.2.3-54-g00ecf