From a328e873c67af2cc469f57b3dc34b46a0f799558 Mon Sep 17 00:00:00 2001 From: Qi Wang Date: Mon, 22 Jul 2019 15:15:38 -0400 Subject: fix import not ignoring url path fix #3609 Podman import used to check filename to only allow tarball path as a file. It should also allow an url as the doc mentioned. This PR allows the program to continue if the input is a valid URL Signed-off-by: Qi Wang --- cmd/podman/shared/parse/parse.go | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'cmd/podman/shared/parse') diff --git a/cmd/podman/shared/parse/parse.go b/cmd/podman/shared/parse/parse.go index a77002235..9fbc92fc3 100644 --- a/cmd/podman/shared/parse/parse.go +++ b/cmd/podman/shared/parse/parse.go @@ -7,6 +7,7 @@ import ( "bufio" "fmt" "net" + "net/url" "os" "regexp" "strings" @@ -162,3 +163,12 @@ func ValidateFileName(filename string) error { } return nil } + +// ValidURL checks a string urlStr is a url or not +func ValidURL(urlStr string) error { + _, err := url.ParseRequestURI(urlStr) + if err != nil { + return errors.Wrapf(err, "invalid url path: %q", urlStr) + } + return nil +} -- cgit v1.2.3-54-g00ecf