From 49ec9b2e3e989413adafffbe023bb1729495ad88 Mon Sep 17 00:00:00 2001
From: baude <bbaude@redhat.com>
Date: Tue, 23 Jan 2018 10:34:00 -0600
Subject: Streamline image resolution

When trying to determine if a user-provided string that describes
an image (ID, fq name, shortname, tagged), there were some
inefficiencies where we looked up images multiple times to derive
information about local images.

Signed-off-by: baude <bbaude@redhat.com>
---
 cmd/podman/create.go | 30 ++++++++----------------------
 1 file changed, 8 insertions(+), 22 deletions(-)

(limited to 'cmd/podman')

diff --git a/cmd/podman/create.go b/cmd/podman/create.go
index 80cb7f432..e0825566a 100644
--- a/cmd/podman/create.go
+++ b/cmd/podman/create.go
@@ -370,10 +370,13 @@ func exposedPorts(c *cli.Context, imageExposedPorts map[string]struct{}) (map[na
 // default container runtime data out of it. imageData returns the data
 // to the caller.  Example Data: Entrypoint, Env, WorkingDir, Labels ...
 func imageData(c *cli.Context, runtime *libpod.Runtime, image string) (string, string, *libpod.ImageData, error) {
-	var err error
+	var (
+		err                error
+		imageName, imageID string
+	)
 	// Deal with the image after all the args have been checked
 	createImage := runtime.NewImage(image)
-	createImage.LocalName, _ = createImage.GetLocalImageName()
+	imageName, imageID, _ = createImage.GetLocalImageName()
 	if createImage.LocalName == "" {
 		// The image wasnt found by the user input'd name or its fqname
 		// Pull the image
@@ -384,31 +387,14 @@ func imageData(c *cli.Context, runtime *libpod.Runtime, image string) (string, s
 		createImage.Pull(writer)
 	}
 
-	var imageName string
-	if createImage.LocalName != "" {
-		nameIsID, err := runtime.IsImageID(createImage.LocalName)
-		if err != nil {
-			return "", "", nil, err
-		}
-		if nameIsID {
-			// If the input from the user is an ID, then we need to get the image
-			// name for cstorage
-			createImage.LocalName, err = createImage.GetNameByID()
-			if err != nil {
-				return "", "", nil, err
-			}
-		}
-		imageName = createImage.LocalName
-	} else {
+	createImage.LocalName = imageName
+	if imageName == "" {
 		imageName, err = createImage.GetFQName()
+		_, imageID, _ = createImage.GetLocalImageName()
 	}
 	if err != nil {
 		return "", "", nil, err
 	}
-	imageID, err := createImage.GetImageID()
-	if err != nil {
-		return "", "", nil, err
-	}
 	storageImage, err := runtime.GetImage(imageName)
 	if err != nil {
 		return "", "", nil, errors.Wrapf(err, "error getting storage image %q", image)
-- 
cgit v1.2.3-54-g00ecf