From 9810e586fe4ec8d9325ae50a23acc0905a2454c3 Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Wed, 8 Jul 2020 13:19:25 -0400 Subject: Fix a bug where --pids-limit was parsed incorrectly The --pids-limit flag was using strconv.ParseInt with bad arguments, resulting in it being unable to parse standard integers (1024, for example, would produce an 'out of range' error). Change the arguments to make sense (base 10, max 32-bit) and add a test to ensure we don't regress again. Fixes #6908 Signed-off-by: Matthew Heon --- cmd/podman/containers/create.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cmd/podman') diff --git a/cmd/podman/containers/create.go b/cmd/podman/containers/create.go index cebf0fa4b..10761be33 100644 --- a/cmd/podman/containers/create.go +++ b/cmd/podman/containers/create.go @@ -202,7 +202,7 @@ func createInit(c *cobra.Command) error { } if c.Flags().Changed("pids-limit") { val := c.Flag("pids-limit").Value.String() - pidsLimit, err := strconv.ParseInt(val, 0, 10) + pidsLimit, err := strconv.ParseInt(val, 10, 32) if err != nil { return err } -- cgit v1.2.3-54-g00ecf