From 38d2ef0cbd32a68a6d2c74b35d75fd9b14a3867a Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Sun, 26 Jan 2020 06:32:31 +0100 Subject: Throw error on invalid sort value We define the valid sort values, so we should throw an error on invalid sort values. Signed-off-by: Daniel J Walsh --- cmd/podman/images.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'cmd/podman') diff --git a/cmd/podman/images.go b/cmd/podman/images.go index 75cdd3465..115f30d9b 100644 --- a/cmd/podman/images.go +++ b/cmd/podman/images.go @@ -159,6 +159,21 @@ func imagesCmd(c *cliconfig.ImagesValues) error { filters = append(filters, fmt.Sprintf("reference=%s", image)) } + var sortValues = map[string]bool{ + "created": true, + "id": true, + "repository": true, + "size": true, + "tag": true, + } + if !sortValues[c.Sort] { + keys := make([]string, 0, len(sortValues)) + for k := range sortValues { + keys = append(keys, k) + } + return errors.Errorf("invalid sort value %q, required values: %s", c.Sort, strings.Join(keys, ", ")) + } + opts := imagesOptions{ quiet: c.Quiet, noHeading: c.Noheading, -- cgit v1.2.3-54-g00ecf